search

publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
267 stars 207 forks source link

Revert "removed refs to jquery-ui" #1696

Closed jywarren closed 2 years ago

jywarren commented 2 years ago

Reverts publiclab/mapknitter#1692 to fix https://github.com/publiclab/mapknitter/issues/1695

gitpod-io[bot] commented 2 years ago

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 737090ee and detected 0 issues on this pull request.

View more on Code Climate.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1696 (610b09e) into main (d501aa4) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 610b09e differs from pull request most recent head 737090e. Consider uploading reports for the commit 737090e to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1696   +/-   ##
=======================================
  Coverage   71.89%   71.89%           
=======================================
  Files          40       40           
  Lines        1409     1409           
=======================================
  Hits         1013     1013           
  Misses        396      396
Impacted Files Coverage Δ
lib/not_at_origin_validator.rb 85.71% <100.00%> (ø)
jywarren commented 2 years ago

Confirmed this worked in gitpod:

image

However we should be careful upon deploying; not sure if this was somehow related to the production deployment issues, we thought we fixed them by updating node to v16 (https://github.com/publiclab/mapknitter/pull/1694) but it could be more complicated.