publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
267 stars 207 forks source link

reduced direct links to spin.min.js in favor of sprockets spin.ts in application.js #1700

Closed jywarren closed 2 years ago

jywarren commented 2 years ago

Should get tests running again esp in #1567

Gets error: Sprockets::FileNotFound: couldn't find file 'spin.js/spin.ts' with type 'application/javascript'

Can also try:

https://spin.js.org/spin.umd.js

And maybe figure out how to compile typescript? Worth it?

gitpod-io[bot] commented 2 years ago

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 100c20be and detected 0 issues on this pull request.

View more on Code Climate.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1700 (100c20b) into main (d501aa4) will decrease coverage by 0.21%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1700      +/-   ##
==========================================
- Coverage   71.89%   71.68%   -0.22%     
==========================================
  Files          40       40              
  Lines        1409     1409              
==========================================
- Hits         1013     1010       -3     
- Misses        396      399       +3     
Impacted Files Coverage Δ
lib/not_at_origin_validator.rb 85.71% <100.00%> (ø)
lib/exporter.rb 91.92% <0.00%> (-2.25%) :arrow_down:
app/models/map.rb 93.54% <0.00%> (+1.29%) :arrow_up: