Closed jywarren closed 2 years ago
Code Climate has analyzed commit 100c20be and detected 0 issues on this pull request.
View more on Code Climate.
Merging #1700 (100c20b) into main (d501aa4) will decrease coverage by
0.21%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #1700 +/- ##
==========================================
- Coverage 71.89% 71.68% -0.22%
==========================================
Files 40 40
Lines 1409 1409
==========================================
- Hits 1013 1010 -3
- Misses 396 399 +3
Impacted Files | Coverage Δ | |
---|---|---|
lib/not_at_origin_validator.rb | 85.71% <100.00%> (ø) |
|
lib/exporter.rb | 91.92% <0.00%> (-2.25%) |
:arrow_down: |
app/models/map.rb | 93.54% <0.00%> (+1.29%) |
:arrow_up: |
Should get tests running again esp in #1567
Gets error:
Sprockets::FileNotFound: couldn't find file 'spin.js/spin.ts' with type 'application/javascript'
Can also try:
https://spin.js.org/spin.umd.js
And maybe figure out how to compile typescript? Worth it?