Closed PeculiarE closed 2 years ago
Code Climate has analyzed commit 79cecf7e and detected 0 issues on this pull request.
View more on Code Climate.
Merging #1738 (8341faa) into main (bb4dbb3) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #1738 +/- ##
=======================================
Coverage 63.47% 63.47%
=======================================
Files 39 39
Lines 1180 1180
=======================================
Hits 749 749
Misses 431 431
Hi @jywarren....I believe this should work for our purpose. Fingers crossed that it actually does 🤞
OK, maybe there was still an error? I see https://github.com/publiclab/mapknitter/pull/1740 which was created just after we merged this!
Error: TypeError: Cannot read property 'number' of undefined
Error: Cannot read property 'number' of undefined
Same error with "number" as i documented... i hope the action author writes back!!
it is working actually, see this PR #1741 opened roughly 10mins after the merge. The comment is made as desired.
I dunno if you saw my comment over at #1734, but I did mention that I decided to no longer use that author's bot. I went ahead to create our own specialized workflow to make the comment using the Github API and Github Actions. Full details here.
I believe the merge had not yet fully completed before #1740 was opened. Because I'm looking at the workflow/checks in its thread now and it's running the old workflow that uses that author's bot (Label Actions / Process Label Action) and that's why it threw the 'number' error.
The next PR opened at #1741 contains the new workflow I created: 'Dependabot PR Auto-Comment task' and this workflow does the job 😄
Oh fantastic!!! You must be right. Yes possibly the rebase was only up to a certain commit or something?
Great work, thanks @PeculiarE !!!
Follow up to #1734
rake test
@publiclab/mapknitter-reviewers
for help, in a comment below