publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
267 stars 208 forks source link

feat: 🎸 methods and db changes to publish single map and batch-publish multiple maps (no interface yet) #1772

Closed PeculiarE closed 2 years ago

PeculiarE commented 2 years ago

Fixes #1771

gitpod-io[bot] commented 2 years ago

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 0eec2793 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

View more on Code Climate.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1772 (7bfa104) into main (833eb37) will increase coverage by 0.70%. The diff coverage is 100.00%.

:exclamation: Current head 7bfa104 differs from pull request most recent head fd1bc22. Consider uploading reports for the commit fd1bc22 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1772      +/-   ##
==========================================
+ Coverage   64.72%   65.43%   +0.70%     
==========================================
  Files          40       40              
  Lines        1219     1244      +25     
==========================================
+ Hits          789      814      +25     
  Misses        430      430              
Impacted Files Coverage Ξ”
app/controllers/application_controller.rb 91.66% <100.00%> (ΓΈ)
app/controllers/spam_controller.rb 100.00% <100.00%> (ΓΈ)
app/models/map.rb 91.92% <100.00%> (+0.10%) :arrow_up:
app/models/user.rb 100.00% <100.00%> (ΓΈ)
TildaDares commented 2 years ago

@PeculiarE Seems like Rubocop has a few complaints about the comments. Not really important.

PeculiarE commented 2 years ago

@PeculiarE Seems like Rubocop has a few complaints about the comments. Not really important.

Yeah. I've fixed it though in the latest commit I just pushed.

PeculiarE commented 2 years ago

Just a thought on method naming. If you prefer to just leave as-is, let me know! Otherwise are we ready to merge? Thank you!!!

I've renamed the methods, and I believe we're ready to merge πŸ˜„...Thank you!

jywarren commented 2 years ago

Looks super, thank you!!!