search

publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
267 stars 207 forks source link

building in stable - notes #1790

Closed jywarren closed 2 years ago

jywarren commented 2 years ago

Originally we thought it was bundler --

hmm. updating bundler version didn't seem to work:

https://github.com/publiclab/mapknitter/commit/be85ba092ec3b309b92c834bba830ad62f11b8ba -

Logs (source ../environment.sh && docker-compose logs web 

web_1  | error mapknitter@1.0.0: The engine "node" is incompatible with this module. Expected version ">=16.0.0". Got "12.22.5"
warren@tycho:/srv/mapknitter_stable/mapknitter$ source ../[environment.sh](http://environment.sh/) && docker-compose exec web node --version
v12.22.5

Odd bc in https://github.com/publiclab/mapknitter/pull/1694 we upgraded to node 16...

jywarren commented 2 years ago

OK, so I suspect node 16 is not getting built in stable; i tried:

warren@tycho:/srv/mapknitter_stable/mapknitter$ docker-compose exec web curl -sL https://deb.nodesource.com/setup_16.x | bash - && apt-get install -y npm
bash: line 2: $'\r': command not found
bash: line 21: $'\r': command not found
bash: line 22: $'\r': command not found
bash: line 28: $'\r': command not found
bash: line 29: syntax error near unexpected token `$'{\r'''
bash: line 29: `print_status() {
 warren@tycho:/srv/mapknitter_stable/mapknitter$
jywarren commented 2 years ago

Ah! Actually it built! https://ci-j.publiclab.org/job/Mapknitter-Stable/lastSuccessfulBuild/

OK, so closing this.

jywarren commented 2 years ago

This same error happened in production on publication and yarn install failed!

jywarren commented 2 years ago

Maybe its the node v12 issue -- We had seen error mapknitter@1.0.0: The engine "node" is incompatible with this module. Expected version ">=16.0.0". Got "12.22.12" in production, btw!

https://github.com/publiclab/mapknitter/blob/d5c11f1aa785c299447e2f6555e712e791a7bc5a/Dockerfile#L21

It had been in the Jenkins log: https://ci-j.publiclab.org/job/Mapknitter-Stable/lastSuccessfulBuild/console :-/ so that was a distraction maybe. Let's look for another error...

jywarren commented 2 years ago

This was resolved! https://github.com/publiclab/mapknitter/commit/306837a97ff6e89677d34f000f376bcd4f6dfd5b and https://github.com/publiclab/mapknitter/commit/357b272f3a70f6b475f73bc786f78e1f0a1af7b1