Closed PeculiarE closed 2 years ago
Code Climate has analyzed commit 2c14c40e and detected 11 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Complexity | 1 |
Duplication | 10 |
View more on Code Climate.
Merging #1798 (0b7d9ab) into main (42ee217) will increase coverage by
0.93%
. The diff coverage is94.80%
.:exclamation: Current head 0b7d9ab differs from pull request most recent head 2b46d8c. Consider uploading reports for the commit 2b46d8c to get more accurate results
@@ Coverage Diff @@
## main #1798 +/- ##
==========================================
+ Coverage 66.11% 67.04% +0.93%
==========================================
Files 40 40
Lines 1269 1305 +36
==========================================
+ Hits 839 875 +36
Misses 430 430
Impacted Files | Coverage Ξ | |
---|---|---|
app/helpers/application_helper.rb | 50.00% <66.66%> (ΓΈ) |
|
app/controllers/maps_controller.rb | 87.28% <90.00%> (+0.21%) |
:arrow_up: |
app/models/map.rb | 91.87% <90.00%> (ΓΈ) |
|
app/controllers/application_controller.rb | 93.18% <90.90%> (+1.51%) |
:arrow_up: |
app/controllers/feeds_controller.rb | 100.00% <100.00%> (ΓΈ) |
|
app/controllers/front_ui_controller.rb | 74.28% <100.00%> (ΓΈ) |
|
app/controllers/spam_controller.rb | 100.00% <100.00%> (ΓΈ) |
|
app/controllers/tags_controller.rb | 89.65% <100.00%> (ΓΈ) |
|
app/controllers/users_controller.rb | 95.65% <100.00%> (+1.53%) |
:arrow_up: |
app/models/tag.rb | 100.00% <100.00%> (ΓΈ) |
|
... and 1 more |
This is looking good @PeculiarE, good job π π . Maybe you could do some refactoring on a follow up Pr for some of the things code climate is highlighting? These could also be good ftos am happy to help on those. Really love the tests! thanks
Thank you @cesswairimu! And yes, I do have 'code refactoring' noted down in my personal list of future project improvements π . I'd really appreciate it if you could help out. Thank you β€οΈ
This looks great, i just made one request on named attributes in a test method. Then we can merge this!
Woohoo! Great work.
Fixes #1797
rake test
@publiclab/mapknitter-reviewers
for help, in a comment below