publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
267 stars 208 forks source link

Added first-timers-only issue template #1808

Closed mundume closed 2 years ago

mundume commented 2 years ago

Fixes #1775 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

welcome[bot] commented 2 years ago

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! πŸ‘πŸŽ‰πŸ˜„
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! πŸ™Œ
Then, you can say hello in our chatroom & share a link to this PR to get a review! πŸ‘‹ βœ…

gitpod-io[bot] commented 2 years ago

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 2184e796 and detected 0 issues on this pull request.

View more on Code Climate.

PeculiarE commented 2 years ago

Thank you for working on this ❀️ @nzaih1999...It is looking good.

Could you please remove the "+" in front of each line. The '+' sign is simply a guide added in the issue (https://github.com/publiclab/mapknitter/issues/1775) to show you the lines you're expected to add.

Once you do that, the PR can be merged. Thank you!

PeculiarE commented 2 years ago

Hi @nzaih1999....I can still see the '+' sign on each line of the file.

See below a sample screenshot of what is expected. Notice how there's no '+' sign:

Screenshot 2022-08-05 at 13 34 59

Kindly edit the file, remove the + signs on each line, and commit your changes.

mundume commented 2 years ago

check it out now

codecov[bot] commented 2 years ago

Codecov Report

Merging #1808 (e4669e0) into main (7ffc9ac) will increase coverage by 0.22%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1808      +/-   ##
==========================================
+ Coverage   67.04%   67.27%   +0.22%     
==========================================
  Files          40       40              
  Lines        1305     1314       +9     
==========================================
+ Hits          875      884       +9     
  Misses        430      430              
Impacted Files Coverage Ξ”
app/controllers/spam_controller.rb 100.00% <0.00%> (ΓΈ)
app/controllers/application_controller.rb 93.61% <0.00%> (+0.43%) :arrow_up:
PeculiarE commented 2 years ago

Nice job πŸ‘ @nzaih1999

I suggested a couple of changes due to spacing and typo issues. Once you apply/accept them, we are good to go πŸš€

PeculiarE commented 2 years ago

Hi @TildaDares, @jywarren, @cesswairimu....could you please do a final review and help us merge this PR? Thank you!

mundume commented 2 years ago

okay ill work on that

mundume commented 2 years ago

hello @TildaDares Ive fixed the hyphen

PeculiarE commented 2 years ago

Hi @nzaih1999...you renamed it properly and then you reversed it back to the wrong naming. Please let us know if you're having any issue with renaming the file. Thank you!

mundume commented 2 years ago

Hello @PeculiarE I'll check it out and get back to you

mundume commented 2 years ago

hello @PeculiarE ive fixed the issue

cesswairimu commented 2 years ago

Merging this :tada: thanks @nzaih1999 for this and thanks @TildaDares and @PeculiarE for the reviews :tada: :tada:

welcome[bot] commented 2 years ago

Congrats on merging your first pull request! πŸ™ŒπŸŽ‰βš‘οΈ Your code will likely be published to https://mapknitter.org in the next few days. Now that you've completed this, you can help someone else take their first step! Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. πŸ™Œ

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! πŸ˜•

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! πŸ˜„ πŸŽ‰

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors :inbox_tray: