search

publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
267 stars 211 forks source link

Bump rubocop-rails from 2.15.2 to 2.17.2 #1854

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps rubocop-rails from 2.15.2 to 2.17.2.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.17.2

Bug fixes

  • #825: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using condition before redirect_to. (@​koic)
  • #833: Fix a false positive for Rails/Pluck when receiver is not block argument for []. (@​koic)
  • #834: Fix an error for Rails/WhereNotWithMultipleConditions when using where.not with empty hash literal. (@​koic)
  • #833: Fix a false positive for Rails/Pluck when using multiple block arguments. (@​koic)

Changes

  • #832: Mark Rails/ActionControllerFlashBeforeRender, Rails/ActionControllerTestCase, and Rails/RootPathnameMethods cops as unsafe autocorrection. (@​koic)

RuboCop Rails 2.17.1

Bug fixes

  • #829: Revert "Extends Rails/HttpStatus cop to check routes.rb" introduced in 2.17.0. (@​jdufresne)
  • #831: Fix a false positive for Rails/Pluck when using block argument in []. (@​koic)

RuboCop Rails 2.17.0

New features

Bug fixes

  • #786: Fix a false negative for Rails/ActionControllerTestCase when extending ActionController::TestCase and having a method definition. (@​koic)
  • #792: Fix a false negative for Rails/RedundantPresenceValidationOnBelongsTo when belongs_to at least one block and one hash like belongs_to :company, -> { where(foo: true) }, inverse_of: :employee. ([@​PedroAugustoRamalhoDuarte][])
  • #781: Make Rails/DynamicFindBy aware of find_by_token_for. (@​koic)
  • #809: Fix an error for Rails/FreezeTime when using travel_to without argument. (@​koic)
  • #794: Fix an error for Rails/RedundantReceiverInWithOptions when calling a method with a receiver in with_options without block arguments. (@​koic)
  • #782: Fix an incorrect autocorrect for Rails/EagerEvaluationLogMessage when using Style/MethodCallWithArgsParentheses's autocorrection together. (@​koic)
  • #776: Fix an incorrect autocorrect for Rails/Presence when using arithmetic operation in else branch. (@​koic)
  • #813: Fix errors that occur when unrelated tag is investigated by Rails/ContentTag. ([@​r7kamura][])
  • #808: Fix false positive for Rails/ActionControllerFlashBeforeRender when render call precedes flash call. ([@​americodls][])
  • #778: Fix a false positive for Rails/DynamicFindBy when using page.find_by_id as a Capybara testing API. (@​koic)
  • #816: Fix an incorrect autocorrect for Rails/Presence when a right-hand side of the relational operator. ([@​ydah][])

Changes

  • #779: Add mail to AllowedMethods of Style/SymbolProc. (@​koic)
  • #796: Add several directories to Exclude to prevent slow investigation. (@​koic)
  • #822: Extends Rails/HttpStatus cop to check routes.rb. ([@​anthony-robin][])

... (truncated)

Changelog

Sourced from rubocop-rails's changelog.

2.17.2 (2022-10-27)

Bug fixes

  • #825: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using condition before redirect_to. ([@​koic][])
  • #833: Fix a false positive for Rails/Pluck when receiver is not block argument for []. ([@​koic][])
  • #834: Fix an error for Rails/WhereNotWithMultipleConditions when using where.not with empty hash literal. ([@​koic][])
  • #833: Fix a false positive for Rails/Pluck when using multiple block arguments. ([@​koic][])

Changes

  • #832: Mark Rails/ActionControllerFlashBeforeRender, Rails/ActionControllerTestCase, and Rails/RootPathnameMethods cops as unsafe autocorrection. ([@​koic][])

2.17.1 (2022-10-25)

Bug fixes

  • #829: Revert "Extends Rails/HttpStatus cop to check routes.rb" introduced in 2.17.0. ([@​jdufresne][])
  • #831: Fix a false positive for Rails/Pluck when using block argument in []. ([@​koic][])

2.17.0 (2022-10-22)

New features

Bug fixes

  • #786: Fix a false negative for Rails/ActionControllerTestCase when extending ActionController::TestCase and having a method definition. ([@​koic][])
  • #792: Fix a false negative for Rails/RedundantPresenceValidationOnBelongsTo when belongs_to at least one block and one hash like belongs_to :company, -> { where(foo: true) }, inverse_of: :employee. ([@​PedroAugustoRamalhoDuarte][])
  • #781: Make Rails/DynamicFindBy aware of find_by_token_for. ([@​koic][])
  • #809: Fix an error for Rails/FreezeTime when using travel_to without argument. ([@​koic][])
  • #794: Fix an error for Rails/RedundantReceiverInWithOptions when calling a method with a receiver in with_options without block arguments. ([@​koic][])
  • #782: Fix an incorrect autocorrect for Rails/EagerEvaluationLogMessage when using Style/MethodCallWithArgsParentheses's autocorrection together. ([@​koic][])
  • #776: Fix an incorrect autocorrect for Rails/Presence when using arithmetic operation in else branch. ([@​koic][])
  • #813: Fix errors that occur when unrelated tag is investigated by Rails/ContentTag. ([@​r7kamura][])
  • #808: Fix false positive for Rails/ActionControllerFlashBeforeRender when render call precedes flash call. ([@​americodls][])
  • #778: Fix a false positive for Rails/DynamicFindBy when using page.find_by_id as a Capybara testing API. ([@​koic][])
  • #816: Fix an incorrect autocorrect for Rails/Presence when a right-hand side of the relational operator. ([@​ydah][])

Changes

  • #779: Add mail to AllowedMethods of Style/SymbolProc. ([@​koic][])
  • #796: Add several directories to Exclude to prevent slow investigation. ([@​koic][])
  • #822: Extends Rails/HttpStatus cop to check routes.rb. ([@​anthony-robin][])
  • #787: Make Rails/Pluck aware of all keys. ([@​koic][])
  • #800: Make Rails/TimeZone aware of timezone UTF offset. ([@​inkstak][])

... (truncated)

Commits
  • 43277d7 Cut 2.17.2
  • 964268c Update Changelog
  • 036d6ef Merge pull request #840 from koic/fix_a_false_positive_for_rails_action_contr...
  • a7ef129 [Fix #825] Fix a false positive for Rails/ActionControllerFlashBeforeRender
  • fbc59de [Fix #833] Fix a false positive for Rails/Pluck
  • 85d615f [Fix #833] Fix a false positive for Rails/Pluck
  • 8663b04 [Fix #834] Fix an error for Rails/WhereNotWithMultipleConditions
  • 4058ce5 Add a changelog entry
  • 487463c [Fix #832] Mark some Rails cops as unsafe autocorrection
  • 41a5571 Switch back docs version to master
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
gitpod-io[bot] commented 1 year ago

github-actions[bot] commented 1 year ago

This is an automated pull request by @dependabot, a service we use to keep libraries up to date in our projects. Read this post to learn how to help us understand if it's ready to be merged (there are lots of considerations to balance!): https://bit.ly/3GphOhV

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 2b2b89b5 and detected 0 issues on this pull request.

View more on Code Climate.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1854 (2b2b89b) into main (3a1e332) will decrease coverage by 34.33%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/publiclab/mapknitter/pull/1854/graphs/tree.svg?width=650&height=150&src=pr&token=zM6xiNbe94&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab)](https://codecov.io/gh/publiclab/mapknitter/pull/1854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) ```diff @@ Coverage Diff @@ ## main #1854 +/- ## =========================================== - Coverage 67.44% 33.10% -34.34% =========================================== Files 40 40 Lines 1321 1486 +165 =========================================== - Hits 891 492 -399 - Misses 430 994 +564 ``` | [Impacted Files](https://codecov.io/gh/publiclab/mapknitter/pull/1854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) | Coverage Δ | | |---|---|---| | [app/mailers/comment\_mailer.rb](https://codecov.io/gh/publiclab/mapknitter/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL21haWxlcnMvY29tbWVudF9tYWlsZXIucmI=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [app/mailers/application\_mailer.rb](https://codecov.io/gh/publiclab/mapknitter/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL21haWxlcnMvYXBwbGljYXRpb25fbWFpbGVyLnJi) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [app/controllers/feeds\_controller.rb](https://codecov.io/gh/publiclab/mapknitter/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL2ZlZWRzX2NvbnRyb2xsZXIucmI=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [app/controllers/comments\_controller.rb](https://codecov.io/gh/publiclab/mapknitter/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL2NvbW1lbnRzX2NvbnRyb2xsZXIucmI=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [app/controllers/tags\_controller.rb](https://codecov.io/gh/publiclab/mapknitter/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL3RhZ3NfY29udHJvbGxlci5yYg==) | `0.00% <0.00%> (-89.66%)` | :arrow_down: | | [app/controllers/spam\_controller.rb](https://codecov.io/gh/publiclab/mapknitter/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL3NwYW1fY29udHJvbGxlci5yYg==) | `18.86% <0.00%> (-81.14%)` | :arrow_down: | | [app/controllers/images\_controller.rb](https://codecov.io/gh/publiclab/mapknitter/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL2ltYWdlc19jb250cm9sbGVyLnJi) | `0.00% <0.00%> (-76.55%)` | :arrow_down: | | [app/controllers/annotations\_controller.rb](https://codecov.io/gh/publiclab/mapknitter/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL2Fubm90YXRpb25zX2NvbnRyb2xsZXIucmI=) | `0.00% <0.00%> (-59.26%)` | :arrow_down: | | [app/controllers/export\_controller.rb](https://codecov.io/gh/publiclab/mapknitter/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL2V4cG9ydF9jb250cm9sbGVyLnJi) | `0.00% <0.00%> (-47.28%)` | :arrow_down: | | [app/controllers/maps\_controller.rb](https://codecov.io/gh/publiclab/mapknitter/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL21hcHNfY29udHJvbGxlci5yYg==) | `49.15% <0.00%> (-38.14%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/publiclab/mapknitter/pull/1854/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) | |
dependabot[bot] commented 1 year ago

Superseded by #1859.