search

publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
267 stars 208 forks source link

Bump rubocop-rails from 2.15.2 to 2.17.4 #1874

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps rubocop-rails from 2.15.2 to 2.17.4.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.17.4

Bug fixes

  • #870: Fix an error for Rails/RootPathnameMethods when using Rails.env argument within Dir.glob. (@​koic)
  • #881: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline rescue branch before redirect_to. (@​gurix)
  • #871: Fix a false positive for Rails/WhereMissing when left_joins(:foo) and where(foos: {id: nil}) separated by or, and. (@​ydah)
  • #875: Make Rails/RootPathnameMethods aware of enforced style of Style/StringLiterals. (@​koic)
  • #882: Fix false positive for Rails/UniqueValidationWithoutIndex with :conditions option. (@​etiennebarrie)
  • #821: Enhance Rails/TimeZone to accept methods with the :in timezone option. (@​fatkodima)

Changes

RuboCop Rails 2.17.3

% cat relnotes/v2.17.3.md

Bug fixes

  • #843: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline if branch before redirect_to. (@​koic)
  • #841: Fix an error for Rails/ActionOrder when using unconventional order of multiple actions. (@​koic)
  • #838: Fix an incorrect autocorrect for Rails/ActionOrder when using unconventional order of actions in conditions. (@​koic)
  • #867: Fix autocorrection bug when ::Hash is used on Rails/IndexBy and Rails/IndexWith. (@​r7kamura)
  • #848: Fix a false positive for Rails/FreezeTime when using travel_to with an argument of Time.new(...).in_time_zone. (@​koic)
  • #869: Fix false-positives that non Rails formats are offended on Rails/ToSWithArgument. (@​r7kamura)
  • #866: Fix false-positives when constant is used with receiver on Rails/DurationArithmetic, Rails/IndexBy, Rails/IndexWIth, and Rails/RequireDependency. (@​r7kamura)
  • #850: Fix default configuration for Rails/I18nLazyLookup. (@​vlad-pisanov)
  • #837: Fix incorrect autocorrection of Rails/ActionOrder about comments. (@​r7kamura)
  • #855: Fix Rails/RootPathnameMethods autocorrection for Pathname calls without parens. (@​gsamokovarov)
  • #868: Support :: prefixed constants on Rails/ActionControllerFlashBeforeRender, Rails/ActionControllerTestCase, Rails/ApplicationController, Rails/ApplicationJob, Rails/ApplicationMailer, Rails/ApplicationRecord, Rails/DotSeparatedKeys, Rails/DynamicFindBy, Rails/FindEach, Rails/FreezeTime, Rails/HasManyOrHasOneDependent, Rails/HelperInstanceVariable, Rails/MailerName, Rails/MigrationClassName, Rails/Output, Rails/ReversibleMigrationMethodDefinition, Rails/ReversibleMigration, Rails/ShortI18n, Rails/SkipsModelValidations, and Rails/TimeZoneAssignment. (@​r7kamura)
  • #865: Support ::Rails and ::File on Rails/FilePath cop. (@​r7kamura)

Changes

  • #862: Ignore if number of arguments does not match on Rails/DynamicFindBy. (@​r7kamura)

RuboCop Rails 2.17.2

Bug fixes

... (truncated)

Changelog

Sourced from rubocop-rails's changelog.

2.17.4 (2022-12-25)

Bug fixes

  • #870: Fix an error for Rails/RootPathnameMethods when using Rails.env argument within Dir.glob. ([@​koic][])
  • #881: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline rescue branch before redirect_to. ([@​gurix][])
  • #871: Fix a false positive for Rails/WhereMissing when left_joins(:foo) and where(foos: {id: nil}) separated by or, and. ([@​ydah][])
  • #875: Make Rails/RootPathnameMethods aware of enforced style of Style/StringLiterals. ([@​koic][])
  • #882: Fix false positive for Rails/UniqueValidationWithoutIndex with :conditions option. ([@​etiennebarrie][])
  • #821: Enhance Rails/TimeZone to accept methods with the :in timezone option. ([@​fatkodima][])

Changes

2.17.3 (2022-11-20)

Bug fixes

  • #843: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline if branch before redirect_to. ([@​koic][])
  • #841: Fix an error for Rails/ActionOrder when using unconventional order of multiple actions. ([@​koic][])
  • #838: Fix an incorrect autocorrect for Rails/ActionOrder when using unconventional order of actions in conditions. ([@​koic][])
  • #867: Fix autocorrection bug when ::Hash is used on Rails/IndexBy and Rails/IndexWith. ([@​r7kamura][])
  • #848: Fix a false positive for Rails/FreezeTime when using travel_to with an argument of Time.new(...).in_time_zone. ([@​koic][])
  • #869: Fix false-positives that non Rails formats are offended on Rails/ToSWithArgument. ([@​r7kamura][])
  • #866: Fix false-positives when constant is used with receiver on Rails/DurationArithmetic, Rails/IndexBy, Rails/IndexWIth, and Rails/RequireDependency. ([@​r7kamura][])
  • #850: Fix default configuration for Rails/I18nLazyLookup. ([@​vlad-pisanov][])
  • #837: Fix incorrect autocorrection of Rails/ActionOrder about comments. ([@​r7kamura][])
  • #855: Fix Rails/RootPathnameMethods autocorrection for Pathname calls without parens. ([@​gsamokovarov][])
  • #868: Support :: prefixed constants on Rails/ActionControllerFlashBeforeRender, Rails/ActionControllerTestCase, Rails/ApplicationController, Rails/ApplicationJob, Rails/ApplicationMailer, Rails/ApplicationRecord, Rails/DotSeparatedKeys, Rails/DynamicFindBy, Rails/FindEach, Rails/FreezeTime, Rails/HasManyOrHasOneDependent, Rails/HelperInstanceVariable, Rails/MailerName, Rails/MigrationClassName, Rails/Output, Rails/ReversibleMigrationMethodDefinition, Rails/ReversibleMigration, Rails/ShortI18n, Rails/SkipsModelValidations, and Rails/TimeZoneAssignment. ([@​r7kamura][])
  • #865: Support ::Rails and ::File on Rails/FilePath cop. ([@​r7kamura][])

Changes

  • #862: Ignore if number of arguments does not match on Rails/DynamicFindBy. ([@​r7kamura][])

2.17.2 (2022-10-27)

Bug fixes

  • #825: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using condition before redirect_to. ([@​koic][])
  • #833: Fix a false positive for Rails/Pluck when receiver is not block argument for []. ([@​koic][])
  • #834: Fix an error for Rails/WhereNotWithMultipleConditions when using where.not with empty hash literal. ([@​koic][])
  • #833: Fix a false positive for Rails/Pluck when using multiple block arguments. ([@​koic][])

Changes

  • #832: Mark Rails/ActionControllerFlashBeforeRender, Rails/ActionControllerTestCase, and Rails/RootPathnameMethods cops as unsafe autocorrection. ([@​koic][])

2.17.1 (2022-10-25)

... (truncated)

Commits
  • 836ff28 Cut 2.17.4
  • 3032b74 Update Changelog
  • b930670 Correctly detect Rails version when using only parts of the framework
  • b9f852b Use RuboCop RSpec 2.16
  • f8153ca Merge pull request #881 from gurix/fix/false_positive_for_rails_action_contro...
  • cb2de46 fixed false positive ActionControllerFlashBefore after rescue
  • f94b235 Merge pull request #871 from ydah/fix/where_missing
  • c23478a Merge pull request #882 from etiennebarrie/uniqueness-with-conditions
  • 61d3f6c Support conditions option of UniquenessValidator
  • c7e7de3 Support conditions specific to the validator
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
github-actions[bot] commented 1 year ago

This is an automated pull request by @dependabot, a service we use to keep libraries up to date in our projects. Read this post to learn how to help us understand if it's ready to be merged (there are lots of considerations to balance!): https://bit.ly/3GphOhV

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 8a96b9e8 and detected 0 issues on this pull request.

View more on Code Climate.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1874 (8a96b9e) into main (3a1e332) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/publiclab/mapknitter/pull/1874/graphs/tree.svg?width=650&height=150&src=pr&token=zM6xiNbe94&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab)](https://codecov.io/gh/publiclab/mapknitter/pull/1874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) ```diff @@ Coverage Diff @@ ## main #1874 +/- ## ======================================= Coverage 67.44% 67.44% ======================================= Files 40 40 Lines 1321 1321 ======================================= Hits 891 891 Misses 430 430 ```
dependabot[bot] commented 1 year ago

Superseded by #1884.