Add "Ask a Question" button to front of Mapknitter.org

ebarry commented 7 years ago

Hi, this is a Public Lab first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

Just a heads-up, this repo does not have a smooth install process or documentation the way our others Public Lab repos do. But, because the requested change is so small, and mostly HTML, it should be OK; getting the app running is not a requirement.

If this works for you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The problem

https://mapknitter.org/ doesn't have a button to connect people to where they can ask questions and get help.

The Solution

Thanks to 2016's Google Summer of Code, publiclab.org now has a a "stack overflow" like community question and answer area: https://publiclab.org/questions

screen shot 2016-12-12 at 10 59 44 am

Let's add a button to the front of http://mapknitter.org/ labelled Ask a question , and put it right next to the existing buttons:

screen shot 2016-12-12 at 4 22 58 pm

For reference, although it's not the same to put a button in a wiki page as in the code of infragram.org, see the button on https://publiclab.org/wiki/spectrometry

<a class="btn btn-primary" href="/post?tags=spectrometry,question:spectrometry&template=question">Ask a question about spectrometry</a>
That link goes to this URL: https://publiclab.org/questions/new?tags=spectrometry,question:spectrometry&template=question

The tags for the mapknitter button should be tags=mapknitter,aerial-imaging,aerial-photography,question:mapknitter,question:aerial-imaging,question:aerial-photography&template=question

Here's where the code should go: https://github.com/publiclab/mapknitter/blob/master/app/views/maps/index.html.erb#L51

While folks are at it, adding a margin-left:5px; to the existing button would help with style.

Steps to Fix

[ ] claim this issue with a comment here, below, and ask any clarifying questions you need
[ ] set up a repository locally following the README instructions, and make sure that all tests pass
[ ] try to fix the issue following the steps above, but even before you're done, you can:
[ ] commit your changes and start a pull request (see contributing to Public Lab software) but mark it as "in progress" if you have questions or if you haven't finished
[ ] alert someone via the developers list (see below) to have your pull request merged. This may take a few extra steps depending on when you do it, but we'll help you out!

Please email the developers list (see https://publiclab.org/developers) if you have questions, and take a look at Public Lab's first-timers landing page for more information!

jywarren commented 7 years ago

We'd love your help on this and are happy to offer any assistance you might need. Thanks a lot!

Just curious -- we're trying to improve our outreach to new contributors -- how did you happen to hear about us?

edsonmendieta commented 7 years ago

I don't see anyone else, so I'll go ahead and claim this one :) Actually deleted my first post, sorry about that.

I typed in "label:first-timers-only is:open" in the search. A tip I got from http://yourfirstpr.github.io/.

This'll be the first time I'll be contributing to open source. I'll do my best!

jywarren commented 7 years ago

Super - sorry, i guess i saw your comment via email but it's gone already? Anyways -- although installing is not too hard, this change is small enough that you might not even need to get it running before making the fix!

Thanks!

edsonmendieta commented 7 years ago

<a class="btn btn-primary" href="/post?tags=mapknitter,aerial-imaging,aerial-photography,question:mapknitter,question:aerial-imaging,question:aerial-photography&template=question">Ask a question</a>

Is this what is expected as far as the html of the button goes?

jywarren commented 7 years ago

yes! perfect 🎉

edsonmendieta commented 7 years ago

I've gone ahead and forked mapknitter. From what you said, I'm thinking I can just edit the appropriate html.erb file, commit it, and then start the pull request process?

Also, it also says something up top about adding a margin-left:5px; to "existing button". Is that in reference to the "Watch Tutorial Video" button or this new button?

Thanks for your help!

jywarren commented 7 years ago

That's perfect and you can disregard the margin comment, I think that was incorrectly copied from another issue. Thanks! I'm headed out now but will keep an eye out.

On Dec 12, 2016 6:26 PM, "Edson Mendieta" notifications@github.com wrote:

I've gone ahead and forked mapknitter. From what you said, I'm thinking I can just edit the appropriate html.erb file, commit it, and then start the pull request process?

Also, it also says something up top about adding a margin-left:5px; to "existing button". Is that in reference to the "Watch Tutorial Video" button or this new button?

Thanks for your help!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/227#issuecomment-266586776, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ4GFihdIDQrwgG3hUk75e1vwZ49Lks5rHdg3gaJpZM4LLDQd .

edsonmendieta commented 7 years ago

I've gone ahead and submitted a pull request.

Let me know if there's any issues with it, thanks!

jywarren commented 7 years ago

Merged and completed in #228 -- perfect, thank you!

jywarren commented 7 years ago

Also - in case you're interested, there's a very similar issue over here: https://github.com/p-v-o-s/infragram-js/issues/82

We'd be glad to have your help with that one too, if you're interested!

ebarry commented 7 years ago

Thank you!!! Looks great on mapknitter.org!

--

+1 336-269-1539 @lizbarry http://twitter.com/lizbarry

On Tue, Dec 13, 2016 at 9:03 AM, Jeffrey Warren notifications@github.com wrote:

Also - in case you're interested, there's a very similar issue over here: p-v-o-s/infragram-js#82 https://github.com/p-v-o-s/infragram-js/issues/82

We'd be glad to have your help with that one too, if you're interested!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/227#issuecomment-266745881, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ2n2K1AJ0BLgD0vxh9QVbN_FlEOxvVks5rHqWVgaJpZM4LLDQd .

publiclab / mapknitter