search

publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
266 stars 211 forks source link

Planning Issue: Upgrade rails from 3.2 to rails 6 #305

Open SidharthBansal opened 5 years ago

SidharthBansal commented 5 years ago
Dhiraj240 commented 5 years ago

@SidharthBansal @jywarren @gauravano I would like to work on the this from now onwards so that i get familiar with the end parts of the project before GSOC. So should i start with breaking up the issues and submitting PR ?

SidharthBansal commented 5 years ago

You can try some small issues of mapknitter to become familiar with this repo. Then you can start breaking this and open up a pr for this issue.

jywarren commented 5 years ago

this will be a big project! Noting that #304 -- expanded test coverage -- will be VERY helpful before taking on the upgrades, so we can be sure to know what is broken with each change.

SidharthBansal commented 5 years ago

@Dhiraj240 you can start working on #304 then

Dhiraj240 commented 5 years ago

@SidharthBansal @jywarren alright !!

kaustubh-nair commented 5 years ago

I'm interested in this project too! I'd love to help you guys out in improving test coverage :smiley: If there's an issue I can fix please let me know!

Dhiraj240 commented 5 years ago

@kaunair You can see the available issues in the repository although one of them is highlighted in the above chat.But were you able to install it ?

grvsachdeva commented 5 years ago

We would also love to have your help @kaunair. But, how about doing the testing part after switch to yarn part, you have claimed? You can start both too, we don't mind that too :smile: . Thank you!

jywarren commented 5 years ago

https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-3-2-to-rails-4-0 is GREAT and @Souravirus used this in the plots2 upgrade process:

OK this is intimidating, but we can all pitch in here and do it step by step. It's also important to remember that MapKnitter is a MUCH easier and simpler application.

That page also lists upgrade paths for many other, all the way to 6. If I recall, 3.2>4.1 was the hardest, and then it got easier.

kaustubh-nair commented 5 years ago

Hey @jywarren those links look really useful! I understand that having decent test coverage is going to be really important for upgrading to rails 5 Since you've already added some tests, could you give a few pointers to what are the next important features that need to be covered by tests? I think I'll dabble a bit on tests once I finish my current pr! Thanks!

jywarren commented 5 years ago

that's a great next step, thank you! We're aiming for all model methods to be tested (in unit tests) and all controller methods (in functional tests). So, really i think you could start trying to identify controllers which have a lot of untested code! If we can get Coveralls configured, it will also help us grow test coverage. Thanks!

On Tue, Feb 26, 2019 at 3:42 PM Kaustubh Nair notifications@github.com wrote:

Hey @jywarren https://github.com/jywarren those links look really useful! I understand that having decent test coverage is going to be really important for upgrading to rails 5 Since you've already added some tests, could you give a few pointers to what are the next important features that need to be covered by tests? I think I'll dabble a bit on tests once I finish my current pr! Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/305#issuecomment-467605151, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ9y7LRZAsb0NoyQHAXlvHuXbHmq7ks5vRZwOgaJpZM4aUBGf .

SidharthBansal commented 5 years ago

Hi, new version of Rails is 6. So it will be great if we can increment it at MK till the latest version instead of Rails 5. @jywarren if you agree then please change the tiitle of the issue. Thanks

alaxalves commented 5 years ago

Hey @jywarren I'm a student from Brazil and I'd like to work with PublicLab team as a GSoC intern and work with MapKnitter rails 5 upgrade. I have already made some contribution to Mapknitter in #363 #450 #429 and #357. I'm very eager to work with this project in particular since I have previously worked with this type of framework upgrade in Noosfero - a huge open source project - in #1438.

alaxalves commented 5 years ago

This is an issue that's great for the break-me-up label xD

avsingh999 commented 5 years ago

Hi, new version of Rails is 6. So it will be great if we can increment it at MK till the latest version instead of Rails 5. @jywarren if you agree then please change the tiitle of the issue. Thanks

@jywarren @SidharthBansal Rails 6 is in Beta according to this link https://rubygems.org/gems/rails/versions so it would be good for changing rails 3.2 to rails 6.0 I am just confirming. thank you : )

jywarren commented 5 years ago

I suspect that by the time we get to 5.x, it might be out of beta... or close to it! One thing we can add is to resolve warnings and deprecations in preparation for 6 in advance. so, +1!

On Thu, Apr 4, 2019 at 7:10 AM Avkaran Singh notifications@github.com wrote:

Hi, new version of Rails is 6. So it will be great if we can increment it at MK till the latest version instead of Rails 5. @jywarren https://github.com/jywarren if you agree then please change the tiitle of the issue. Thanks

@jywarren https://github.com/jywarren @SidharthBansal https://github.com/SidharthBansal Rails 6 is in Beta according to this link https://rubygems.org/gems/rails/versions so it would be good for changing rails 3.2 to rails 6.0 I am just confirming. thank you : )

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/305#issuecomment-479853911, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ0etW5WO10rMVpHpwPMx9LCLo7unks5vdd17gaJpZM4aUBGf .

SidharthBansal commented 5 years ago

@alaxalves @kaustubh-nair @jywarren let's discuss the project in this planning issue. As per @jywarren 's suggestion, I will be mentoring this project (as much as I am capable of). This is my first time mentoring 4-5 big project. I hope everything goes well. :smile:

I have heavily edited the above issue body.

SidharthBansal commented 5 years ago

Please feel free to open independent issues for each of the sub-issues present in the above issue body @alaxalves @kaustubh-nair In the individual issues you can decide which of you will be willing to do. This will resolve the time difference ambiguity you are facing.

SidharthBansal commented 5 years ago

Let's create a project and a milestone friends for this issue. And I will be requiring your help folks and also don't forget to take help from the vast community. Ultimately goal of GSoC is not completing a project but its learning how to develop team spirit and friendly relations. Once you will be happy conversing with each other you all will feel you are not working, just you are discussing things online like on chat. So, it will be fun folks. Don't take stress. This summer will be going to be amazing.

SidharthBansal commented 5 years ago

@alaxalves will you take the initiative to do the following?

@kaustubh-nair I will like to ask you in case you are interested in doing the following. It will be great help to the Public Lab community

Once we are done with these steps, then you both can decide which one will be working on which subissue. Next step is to call a negotiator for conflict resolutions. Me, Jeff or Sourav can help you to decide at the issues for this. There will be some issues which will require both of you to work on simultaneously. While others may require only one participant involvement. Once we are decided with this.

divyabaid16 commented 5 years ago

Hey!!! Should I create a check list of the task that I had mentioned in my GSoC proposal in a seperate issue and you can guide me there?

SidharthBansal commented 5 years ago

Also folks, we can use tree-like structures here. There may be sub-issues which require further break up. Like link tests to these planning issues. In the tests subissue you can break it into sub sub issues unit tests, controller tests and so on. This help us to have modularity at different levels. We will be dividing requirements in top-down approach and we will be executing them in a bottom-up manner at individual sub-issues. As soon as we close the sub-issues and sub sub-issues please check them. Does this makes sense? Thanks

SidharthBansal commented 5 years ago

@divyabaid16 yeah sure. I will help you there for sure.

divyabaid16 commented 5 years ago

Okay I will open it soon. :)

SidharthBansal commented 5 years ago

@divyabaid16 https://github.com/publiclab/mapknitter/issues/593 please edit it. We can have further conversations there. Thanks

SidharthBansal commented 5 years ago

Just noticed the tree like structure can also be adopted using the cards of the project section. So, please use that too. It will help us.

alaxalves commented 5 years ago

@alaxalves will you take the initiative to do the following?

  • [x] Open up a milestone
  • [ ] Open Up a project
  • [ ] Open sub issues for all the above listed in the issue body
  • [ ] Edit the issue body with more information
  • [ ] Comment on the issues you wanna work on

@kaustubh-nair I will like to ask you in case you are interested in doing the following. It will be great help to the Public Lab community

  • [ ] Link all the issues made by @alaxalves to this main planning issue. Don't forget to link them in the planning issue body
  • [ ] Link all the issues in the milestone
  • [ ] Link all the issues in the project section
  • [ ] Edit the issue body to add the missing parts needed for the project.
  • [ ] Comment under the sub issues which you wanna work on.
  • [ ] label all the issues with proper labels like gsoc, rails, design etc whatsoever feels appropriate.

Once we are done with these steps, then you both can decide which one will be working on which subissue. Next step is to call a negotiator for conflict resolutions. Me, Jeff or Sourav can help you to decide at the issues for this. There will be some issues which will require both of you to work on simultaneously. While others may require only one participant involvement. Once we are decided with this.

  • [ ] Then @kaustubh-nair I will ask you to help us further by listing the issues in the order in which they need to get executed. We will requiring a lot of syncing friends. So, order matters a lot.
  • [ ] @alaxalves please then check the order, do movements in the planning issue if required. I hope these steps will help you folks. Looking forward to see the sub issues soon.

I started opening sub issues but I need more permissions to put labels in the issues, create projects and such.

SidharthBansal commented 5 years ago

@jywarren can you please help us with the permissions. I think someday you gave me permissions such that I can give permissions to other. But I forget how to upgrade permissions. Please assist us. Thanks

kaustubh-nair commented 5 years ago

Hey Sidharth, thanks for the detailed guide! I'm traveling back home today. I'll start working actively from tomorrow! Cheers

alaxalves commented 5 years ago

I have created the issues you've requested @SidharthBansal and self-assigned to the one I'd like to start working on, I have created the issues based on the following diagram took from my proposal and on what I have previously discussed with the PublicLab members. If there's any change or suggestion let me know :smile:

SidharthBansal commented 5 years ago

Thanks. I have read your proposal.

On Tue, May 14, 2019 at 7:25 PM Álax de Carvalho Alves < notifications@github.com> wrote:

I have created the issues you've requested @SidharthBansal https://github.com/SidharthBansal and self-assigned to the one I'd like to start working on, I have created the issues based on the following diagram took from my proposal https://docs.google.com/document/d/1dYoVMVyhbz4Y8daeCCINxY_NFpi-rcP7C7X1L7Or_Zs/edit?usp=sharing and on what I have previously discussed with the PublicLab members.

https://camo.githubusercontent.com/049cf30d57ce645964034754686ce79c0bf37348/68747470733a2f2f692e696d6775722e636f6d2f48614b6a4a6d312e706e67

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/305?email_source=notifications&email_token=AFAAEQ4OR46SSXD5W37PFN3PVLAG5A5CNFSM4GSQCGP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVLRX3Q#issuecomment-492248046, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAAEQ2NZ2TBG6MNR4X3XHLPVLAG5ANCNFSM4GSQCGPQ .

IgorWilbert commented 5 years ago

Hello! As I was talking to @alaxalves , I am very interested in helping out with this proposal! Here are some thoughts I had after reading @alaxalves proposal:

Looking forward to know your thoughts, thanks!