Remove legacy image controller code

first-timers[bot] commented 5 years ago

This issue is reserved for applicants to Public Lab’s Providence code fellowship. Please feel free to help applicants, but if you are looking for a first-timers-issue of your own and are not applying for the position, please see our coding Welcome Page at https://code.publiclab.org.

Applicants - upon completion (when your pull request is merged), please include the link to this issue in your application at https://publiclab.org/pvd.

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] 📝 Update the file app/controllers/images_controller.rb in the mapknitter repository (press the little pen Icon) and edit the line as shown below.

To get help installing the application on your computer, see the project README and get help at #307

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -9,22 +9,6 @@ class ImagesController < ApplicationController
   #Convert model to json without including root name. Eg. 'warpable'
   ActiveRecord::Base.include_root_in_json = false

-  # legacy
-  def new
-    @map = Map.find params[:id]
-    @warpable = Warpable.new
-    respond_to do |format|
-     format.html { render :template => 'legacy/new', :layout => false } 
-     format.json { render :json => @warpable }
-    end
-  end
-
-  # legacy
-  def uploaded_confirmation
-    @warpable = Warpable.find params[:id]
-    render :template => 'legacy/new', :layout => false
-  end
-
   # proxy, used if MapKnitter is being backed by Amazon S3 file storage, 
   # to enable client-side distortion using webgl-distort, which requires same-origin
   def fetch

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

milomacphail commented 5 years ago

Hi, I'd like to take care of this issue.

jywarren commented 5 years ago

That'd be great, thank you! We're here to help if you get stuck, do you have any questions?

On Tue, Mar 19, 2019, 8:48 PM Milo MacPhail notifications@github.com wrote:

Hi, I'd like to take care of this issue.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/404#issuecomment-474640245, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ7NLhGWdwAfkVp1wRXNuBgOHUamzks5vYYVagaJpZM4bwDcB .

milomacphail commented 5 years ago

Thanks! I think I feel pretty good so far. I'll let you know!

jywarren commented 5 years ago

Hello, sorry this took a while, but I've posted on BountySource the stipend that was offered on this issue: https://www.bountysource.com/issues/73848940-remove-legacy-image-controller-code

Please claim it by clicking that link. Thanks!

milomacphail commented 5 years ago

Hey Jeff!

Thanks. Can you mark it closed so I can receive the stipend?

I also ended up backing it trying to cash it out. Whoops!

Let me know if there are any issues!

Milo

On Thu, May 9, 2019, 4:13 PM Jeffrey Warren notifications@github.com wrote:

Hello, sorry this took a while, but I've posted on BountySource the stipend that was offered on this issue: https://www.bountysource.com/issues/73848940-remove-legacy-image-controller-code

Please claim it by clicking that link. Thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/404#issuecomment-491087008, or mute the thread https://github.com/notifications/unsubscribe-auth/AJYOSOC5KR3SRD4QGBOC7ILPUSOW5ANCNFSM4G6AG4AQ .

jywarren commented 5 years ago

Oh goodness. Well i guess you get it back. Yes, i will now.

milomacphail commented 5 years ago

Awesome, thanks!

Also, not to breach the bounds of professionalism but you're going to love working with Rose Parker; she's the best and is going to knock it out of the park.

Thanks for the opportunity and see you around, Milo

On Thu, May 9, 2019, 4:24 PM Jeffrey Warren notifications@github.com wrote:

Closed #404 https://github.com/publiclab/mapknitter/issues/404.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/404#event-2331624180, or mute the thread https://github.com/notifications/unsubscribe-auth/AJYOSOAYKQ7FWXTRGJR4HRLPUSQCXANCNFSM4G6AG4AQ .

milomacphail commented 5 years ago

Hey Jeff,

Just needs you to accept it for the disbursement to happen.

Thanks, Milo

On Thu, May 9, 2019, 4:28 PM Milo MacPhail milomacphail@gmail.com wrote:

Awesome, thanks!

Also, not to breach the bounds of professionalism but you're going to love working with Rose Parker; she's the best and is going to knock it out of the park.

Thanks for the opportunity and see you around, Milo

On Thu, May 9, 2019, 4:24 PM Jeffrey Warren notifications@github.com wrote:

Closed #404 https://github.com/publiclab/mapknitter/issues/404.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/404#event-2331624180, or mute the thread https://github.com/notifications/unsubscribe-auth/AJYOSOAYKQ7FWXTRGJR4HRLPUSQCXANCNFSM4G6AG4AQ .

jywarren commented 5 years ago

Awesome, thanks!

publiclab / mapknitter