publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
267 stars 210 forks source link

Download as geo.tiff bug #625

Open cesswairimu opened 5 years ago

cesswairimu commented 5 years ago

What happened just before the problem occurred

During the upgrade to rails 4.2, this test was failing for me https://github.com/publiclab/mapknitter/blob/main/test/unit/warpable_test.rb#L62. Thought it was something I broke and been trying to fix it until @alaxalves and @sashadev-sky informed me they were having the same prob with the test. Thanks guys :+1:

So I checked out main and tried to investigate more this is the error I got Screenshot from 2019-05-21 12-59-08

Relevant URL

https://github.com/publiclab/mapknitter/blob/main/app/controllers/export_controller.rb#L30-L32

Steps to replicate

jywarren commented 5 years ago

Ah hmm. Are we sure the geotiff is being generated, and is it possibly just in the wrong place or wrong filename? We should be able to look into public/warps/... to check and debug this, after running an export!

On Tue, May 21, 2019 at 6:02 AM Cess notifications@github.com wrote:

What happened just before the problem occurred

During the upgrade to rails 4.2, this test was failing for me https://github.com/publiclab/mapknitter/blob/main/test/unit/warpable_test.rb#L62. Thought it was something I broke and been trying to fix it until @alaxalves https://github.com/alaxalves and @sashadev-sky https://github.com/sashadev-sky informed me they were having the same prob with the test. Thanks guys 😃

So I checked out main and tried to investigate more this is the error I got [image: Screenshot from 2019-05-21 12-59-08] https://user-images.githubusercontent.com/17081074/58087043-71892600-7bc8-11e9-8824-6ae75cefc73c.png Relevant URL

https://github.com/publiclab/mapknitter/blob/main/app/controllers/export_controller.rb#L30-L32 Steps to replicate

  • On maps show page, click on the Export section. Hit the Start Export button. Make sure the export finishes.
  • On the same page click the download drop-down and select GeoTIFF

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/625?email_source=notifications&email_token=AAAF6J5V2SPZJEPM7NURI53PWPB7VA5CNFSM4HOJLTW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GU5PPEQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J7QJXTBKH4IOMWOX7LPWPB7VANCNFSM4HOJLTWQ .

cesswairimu commented 5 years ago

might be the geotiff its not being created. The folder public/warps/saugus-landfill-incinerator exists but saugus-landfill-incinerator-geo.tif file is not in the folder. I will need to investigate this further. Thanks Jeff.

jywarren commented 5 years ago

Hmm. All the other products are built from the GeoTiff, so if we're not getting the geotiff we shouldn't get jpg or tiles or zip. I think this is all working on the live site as i tested it... is this just in your local? Thanks!

On Tue, May 21, 2019 at 1:11 PM Cess notifications@github.com wrote:

might be the geotiff its not being created. The folder public/warps/saugus-landfill-incinerator exists but saugus-landfill-incinerator-geo.tif file is not in the folder. I will need to investigate this further. Thanks Jeff.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/625?email_source=notifications&email_token=AAAF6J6XALWLSJXLIOXZYK3PWQULHA5CNFSM4HOJLTW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV4SG3Q#issuecomment-494478190, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J5LYTEBGBP22XJZ523PWQULHANCNFSM4HOJLTWQ .

cesswairimu commented 5 years ago

Yeah, maybe, could be :thinking:... @alaxalves could you please try to test this locally if you have a minute and let me know if it works fine or otherwise?