search

publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
268 stars 208 forks source link

Call for Reviewers 🎉 #634

Open grvsachdeva opened 5 years ago

grvsachdeva commented 5 years ago

Hi everyone, our community is growing fast :rocket: :zap:. Thanks to the number of contributions each one of you has made. With the growth of new contributors to the Mapknitter and so many new and exciting projects, we want your help with reviewing and so we invite people to step up and volunteer to be the part of reviewers group :smiley:. Also, we are preparing the software community roadmap at https://publiclab.org/notes/warren/05-22-2019/draft-of-a-public-lab-software-roadmap-comments-welcome so comments and suggestions are welcome!!

Community growth

This is especially important as our community around Mapknitter has grown so much in the past few months!

Check out some of these pages to see how many people have helped build mapknitter, since we really started doing welcoming and outreach:

What's next: co-review workflow

To build on this community strength 🤝, we'd like to ask for people to sign up as reviewers, to help get pull requests ready for merging. In the new workflow, we'd like each PR to have:

This doesn't mean that we should stop helping each other solve problems even if we're not in the reviewers' group -- We've seen a lot of great welcoming and cooperation! But at least we'll be able to get things ready and merged faster. 👍 🙌

Reviewers team

So, this new @publiclab/mapknitter-reviewers team -- we'd like to ask folks to join it if you're interested! Many of you already play this role -- THANK YOU! 🎉 We'd like folks to consider, as a prerequisite to joining:

If you've completed these, please ask here and we'll be sure to add you the new reviewers' group. You'll get notifications when people request a review from you, or mention @publiclab/mapknitter-reviewers.

Also, we welcome reviews by folks not in the reviewers' group, of course! This will be a group to help coordinate co-reviews, but it's not meant to be exclusive. And we encourage people to join!

Managing too many emails!

Just a note - your inbox can become quite a mess as the community grows! Consider turning off notifications for /every event/ and just listening to if you're mentioned! 📬

THANK YOU for making this part of the Public Lab coding community a warm, welcoming, and wonderful place!!! ⚡️ 🙌 👍 🎉 🎉 🎉

jywarren commented 5 years ago

@publiclab/mapknitter-reviewers how do we feel about the above "policy" of 2+ approving reviews, with tests preferred, and using this policy to expand the group with merge privileges?

cesswairimu commented 5 years ago

Sounds good to me

kaustubh-nair commented 5 years ago

@publiclab/mapknitter-reviewers how do we feel about the above "policy" of 2+ approving reviews, with tests preferred, and using this policy to expand the group with merge privileges?

Sounds like a good idea @jywarren

sashadev-sky commented 5 years ago

Hi I completed the tasks :) 1) FTO: #636 2) PRs Merged: #483, #552 3) Troubleshooting: https://github.com/publiclab/mapknitter/pull/547

sagarpreet-chadha commented 5 years ago

I would also love to join this team as well :-)

cesswairimu commented 5 years ago

I guess we can keep this open a little longer for other folks who would like to join. Thanks

jywarren commented 5 years ago

Yes, good idea!

On Wed, Jun 19, 2019 at 6:28 AM Cess notifications@github.com wrote:

I guess we can keep this open a little longer for other folks who would like to join. Thanks

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/634?email_source=notifications&email_token=AAAF6JYXZL7TVHF25SAROALP3ICZZA5CNFSM4HPT2NOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYBNRXQ#issuecomment-503503070, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J6NDZ33FUO473JNAWLP3ICZZANCNFSM4HPT2NOA .