search

publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
268 stars 210 forks source link

Longer image file name hidden by side buttons. #939

Open metonymic-smokey opened 5 years ago

metonymic-smokey commented 5 years ago

What happened just before the problem occurred

When I set up Mapknitter locally and uploaded an image with a very long name, I found the image names being hidden by the buttons. Here's an example screenshot: download_before And another: Download_later

Proposed Fix: Hence, I thought continuing the string in the next line would look much better and thought of implementing the same.

PublicLab.org username -

stuck to the default harry

Browser, version, and operating system

Ubuntu 18.04.2 LTS, Firefox.

welcome[bot] commented 5 years ago

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄 If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

metonymic-smokey commented 5 years ago

@divyabaid16 @gauravano

grvsachdeva commented 5 years ago

Hey @metonymic-smokey, how about using text-overflow for handling this as a malicious user might try to upload a file having name with large # of chars?

Thank you!!

metonymic-smokey commented 5 years ago

@gauravano I was looking into overflow-wrap in CSS to solve this, to basically continue the word(i.e. file name) to the next line. Considering the security aspect as you mentioned, I think text-overflow would be better. I'll just look into that. Thanks for the suggestion!

gr455 commented 4 years ago

Hey, has this issue been fixed? Because the names appear fine(dont overlap with the buttons) when I ran mapknitter locally