search

publiclab / matcher-cli

Node-based CLI utility for local matcher-core configs headless testing 🎈
GNU General Public License v3.0
1 stars 7 forks source link

Mock PR to initiate CI service #5

Closed rexagod closed 5 years ago

rexagod commented 5 years ago

For some reason the token's empty https://travis-ci.com/publiclab/matcher-cli/jobs/209094455#L488

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:547530792 
 Job Number:30.1 
 VSnapLink:https://i.imgur.com/V4WvZ8y.png

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:547530793 
 Job Number:30.2 
 VSnapLink:https://i.imgur.com/JyHxx6w.png

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:209156520 
 Job Number:14.1 
 VSnapLink:https://i.imgur.com/zNg7PjV.png

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:547530794 
 Job Number:30.3 
 VSnapLink:https://i.imgur.com/7B1jNAo.png

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:209156522 
 Job Number:14.3 
 VSnapLink:https://i.imgur.com/Sh1Gi2y.png

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:209156521 
 Job Number:14.2 
 VSnapLink:https://i.imgur.com/1Ct7BuV.png

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:209157049 
 Job Number:16.1 
 VSnapLink:https://i.imgur.com/2kKTXBd.png

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:547531716 
 Job Number:32.1 
 VSnapLink:https://i.imgur.com/omPaGyF.png

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:547531717 
 Job Number:32.2 
 VSnapLink:https://i.imgur.com/KMTJHE7.png

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:209157050 
 Job Number:16.2 
 VSnapLink:https://i.imgur.com/04us71H.png

rexagod commented 5 years ago

@jywarren This will now work for any PR to ci-ops branch, as shown above. Once ci-ops has been merged to main this will work for it as well. Details: https://github.com/publiclab/matcher-cli/pull/5/checks

jywarren commented 5 years ago

OK, this is cool - can you write in the docs OR in the comments that it posts, explaining what we're seeing in these screenshots? Like, how will someone coming here know what they're looking at, or if it's good or bad? Thanks Pranshu!!!

jywarren commented 5 years ago

And also, although I see https://travis-ci.com/publiclab/matcher-cli/jobs/209157049, it's not clear to me if the orb-core: processing... that I see in the screenshot is ALSO running in the Travis jobs, or what relation these have to each other. I think it's important that people be able to see your tests running in text, as well! And that it be clear what they're doing (explain this -- to a newcomer!) and what is "success", you know? Thank you!

IgorWilbert commented 5 years ago

@rexagod great work, thank you! I agree with Jeff, it may help others in the future quite a lot. May I help you in any way?

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:214860773 
 Job Number:18.1 
 VSnapLink:https://i.imgur.com/MgfhTqB.png

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:556885626 
 Job Number:34.1 
 VSnapLink:https://i.imgur.com/caFmcJN.png

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:214860774 
 Job Number:18.2 
 VSnapLink:https://i.imgur.com/FyEuWZL.png

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:556885627 
 Job Number:34.2 
 VSnapLink:https://i.imgur.com/lIoAxDj.png

rexagod commented 5 years ago

Travis logs 

 Event:pull_request 
 ID:556887124 
 Job Number:36.2 
 VSnapLink:https://i.imgur.com/V5nB1ui.png

jywarren commented 5 years ago

Oh whoa, we were in the PR, just commenting on the commits within it! Sorry, I'd just never seen that approach to commenting before. Thanks!

jywarren commented 5 years ago

So, i don't quite understand here, does this PR represent new code? Why is it a "Mock PR"? Sorry @rexagod i just am having some trouble understanding your workflow... can you explain what's going on here? Thanks!

jywarren commented 5 years ago

I think perhaps it's a good idea to think of a general workflow of:

  1. write an issue describing a function or problem or goal to address
  2. open a PR with code that addresses the issue

That makes it a lot easier for others to follow what you're doing, you know? Thanks for all your hard work, @rexagod, I think it's really cool! I'm just trying to provide some input on your workflow to help it be more readable to others!

rexagod commented 5 years ago

Why is it a "Mock PR"?

@jywarren This one was to demo the m-cli integration into travis for automated builds as I showcased a while back in the opencall.

Sure thing, I'll do this more frequently here now! Thanks!