New "simple" implementation using matcher-core

[jywarren]

With #3, #4, and #2 in mind, I want to propose that once those are completed, we look to create a simple Image Sequencer module from matcher-core that can be a very minimal implementation to clearly demonstrate how to use this library, in contrast to the quite complex integration at https://github.com/publiclab/Leaflet.DistortableImage/pull/312.

I think before we move forward with https://github.com/publiclab/Leaflet.DistortableImage/pull/312, let's create this one, to complete the matcher-core project!

It would:

1. accept as inputs the previous step and another specified step (default the n-2 step), just as the Overlay modules does: https://github.com/publiclab/image-sequencer/blob/main/src/modules/Overlay/info.json#L15
2. run findPoints() and findPointMatches() on them
3. do something with the outputs; we can start just by outputting the coordinate pairs, and running a function on matches like onFoundMatches(matches) that is a configurable parameter, and so just like we do on the blend module, we can offer a default that does something simple as an example

What do you think, @rexagod ? This would show all the integration steps in a very simple short section of code, and make matcher-core's abilities available in image-sequencer.

[rexagod]

Working on this right away, I'll update along the way! Thanks!

cc @jywarren

[jywarren]

Awesome!!!

On Wed, Jul 17, 2019, 1:27 PM Pranshu Srivastava notifications@github.com wrote:

Working on this right away, I'll update along the way! Thanks!

cc @jywarren https://github.com/jywarren

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/matcher-core/issues/5?email_source=notifications&email_token=AAAF6JZT6VEZALHCSPB4V3DP75I6DA5CNFSM4IDYI5A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2FTFNA#issuecomment-512438964, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J4HEEGCT3GUSBGMC5LP75I6DANCNFSM4IDYI5AQ .

[rexagod]

running a function on matches like onFoundMatches(matches) that is a configurable parameter, and so just like we do on the blend module, we can offer a default that does something simple

@jywarren I've integrated the matcher into IS, and am currently logging the matches in the console. Can you further simplify what I should do with these matched pairs? Just wanted to be sure about the implementation!

Thanks!

[jywarren]

That's awesome - can you link a PR?

Would it be reasonable to try using the projection class to rotate and then overlay the image on the paired image? Would that be relatively simple to do?

On Fri, Jul 19, 2019 at 1:55 PM Pranshu Srivastava notifications@github.com wrote:

running a function on matches like onFoundMatches(matches) that is a configurable parameter, and so just like we do on the blend module, we can offer a default that does something simple

@jywarren https://github.com/jywarren I've integrated the matcher into IS, and am currently logging the matches in the console. Can you further simplify what I should do with these matched pairs? Just wanted to be sure about the implementation!

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/matcher-core/issues/5?email_source=notifications&email_token=AAAF6J64YJPA7IVYGKVTLOLQAH5YHA5CNFSM4IDYI5A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2MKHVY#issuecomment-513319895, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6JZ3JMP5F73CPPDQ2SLQAH5YHANCNFSM4IDYI5AQ .

[jywarren]

Hi @rexagod can you open a PR with whatever you currently have? It doesn't matter if it's incomplete, but it's really important for others to be able to follow your work. Really any code - just please open a PR! Thank you!

[rexagod]

No problem, I just wanted to get the node issue #9 solved before pushing a PR to IS, but can you have a look over #9? I can push a PR right now, since there's hardly any code required in node (no gui) but it's not going to work until unless a proper implementation is done for solving #9 which can most definitely lead to me scraping away all the IS integration code and replacing it with the newer version that comes out of #9. So wouldn't it be better to finalize a method (socket, headless, etc.) first?

In any case, I'm fine with whatever you choose to do atm.

[jywarren]

Would it make sense to push the module info.json and the browser compatible approach only, now? I think honestly any commit you can push would be useful just as a marker to communicate with others!

On Sat, Aug 3, 2019, 1:33 PM Pranshu Srivastava notifications@github.com wrote:

No problem, I just wanted to get the node issue #9 https://github.com/publiclab/matcher-core/issues/9 solved before pushing a PR to IS, but can you have a look over #9 https://github.com/publiclab/matcher-core/issues/9? I can push a PR right now, since there's hardly any code required in node (no gui) but it's not going to work until unless a proper implementation is done for solving

9 https://github.com/publiclab/matcher-core/issues/9 which can most

definitely lead to me scraping away all the IS integration code and replacing it with the newer version that comes out of #9 https://github.com/publiclab/matcher-core/issues/9. So wouldn't it be better to finalize a method (socket, headless, etc.) first?

In any case, I'm fine with whatever you choose to do atm.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/matcher-core/issues/5?email_source=notifications&email_token=AAAF6JZAFOPQQPX3HHUGPKTQCVNFHA5CNFSM4IDYI5A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3PL7ZI#issuecomment-517914597, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J5XQ76D3YNPYUEFXBDQCVNFHANCNFSM4IDYI5AQ .

[rexagod]

Sure thing! I'll push this the first thing tomorrow morning! :+1:

[rexagod]

https://github.com/publiclab/image-sequencer/pull/1198