search

publiclab / pi-builder

Developing a reproducible build script system for making Raspberry Pi .img files
MIT License
22 stars 15 forks source link

Auto-rebase? #48

Open jywarren opened 6 years ago

jywarren commented 6 years ago

This app seems to be able to auto-rebase anything labeled autorebase, and i'm going to install it and try it on my own PR!

https://github.com/tibdex/autorebase

jywarren commented 6 years ago

Ok, after accidentally auto-merging a PR i realized this bot will actually do a merge if it's allowed to. So I added branch protection and required a review. I think it's possible we could remove the review requirement and it still wouldn't have permissions to merge to master (i don't think it ever should).

But in #50 i don't see it auto rebasing...?

jywarren commented 6 years ago

I'm worried this is stopping builds, so i'm testing turning it off: https://github.com/apps/autorebase

@icarito in case this helps!

icarito commented 6 years ago

Thanks! I'm afraid I've tried it all and for some reason gitlab is not triggering status updates on github's PRs like it was doing before. It may be because of the project rename, but even re-creating a fresh repo either with the auto-importer or manually didn't succeed:

https://gitlab.com/publiclab/pi-builder-builder/-/jobs
https://gitlab.com/publiclab/pi-builder-ci/-/jobs

And the original:

https://gitlab.com/publiclab/pi-builder/-/jobs

At this point I'm thinking of seeking gitlab support.

jywarren commented 6 years ago

oh, that sounds frustrating. I think asking GitLab for support sounds like a good idea!

On Fri, Nov 9, 2018 at 1:44 PM Sebastian Silva notifications@github.com wrote:

Thanks! I'm afraid I've tried it all and for some reason gitlab is not triggering status updates on github's PRs like it was doing before. It may be because of the project rename, but even re-creating a fresh repo either with the auto-importer or manually didn't succeed:

https://gitlab.com/publiclab/pi-builder-builder/-/jobshttps://gitlab.com/publiclab/pi-builder-ci/-/jobs

And the original:

https://gitlab.com/publiclab/pi-builder/-/jobs

At this point I'm thinking of seeking gitlab support.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/pi-builder/issues/48#issuecomment-437455944, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ16y7F9NLLhGTTNLsfsTfRrqcwX-ks5utczPgaJpZM4YPc97 .

jywarren commented 6 years ago

Not sure if we got the build triggering completed, but as we make changes to the base repo, the idea of auto-rebase sounds more and more important. Thinking ahead to this a bit more!