publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
957 stars 1.83k forks source link

Enable Unfollow Button for Blogs #10988

Closed TildaDares closed 2 years ago

TildaDares commented 2 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -15,7 +15,7 @@
       <% if current_user %>
         <a class="btn btn-outline-secondary btn-sm" href="/feed/tag/<%=h params[:id] %>.rss"><i class="fa fa-rss"></i> RSS</a>
         <% if current_user.following(params[:id]) %>
-          <a rel="tooltip" title="<%= translation('tag.blog.unfollow',{},false) %>" class="btn btn-outline-secondary btn-sm active" href="/unsubscribe/tag/<%=h params[:id] %>"><i class="fa fa-user-plus" aria-hidden="true"></i> <%= translation('tag.blog.following') %> <b><%=h params[:id] %></b></a>
+          <a rel="tooltip" title="<%= translation('tag.blog.unfollow',{},false) %>" class="btn btn-outline-secondary btn-sm active" href="/unsubscribe/tag/<%=h params[:id] %>" data-method="delete"><i class="fa fa-user-plus" aria-hidden="true"></i> <%= translation('tag.blog.following') %> <b><%=h params[:id] %></b></a>
         <% else %>
           <br><br>
           <div class="alert alert-success" role="alert">
  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

Please keep us updated

πŸ’¬β° - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

πŸ”—- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

πŸ‘₯- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

πŸ€”β“ Questions?

Leave a comment below, and reach out in our chatroom!

TildaDares commented 2 years ago

Reserved for @nobiaya for 24 hours!!

abhishekchauhan15 commented 2 years ago

I can work on this can you please assign me?

TildaDares commented 2 years ago

Hi @abhishekchauhan15, this issue has been reserved. You can request for an issue in #10153. Thanks!

TildaDares commented 2 years ago

Hi @abhishekchauhan15, you can work on this since #10979 has been claimed.

nobiaya commented 2 years ago

@TildaDares has this issue for me been calmed can I still go ahead and make a pull request

rajvidg commented 2 years ago

@TildaDares is this issue still open? Please let me know, I am an Outreachy applicant.

TechAtikiN commented 2 years ago

I'd like to work on this, @TildaDares please let me know if this issue is still open?

abhishekchauhan15 commented 2 years ago

Hello @TildaDares thank you so much for your patience, I have opened the PR but I'm not able to find why one of the test case is failing can you please review it

abhishekchauhan15 commented 2 years ago

fixed