publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Add translations for subscriptions.html.erb #11206

Closed TildaDares closed 2 years ago

TildaDares commented 2 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -15,7 +15,7 @@

   <hr />
   <p>
-    <a href="/subscriptions/digest" class="btn btn-outline-secondary"><i class="fa fa-list"></i> Subscriptions digest</a>
+    <a href="/subscriptions/digest" class="btn btn-outline-secondary"><i class="fa fa-list"></i> <%= raw translation('home.subscriptions.subscriptions_digest') %></a>
   </p>
   <hr />

@@ -32,9 +32,9 @@

   <hr />

-  <a href="/settings" class="btn btn-outline-secondary" style="margin-bottom: 10px;"><i class="fa fa-bell"></i> Notification settings </a>
+  <a href="/settings" class="btn btn-outline-secondary" style="margin-bottom: 10px;"><i class="fa fa-bell"></i> <%= raw translation('home.subscriptions.notification_settings') %> </a>

-  <p style="font-style: italic;"> Control how you get notifications. </p>
+  <p style="font-style: italic;"> <%= raw translation('home.subscriptions.control_notifications') %> </p>

 </div>

@@ -56,13 +56,13 @@
   </form>

   <% if current_user.subscriptions.size == 0 %>
-  <p> You haven't subscribed to any topic yet </p>
+  <p> <%= raw translation('home.subscriptions.subscribe_topic') %> </p>
   <% else %>
     <table class="table">
     <tr><th><%=raw translation('home.subscriptions.tag') %></th><th><%=raw translation('home.subscriptions.options') %></th></tr>
     <% current_user.subscriptions(:tag).includes(:tag).each do |subscription| %>
     <tr>
-      <td><a href="/tag/<%= subscription.tagname %>"><%= subscription.tagname %></a> <i style="color:#aaa;"> +<%= Tag.follower_count(subscription.tagname).to_i-1 %> other people</i></td>
+      <td><a href="/tag/<%= subscription.tagname %>"><%= subscription.tagname %></a> <i style="color:#aaa;"> +<%= Tag.follower_count(subscription.tagname).to_i-1 %> <%= raw translation('home.subscriptions.other_people') %></i></td>
       <td><div class="btn-toolbar" style="margin:0;">
         <div class="btn-group">
           <!--

See this page for some help in taking your first steps!

@@ -900,6 +900,11 @@ en:
       share_subscription_link: "Share this subscription link"
       share: "Share"
       unsubscribe: "Unfollow"
+      subscribe_topic: "Subscribe to Topics"
+      notification_settings: "Notification Settings"
+      subscriptions_digest: "Subscriptions Digest"
+      control_notifications: "Control how you get notifications"
+      subscribe_topics: "You haven't subscribed to any topic yet"
+      other_people: "other people"
     _comments:
       commented: "commented"
       read_more: "Read more"
  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

Please keep us updated

πŸ’¬β° - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

πŸ”—- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

πŸ‘₯- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

πŸ€”β“ Questions?

Leave a comment below, and reach out in our chatroom!

TildaDares commented 2 years ago

Reserved for @gitofbabai for 24 hours!

gitofbabai commented 2 years ago

Hi @TildaDares sorry for the late reply, I will work on this issue today. Thanks for assigning it to me.

Abdullahqasim75 commented 2 years ago

@gitofbabai are you working on this issue?

Abdullahqasim75 commented 2 years ago

i am a beginner and want's to work on this issue can i work on it?

TildaDares commented 2 years ago

Hi @gitofbabai, do you need any assistance with this? Feel free to ask if you do.

Abdullahqasim75 commented 2 years ago

can i work on this issue?

On Mon, 4 Jul, 2022, 11:56 pm Tilda Udufo, @.***> wrote:

Hi @gitofbabai https://github.com/gitofbabai, do you need any assistance with this? Feel free to ask if you do.

β€” Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/11206#issuecomment-1174060251, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASRPAX7VB662OVYMMH3762TVSMUEJANCNFSM5ZQZNGTQ . You are receiving this because you commented.Message ID: @.***>

TildaDares commented 2 years ago

Hi @Abdullahqasim75, let’s give @gitofbabai some time to respond. I can see you’ve requested for an FTO in our FTO requests issue. Don’t worry we’ll help you look for an issue. Thanks!

gitofbabai commented 2 years ago

Hi @TildaDares I tried to make all the changes as described but the pull request failed. Can not resolve that. Any assistance would be very helpful.

TildaDares commented 2 years ago

Hi @gitofbabai, can you elaborate on how the PR failed so that I know exactly how to help. Thanks!