publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Move `Follow` and `New Post` Buttons to Bottom of Profile Card #11260

Closed TildaDares closed 2 years ago

TildaDares commented 2 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -29,19 +29,19 @@
           by @<%= @profile_user.name %>
         </div>
       </div>
+    </div>

-      <div class="col">
-        <a style="float: right;  width: 100px;" rel="tooltip" title="<%= translation('sidebar._post_button.share_your_work',{},false) %>" data-placement="bottom" href="/post?tags=<%= tag.name %>" class="btn btn-primary btn-sm"><%= translation('tag.show.new_post') %> <i class="fa fa-plus fa-white"></i></a>
-        <% if current_user %>
-        <div id="follow-unfollow-column-<%=tag.tid%>" style="float: right; margin-right: 10px;">
-          <% if current_user.following(tag.name) %>
-            <a style="width: 100px;" rel="tooltip" title="<%= translation('tag.show.unfollow',{},false) %>" class="btn btn-light btn-sm active" href="/unsubscribe/tag/<%= tag.name %>" data-method="delete"> <%= translation('tag.index.unfollow') %></a>
-          <% else %>
-            <a style="width: 100px;" class="btn btn-outline-secondary btn-sm index-follow-buttons follow-btn-remote" href="/subscribe/tag/<%= tag.name %>" data-remote="true"><%= translation('tag.index.follow') %></a>
-          <% end %>
-        </div>
+    <div class="mb-2 mr-2">
+      <a style="float: right;  width: 100px;" rel="tooltip" title="<%= translation('sidebar._post_button.share_your_work',{},false) %>" data-placement="bottom" href="/post?tags=<%= tag.name %>" class="btn btn-primary btn-sm"><%= translation('tag.show.new_post') %> <i class="fa fa-plus fa-white"></i></a>
+      <% if current_user %>
+      <div id="follow-unfollow-column-<%=tag.tid%>" style="float: right; margin-right: 10px;">
+        <% if current_user.following(tag.name) %>
+          <a style="width: 100px;" rel="tooltip" title="<%= translation('tag.show.unfollow',{},false) %>" class="btn btn-light btn-sm active" href="/unsubscribe/tag/<%= tag.name %>" data-method="delete"> <%= translation('tag.index.unfollow') %></a>
+        <% else %>
+          <a style="width: 100px;" class="btn btn-outline-secondary btn-sm index-follow-buttons follow-btn-remote" href="/subscribe/tag/<%= tag.name %>" data-remote="true"><%= translation('tag.index.follow') %></a>
         <% end %>
       </div>
+      <% end %>
     </div>
   </div>
 <% end %>

Before & After

Screenshot 2022-07-10 at 09 09 27 Screenshot 2022-07-10 at 09 09 50
  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

Please keep us updated

πŸ’¬β° - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

πŸ”—- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

πŸ‘₯- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

πŸ€”β“ Questions?

Leave a comment below, and reach out in our chatroom!

TildaDares commented 2 years ago

Reserved for @lblk-coder for 24 hours!

leighbriody commented 2 years ago

I would like to try this if no one has yet ?

TildaDares commented 2 years ago

Hi @leighbriody, this issue has been reserved but you can leave a comment in this issue #11105 and we’ll help you look for an issue you can work on. Thanks!

TildaDares commented 2 years ago

Reassigning!

TildaDares commented 2 years ago

Reserved for @bad-atnames0 for 24 hours!

ghost commented 2 years ago

Thanks @TildaDares I'll start working on the issue

ghost commented 2 years ago

@TildaDares Thanks for letting me a part of the issue , I have completed the fix and issued the PR. Please do share any other issues that I can contribute to .. I have sound knowledge of HTML CSS JS REACT MONGODB EJS NODEJS and EXPRESSJS