Replace var keyword with let/const

Josephsanya commented 2 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

[ ] 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.
[ ] 📝 Update the file research-notify.js in the publiclab/plot2 repository by replacing the var keyword with let/const (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

-6 var SelText = '';
+6 let SelText = '';

-20 var v = "1.3.2";
+20 const v = "1.3.2";

-24 var done = false;
+24 let done = false;
-25 var script = document.createElement("script");
+25 const script = document.createElement("script");

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in the comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming the first-timers-only issue. We're happy to keep it assigned to you as long as you need it if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

welcome[bot] commented 2 years ago

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help. Please follow the issue template to help us help you 👍🎉😄 If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸 Do join our Gitter channel for some brainstorming discussions.

JulianaSau commented 2 years ago

Hi @cesswairimu, I'd like to work on this issue

TildaDares commented 2 years ago

Great work on the issue @JulianaSau. Thank you!

TildaDares commented 2 years ago

Hi @JulianaSau, please go ahead. Thank you!

JulianaSau commented 2 years ago

Thank you. I'll send in a PR for it soon😁

Sniffr commented 2 years ago

@TildaDares Hi i would like to do this

JulianaSau commented 2 years ago

@Sniffr I'm already working on the issue

AdityaVerma32 commented 2 years ago

Hello, Can I work on it?

Josephsanya commented 2 years ago

@JulianaSau You haven't worked on this issue ? Please let us or the mentors know if you have any issue

AdityaVerma32 commented 2 years ago

I haven't worked on this issue but I want to .

AdityaVerma32 commented 2 years ago

I have submitted the push request plz review it and also add hacktoberfest tag with it

TildaDares commented 2 years ago

Hi @AdityaVerma32, someone is already working on this issue. You can request for an issue here #11105

lizwe-mac commented 2 years ago

Hi, may I be assigned to this issue?

JulianaSau commented 2 years ago

@JulianaSau You haven't worked on this issue ? Please let us or the mentors know if you have any issue

I've had some issues with my machine but will send in a PR today

publiclab / plots2