search

publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Inverted negation in if/else statement #11483

Closed ghost closed 2 years ago

ghost commented 2 years ago

inverted negation in if/else statement Fixes #11417

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

@publiclab/reviewers please do review and merge.

welcome[bot] commented 2 years ago

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. Dangerbot will test out your code and reply in a bit with some pointers and requests. Also please refer here for installation help 💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌
Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

gitpod-io[bot] commented 2 years ago

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 643246d0 and detected 0 issues on this pull request.

View more on Code Climate.

github-actions[bot] commented 2 years ago

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8775009774/artifacts/398203166

TildaDares commented 2 years ago

Resolved in #11484