publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Inverted negation for if/else statement #11484

Closed ghost closed 2 years ago

ghost commented 2 years ago
gitpod-io[bot] commented 2 years ago

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit dd2ab0f7 and detected 0 issues on this pull request.

View more on Code Climate.

github-actions[bot] commented 2 years ago

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8775390270/artifacts/398229526

codecov[bot] commented 2 years ago

Codecov Report

Merging #11484 (dd2ab0f) into main (21dfe4c) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/publiclab/plots2/pull/11484/graphs/tree.svg?width=650&height=150&src=pr&token=FahMFdiDeF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab)](https://codecov.io/gh/publiclab/plots2/pull/11484?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) ```diff @@ Coverage Diff @@ ## main #11484 +/- ## ======================================= Coverage 83.33% 83.33% ======================================= Files 93 93 Lines 5772 5772 ======================================= Hits 4810 4810 Misses 962 962 ``` | [Impacted Files](https://codecov.io/gh/publiclab/plots2/pull/11484?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) | Coverage Ξ” | | |---|---|---| | [app/channels/user\_channel.rb](https://codecov.io/gh/publiclab/plots2/pull/11484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NoYW5uZWxzL3VzZXJfY2hhbm5lbC5yYg==) | `83.33% <100.00%> (ΓΈ)` | |
ghost commented 2 years ago

@Josephsanya please can you review this issue that was assigned to me?

Josephsanya commented 2 years ago

You did well Let's wait for the mentors to approve @TildaDares

ghost commented 2 years ago

Thank you @Josephsanya

ghost commented 2 years ago

@TildaDares please can you review this issue that was assigned to me?

TildaDares commented 2 years ago

Thank you for the reviews @Josephsanya!

welcome[bot] commented 2 years ago

Congrats on merging your first pull request! πŸ™ŒπŸŽ‰βš‘οΈ Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well! Do join our weekly check-in to share your this week goal and the awesome work you did πŸ˜ƒ. Please find the link to our latest check-in here πŸ“ Now that you've completed this, you can help someone else take their first step! Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. πŸ™Œ

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! πŸ˜•

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! πŸ˜„ πŸŽ‰

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors :inbox_tray:

TildaDares commented 2 years ago

Congratulations on merging your PR @Emenyi95 πŸŽ‰

7malikk commented 2 years ago

Congratulations @Emenyi95 πŸΎπŸŽ‰

Josephsanya commented 2 years ago

Happy to help @TildaDares Well-done @Emenyi95

ghost commented 2 years ago

Thank you @TildaDares.

On Fri, 14 Oct 2022 at 15:33 Tilda Udufo @.***> wrote:

@.**** approved this pull request.

Amazing job @Emenyi95 https://github.com/Emenyi95. Thank you!

β€” Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/pull/11484#pullrequestreview-1142534191, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZY2B6JXNPQGFQFW7OKHHHLWDFVKBANCNFSM6AAAAAARFEE5KM . You are receiving this because you were mentioned.Message ID: @.***>