Closed ghost closed 2 years ago
Code Climate has analyzed commit dd2ab0f7 and detected 0 issues on this pull request.
View more on Code Climate.
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8775390270/artifacts/398229526
Merging #11484 (dd2ab0f) into main (21dfe4c) will not change coverage. The diff coverage is
100.00%
.
@Josephsanya please can you review this issue that was assigned to me?
You did well Let's wait for the mentors to approve @TildaDares
Thank you @Josephsanya
@TildaDares please can you review this issue that was assigned to me?
Thank you for the reviews @Josephsanya!
Congrats on merging your first pull request! ππβ‘οΈ Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well! Do join our weekly check-in to share your this week goal and the awesome work you did π. Please find the link to our latest check-in here π Now that you've completed this, you can help someone else take their first step! Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!
Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. π
Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! π
People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! π π
Read about how to help support another newcomer here, or find other ways to offer mutual support here.
You can also join our Gitter channel to connect with other contributors :inbox_tray:
Congratulations on merging your PR @Emenyi95 π
Congratulations @Emenyi95 πΎπ
Happy to help @TildaDares Well-done @Emenyi95
Thank you @TildaDares.
On Fri, 14 Oct 2022 at 15:33 Tilda Udufo @.***> wrote:
@.**** approved this pull request.
Amazing job @Emenyi95 https://github.com/Emenyi95. Thank you!
β Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/pull/11484#pullrequestreview-1142534191, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZY2B6JXNPQGFQFW7OKHHHLWDFVKBANCNFSM6AAAAAARFEE5KM . You are receiving this because you were mentioned.Message ID: @.***>
Inverted the statement such that when the user is nil,there is a rejection Fixes #11417
Inverted negation in if/else statement such that there is a rejection when user is nil Fixes #11417