publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Remove extra plus signs from code #11486

Closed TildaDares closed 2 years ago

TildaDares commented 2 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barrier for new contributors. This issue is for you πŸ’

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -35,16 +35,16 @@
                   <div class="col-md-4 card-responsive mb-2 pr-1">
                     <div class="card">
                       <a <% if @widget %>target="_blank"<% end %> href="<%= node.path %>">
-+                        <% if node.main_image %>
-+                            <img class="card-img-top" style="margin-bottom: 10px;" aria-hidden="true" src="<%= node.main_image.path(:default) %>" />
-+                        <% elsif node.scraped_image %>
-+                            <img class="card-img-top" style="margin-bottom: 10px;" aria-hidden="true" src="<%= node.scraped_image %>" />
-+                        <% else %>
-+                          <div class="imgg" style="background:#ddd; margin-bottom: 10px;overflow:hidden;">
-+                            <img src="https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/045/449/medium/paint-bucket.png" style="width: 100%;padding: 15% 30%;opacity: 0.3;">
-+                          </div>
-+                        <% end %>
-+                      </a>
+                        <% if node.main_image %>
+                            <img class="card-img-top" style="margin-bottom: 10px;" aria-hidden="true" src="<%= node.main_image.path(:default) %>" />
+                        <% elsif node.scraped_image %>
+                            <img class="card-img-top" style="margin-bottom: 10px;" aria-hidden="true" src="<%= node.scraped_image %>" />
+                        <% else %>
+                          <div class="imgg" style="background:#ddd; margin-bottom: 10px;overflow:hidden;">
+                            <img src="https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/045/449/medium/paint-bucket.png" style="width: 100%;padding: 15% 30%;opacity: 0.3;">
+                          </div>
+                        <% end %>
+                      </a>
                       <div class="card-body">
                           <h5 style="margin-bottom: 0px;" class="text-truncate"><a style="color: inherit; text-decoration: none;" <% if @widget %>target="_blank"<% end %> href="<%= node.path %>" style="color: black"><%= (node.type == 'note') ? node.title : node.latest.title %></a></h5>
                           <div style="font-size:1.0em;color:darkgray;">
  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

Please keep us updated

πŸ’¬β° - We encourage contributors to be respectful to the community and provide an update within a week of claiming the first-timers-only issue. We're happy to keep it assigned to you as long as you need it if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

πŸ”—- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

πŸ‘₯- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

πŸ€”β“ Questions?

Leave a comment below, and reach out in our chatroom!

TildaDares commented 2 years ago

Reserved for @Tkwenan for 24 hours!

Chinazaekpere-Ike commented 2 years ago

I'd like to claim this issue πŸ€—

TechieTee commented 2 years ago

please can you assign me a fto issue @TildaDares? Thank you and weldone.

Tkwenan commented 2 years ago

@TildaDares I've claimed the issue. Thanks!!

onireke commented 2 years ago

Hi @TildaDares please I am yet to be assigned a FTO the only I saw was that my comment was deleted. Kindly assist me. Thank you

TildaDares commented 2 years ago

Hi @Tkwenan, you need to push your changes upstream (publiclab/plots2).