publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

changed var to let #11488

Closed AdityaVerma32 closed 2 years ago

AdityaVerma32 commented 2 years ago

I have changed the var to let in (https://github.com/publiclab/plots2/tree/main/spec/javascripts)/inline_grids_spec.js file as stated in the issue.

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

gitpod-io[bot] commented 2 years ago

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 02392930 and detected 0 issues on this pull request.

View more on Code Climate.

github-actions[bot] commented 2 years ago

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8789946120/artifacts/399330951

TildaDares commented 2 years ago

Hi @AdityaVerma32, can you add a link to the issue?

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example)

codecov[bot] commented 2 years ago

Codecov Report

Merging #11488 (0239293) into main (55dd755) will increase coverage by 2.75%. The diff coverage is n/a.

:exclamation: Current head 0239293 differs from pull request most recent head 47cbc97. Consider uploading reports for the commit 47cbc97 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/publiclab/plots2/pull/11488/graphs/tree.svg?width=650&height=150&src=pr&token=FahMFdiDeF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab)](https://codecov.io/gh/publiclab/plots2/pull/11488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) ```diff @@ Coverage Diff @@ ## main #11488 +/- ## ========================================== + Coverage 80.45% 83.21% +2.75% ========================================== Files 93 93 Lines 5792 5772 -20 ========================================== + Hits 4660 4803 +143 + Misses 1132 969 -163 ``` | [Impacted Files](https://codecov.io/gh/publiclab/plots2/pull/11488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) | Coverage Ξ” | | |---|---|---| | [app/controllers/relationships\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL3JlbGF0aW9uc2hpcHNfY29udHJvbGxlci5yYg==) | `71.42% <0.00%> (ΓΈ)` | | | [app/controllers/home\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL2hvbWVfY29udHJvbGxlci5yYg==) | `95.65% <0.00%> (+0.06%)` | :arrow_up: | | [app/controllers/spam2\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL3NwYW0yX2NvbnRyb2xsZXIucmI=) | `71.84% <0.00%> (+0.27%)` | :arrow_up: | | [app/models/comment.rb](https://codecov.io/gh/publiclab/plots2/pull/11488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL21vZGVscy9jb21tZW50LnJi) | `77.70% <0.00%> (+0.32%)` | :arrow_up: | | [app/models/node.rb](https://codecov.io/gh/publiclab/plots2/pull/11488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL21vZGVscy9ub2RlLnJi) | `91.04% <0.00%> (+0.34%)` | :arrow_up: | | [app/models/user.rb](https://codecov.io/gh/publiclab/plots2/pull/11488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL21vZGVscy91c2VyLnJi) | `86.49% <0.00%> (+0.98%)` | :arrow_up: | | [app/controllers/users\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL3VzZXJzX2NvbnRyb2xsZXIucmI=) | `80.78% <0.00%> (+1.06%)` | :arrow_up: | | [app/api/srch/search.rb](https://codecov.io/gh/publiclab/plots2/pull/11488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2FwaS9zcmNoL3NlYXJjaC5yYg==) | `66.66% <0.00%> (+1.28%)` | :arrow_up: | | [app/controllers/user\_tags\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL3VzZXJfdGFnc19jb250cm9sbGVyLnJi) | `83.78% <0.00%> (+1.35%)` | :arrow_up: | | [app/controllers/admin\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL2FkbWluX2NvbnRyb2xsZXIucmI=) | `80.24% <0.00%> (+1.64%)` | :arrow_up: | | ... and [16 more](https://codecov.io/gh/publiclab/plots2/pull/11488/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) | |
TildaDares commented 2 years ago

Looks like this issue has been resolved in another PR. Closing now. Thank you!