publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Fix "click to unfollow is not working in /tag section" #11490

Closed first-timers[bot] closed 2 years ago

first-timers[bot] commented 2 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barrier for new contributors. This issue is for you πŸ’

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -97,7 +97,7 @@ def delete
               render json: true
             else
               flash[:notice] = "You have stopped following '#{params[:name]}'."
-              redirect_to "/subscriptions" + "?_=" + Time.now.to_i.to_s
+              redirect_back fallback_location: "/subscriptions?_=#{Time.now.to_i}"
             end
           end
         end
  1. If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.

  2. If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.

  3. You can also edit files directly in your browser and open a pull request from there.

Please keep us updated

πŸ’¬β° - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

πŸ”—- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

πŸ‘₯- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

πŸ€”β“ Questions?

Leave a comment below, and reach out in our chatroom!

cesswairimu commented 2 years ago

Reserving this for @Marvisjaja

SylviaKaks commented 2 years ago

i request to work on this issue @TildaDares

IvyJeptoo commented 2 years ago

I would love to work on the issue if no one is

IvyJeptoo commented 2 years ago

I claim the issue. working on it

cesswairimu commented 2 years ago

hi @IvyJeptoo, we usually has a contributor work on one first-timer-only issue. Maybe can browse bug or help-wanted non first-timer issue and leave this for a first-timer contributor? @SylviaKaks I see you are already working on https://github.com/publiclab/plots2/pull/11496 too, was there an issue for it? if so please link it to the pull request, if not you can create one and paste the link on the pull request description. thanks

cesswairimu commented 2 years ago

@Favour-Cay you can claim this one

IvyJeptoo commented 2 years ago

Okay @cesswairimu sorry I didn't know that. Thanks for the direction

TildaDares commented 2 years ago

Hi @cesswairimu, I'd like to reassign this issue since there's no response from @Favour-cay.

TildaDares commented 2 years ago

Reserved for @onujoy14 for 24 hours!

onujoy14 commented 2 years ago

I claim this issue