batch-controller rubocop fixes

first-timers[bot] commented 2 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

[ ] 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.
[ ] 📝 Update the file app/controllers/batch_controller.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -13,7 +13,7 @@ def batch_spam
         user_spamed << user.id
         user.ban
       end
-      flash[:notice] = node_spamed.to_s + ' nodes spammed and ' + user_spamed.length.to_s + ' users banned.'
+      flash[:notice] = "#{node_spamed} nodes spammed and #{user_spamed.length} users banned."
       redirect_to '/spam2'
     else
       flash[:error] = 'Only admins and moderators can mark a batch spam.'
@@ -33,7 +33,7 @@ def batch_publish
         user.unban
         user_published << user.id
       end
-      flash[:notice] = node_published.to_s + ' nodes published and ' + user_published.length.to_s + ' users unbanned.'
+      flash[:notice] = "#{node_published} nodes published and #{user_published.length} users unbanned."
       redirect_to '/spam2'
     else
       flash[:error] = 'Only admins and moderators can batch publish.'
@@ -49,7 +49,7 @@ def batch_delete
         node_delete += 1
         node.delete
       end
-      flash[:notice] = node_delete.to_s + ' nodes deleted'
+      flash[:notice] = "#{node_delete} nodes deleted"
       redirect_back fallback_location: root_path
     else
       flash[:error] = 'Only admins and moderators can batch delete.'
@@ -66,7 +66,7 @@ def batch_ban
         user_ban << user.id
         user.ban
       end
-      flash[:notice] = user_ban.length.to_s + ' users banned.'
+      flash[:notice] = "#{user_ban.length} users banned."
       redirect_back fallback_location: root_path
     else
       flash[:error] = 'Only admins and moderators can ban users.'
@@ -83,7 +83,7 @@ def batch_unban
         unbanned_users << user_unban.id
         user_unban.unban
       end
-      flash[:notice] = unbanned_users.length.to_s + ' users unbanned.'
+      flash[:notice] = "#{unbanned_users.length} users unbanned."
       redirect_back fallback_location: root_path
     else
       flash[:error] = 'Only admins and moderators can unban users.'
@@ -99,7 +99,7 @@ def batch_ban_user
         users << user_ban.id
         user_ban.ban
       end
-      flash[:notice] = users.length.to_s + ' users banned.'
+      flash[:notice] = "#{users.length} users banned."
       redirect_back fallback_location: root_path
     else
       flash[:error] = 'Only moderators can moderate users.'
@@ -138,7 +138,7 @@ def batch_comment
           flash[:notice] = 'Invalid Url'
         end
       end
-      flash[:notice] = comment_total.to_s + ' comments moderated.'
+      flash[:notice] = "#{comment_total} comments moderated."
       redirect_back fallback_location: root_path
     else
       flash[:error] = 'Only admins and moderators can moderate comments.'

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.
If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in the comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

cesswairimu commented 2 years ago

@IvyJeptoo reserving this for you

IvyJeptoo commented 2 years ago

Working on it. Thank you @cesswairimu

IvyJeptoo commented 2 years ago

@cesswairimu I have finished working on the issue

IvyJeptoo commented 2 years ago

hey @cesswairimu I have created a PR Can I work on other issues?

cesswairimu commented 2 years ago

sure @IvyJeptoo

IvyJeptoo commented 2 years ago

@cesswairimu please review my PR

publiclab / plots2