publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Accessibility #11494

Closed Natacha-Danbadan closed 2 years ago

Natacha-Danbadan commented 2 years ago

This issue aims to improve the accessibility of the html pages (Semantic HTML) and fix the position of the scripts to Keep up with best practices. This to enable web crawlers and users in general to be able to access the site's content regardless of a user's impairment. For example replace the nav tag with the header tag, have a main tag in all html files, position the script tag inside of the body as some are positioned out of the body. This would be done to all html files contained in the repo below.

https://github.com/publiclab/plots2/tree/main/public

screencapture-github-publiclab-plots2-blob-master-public-404-html-2022-10-16-20_58_31

welcome[bot] commented 2 years ago

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help. Please follow the issue template to help us help you 👍🎉😄 If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸 Do join our Gitter channel for some brainstorming discussions.

liliyao2022 commented 2 years ago

Hi, I'd like to try.

liliyao2022 commented 2 years ago

Replaced the nav tag with the header tag.

vareenrose commented 2 years ago

I'd like to do this for the rest of the html files

Natacha-Danbadan commented 2 years ago

Hi, the issue has'nt been approved yet.

TildaDares commented 2 years ago

Hi @Natacha-Danbadan, thank you for opening this issue. Your suggestion is very good and will help improve the accessibility of the site. Can you make a list of all the files that need this change? Thank you!

Natacha-Danbadan commented 2 years ago

The first set of HTML files can be found in the plots2 repo public folder, https://github.com/publiclab/plots2/tree/main/public 404.html 422.html 500.html 502.html 503.html

The second set of HTML files can be found in the leaflet.distortableImage repo examples folder, https://github.com/publiclab/Leaflet.DistortableImage/tree/main/examples archive.html export.html index.html listeners.html select.html

TildaDares commented 2 years ago

Hi @Natacha-Danbadan, this repo has a lot of HTML files but most of them don't have the normal HTML boilerplate. Can you add a list of the files with the HTML boilerplate so I can review them? Thanks!

Natacha-Danbadan commented 2 years ago

Yes @TildaDares I have just done that. I'm still expecting an FTO issue. Thank you ma'am.

TildaDares commented 2 years ago

Hi @Natacha-Danbadan, the other HTML files in here https://github.com/publiclab/plots2/tree/main/public apart from 404.html also need this change. Maybe you could work on that. Thanks!

Natacha-Danbadan commented 2 years ago

Yes ma'am, I also stated the other HTML files that need to be worked on in my previous message. I'll get started on that ASAP. Thanks ma'am.

Natacha-Danbadan commented 2 years ago

so while working on the accessibility on the HTML files , i discovered there was no base tag on the head tag, is there a a Default URL and a default target for all links on a page you would like me to add on the HTML base tag? @TildaDares @jywarren @PeculiarE

TildaDares commented 2 years ago

Hi @Natacha-Danbadan, setting a base tag now would mean having to change all the internal links in the project. That would be too big a task to complete before the contribution period ends. Thank you!

Natacha-Danbadan commented 2 years ago

Okay ma'am, duly noted.

Natacha-Danbadan commented 2 years ago

@TildaDares @cesswairimu @jywarren kindly help review my PR for the Plots2 repo. https://github.com/publiclab/plots2/pull/11539

Natacha-Danbadan commented 2 years ago

@TildaDares @cesswairimu @jywarren kindly help review my PR for the Leaflet.DistortableImage Repo https://github.com/publiclab/Leaflet.DistortableImage/pull/1234/

amarachi-nwokocha commented 2 years ago

Hi @Natacha-Danbadan is this issue taken id love to work on it