Update 404.html - Githubissues

publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:

https://publiclab.org

GNU General Public License v3.0

961 stars 1.83k forks source link

Update 404.html #11495

Closed liliyao2022 closed 2 years ago

liliyao2022 commented 2 years ago

Replaced the nav tag with the header tag.

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

[ ] PR is descriptively titled 📑 and links the original issue above 🔗
[ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
[ ] code is in uniquely-named feature branch and has no merge conflicts 📁
[ ] screenshots/GIFs are attached 📎 in case of UI updation
[ ] ask @publiclab/reviewers for help, in a comment below

welcome[bot] commented 2 years ago

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. Dangerbot will test out your code and reply in a bit with some pointers and requests. Also please refer here for installation help 💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌
Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

gitpod-io[bot] commented 2 years ago

liliyao2022 commented 2 years ago

replaced the nav tag with the header tag.

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 8db22fdf and detected 0 issues on this pull request.

View more on Code Climate.

github-actions[bot] commented 2 years ago

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8800897261/artifacts/400190952

TildaDares commented 2 years ago

Hi @liliyao2022, can you add a link to the issue?

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example)

TildaDares commented 2 years ago

Thank you for taking the time to work on this PR but the issue has been resolved in #11539.