invert negation in if/else - relationships_controller

[Dhei-vid]

Fixes #11504

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• [x] PR is descriptively titled 📑 and links the original issue above 🔗
• [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• [x] code is in uniquely-named feature branch and has no merge conflicts 📁
• [x] screenshots/GIFs are attached 📎 in case of UI updation
• [x] ask @publiclab/reviewers for help, in a comment below

[welcome[bot]]

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. Dangerbot will test out your code and reply in a bit with some pointers and requests. Also please refer here for installation help 💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌
Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

[gitpod-io[bot]]

[Dhei-vid]

@cesswairimu I have opened a pull request for the task. Please check and confirm. Thank you.

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8817247861/artifacts/401347212

[codecov[bot]]

Codecov Report

Merging #11505 (1a9a313) into main (21dfe4c) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Additional details and impacted files

[](https://codecov.io/gh/publiclab/plots2/pull/11505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) ```diff @@ Coverage Diff @@ ## main #11505 +/- ## ========================================== - Coverage 83.33% 83.31% -0.02% ========================================== Files 93 93 Lines 5772 5773 +1 ========================================== Hits 4810 4810 - Misses 962 963 +1 ``` | [Impacted Files](https://codecov.io/gh/publiclab/plots2/pull/11505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) | Coverage Δ | | |---|---|---| | [app/controllers/relationships\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL3JlbGF0aW9uc2hpcHNfY29udHJvbGxlci5yYg==) | `71.42% <100.00%> (ø)` | | | [app/models/user.rb](https://codecov.io/gh/publiclab/plots2/pull/11505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL21vZGVscy91c2VyLnJi) | `86.23% <0.00%> (-0.27%)` | :arrow_down: | | [app/controllers/home\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL2hvbWVfY29udHJvbGxlci5yYg==) | `95.58% <0.00%> (-0.07%)` | :arrow_down: | | [app/channels/user\_channel.rb](https://codecov.io/gh/publiclab/plots2/pull/11505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NoYW5uZWxzL3VzZXJfY2hhbm5lbC5yYg==) | `83.33% <0.00%> (ø)` | | | [app/controllers/notes\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL25vdGVzX2NvbnRyb2xsZXIucmI=) | `85.76% <0.00%> (ø)` | |

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8859208127/artifacts/404315930

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8859970939/artifacts/404367091

[codeclimate[bot]]

Code Climate has analyzed commit 1a9a3139 and detected 0 issues on this pull request.

View more on Code Climate.

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8860197559/artifacts/404383411

[Dhei-vid]

Hello @cesswairimu, I have completed the task could you check and verify. Thanks

[TildaDares]

Hi @Dhei-vid, can you add a link to the issue?

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example)

[welcome[bot]]

Congrats on merging your first pull request! 🙌🎉⚡️ Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well! Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝 Now that you've completed this, you can help someone else take their first step! Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors :inbox_tray:

[Dhei-vid]

Looking great 🎉 Thanks for working on this @Dhei-vid . I've updated the issue number on the description. Kindly update the issue number in future pull requests where we have Fixes #0000 as Tilda mentioned. It helps when reviewing and to auto close the issue once merged.

Noted. Thank you @cesswairimu @TildaDares