search

publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Update editor_controller.rb #11507

Closed AlphaRomeoMike closed 2 years ago

AlphaRomeoMike commented 2 years ago

Removed 'and', replaced the logic with double ampersand

Fixes #11502 πŸŽ‰πŸΎ

welcome[bot] commented 2 years ago

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. Dangerbot will test out your code and reply in a bit with some pointers and requests. Also please refer here for installation help πŸ’Ώ There may be some errors, but don't worry! We'll work through them with you! πŸ‘πŸŽ‰πŸ˜„
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! πŸ™Œ
Then, you can say hello in our chatroom & share a link to this PR to get a review! πŸ‘‹ βœ…

gitpod-io[bot] commented 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #11507 (6b0efce) into main (a5d2483) will not change coverage. The diff coverage is 25.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/publiclab/plots2/pull/11507/graphs/tree.svg?width=650&height=150&src=pr&token=FahMFdiDeF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab)](https://codecov.io/gh/publiclab/plots2/pull/11507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) ```diff @@ Coverage Diff @@ ## main #11507 +/- ## ======================================= Coverage 83.33% 83.33% ======================================= Files 93 93 Lines 5772 5772 ======================================= Hits 4810 4810 Misses 962 962 ``` | [Impacted Files](https://codecov.io/gh/publiclab/plots2/pull/11507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) | Coverage Ξ” | | |---|---|---| | [app/controllers/editor\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL2VkaXRvcl9jb250cm9sbGVyLnJi) | `76.74% <25.00%> (ΓΈ)` | | | [app/models/user.rb](https://codecov.io/gh/publiclab/plots2/pull/11507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL21vZGVscy91c2VyLnJi) | `86.23% <0.00%> (-0.27%)` | :arrow_down: | | [app/controllers/home\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL2hvbWVfY29udHJvbGxlci5yYg==) | `95.58% <0.00%> (-0.07%)` | :arrow_down: | | [app/controllers/relationships\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL3JlbGF0aW9uc2hpcHNfY29udHJvbGxlci5yYg==) | `71.42% <0.00%> (ΓΈ)` | | | [app/controllers/spam2\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL3NwYW0yX2NvbnRyb2xsZXIucmI=) | `72.54% <0.00%> (+0.70%)` | :arrow_up: |
IvyJeptoo commented 2 years ago

@AlphaRomeoMike can I help you out with the tests?

AlphaRomeoMike commented 2 years ago

@AlphaRomeoMike can I help you out with the tests?

Yes please

IvyJeptoo commented 2 years ago

@AlphaRomeoMike can I help you out with the tests?

Yes please

maybe you could send me a chat on the communication platform my username is briesta so that we can hop into a meet

AlphaRomeoMike commented 2 years ago

@AlphaRomeoMike can I help you out with the tests?

Yes please

maybe you could send me a chat on the communication platform my username is briesta so that we can hop into a meet

I dont think I will be able to because of my busy schedule

IvyJeptoo commented 2 years ago

@AlphaRomeoMike can I help you out with the tests?

Yes please

maybe you could send me a chat on the communication platform my username is briesta so that we can hop into a meet

I dont think I will be able to because of my busy schedule

How do you suggest I help you?

AlphaRomeoMike commented 2 years ago

@AlphaRomeoMike can I help you out with the tests?

Yes please

maybe you could send me a chat on the communication platform my username is briesta so that we can hop into a meet

I dont think I will be able to because of my busy schedule

How do you suggest I help you?

Balaclava_Nerd#6566 on Discord

IvyJeptoo commented 2 years ago

@AlphaRomeoMike can I help you out with the tests?

Yes please

maybe you could send me a chat on the communication platform my username is briesta so that we can hop into a meet

I dont think I will be able to because of my busy schedule

How do you suggest I help you?

Balaclava_Nerd#6566 on Discord

Great, sent!(Ivy J)

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 6b0efce5 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 3

View more on Code Climate.

github-actions[bot] commented 2 years ago

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8942803689/artifacts/410443645

cesswairimu commented 2 years ago

Looking great, thanks all, merging now.

@IvyJeptoo @AlphaRomeoMike would any of you like to open an issue and fix the code-climate warnings raised here? you can find the suggestions here https://codeclimate.com/github/publiclab/plots2/pull/11507, Its similar changes @TildaDares mentioned above.

welcome[bot] commented 2 years ago

Congrats on merging your first pull request! πŸ™ŒπŸŽ‰βš‘οΈ Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well! Do join our weekly check-in to share your this week goal and the awesome work you did πŸ˜ƒ. Please find the link to our latest check-in here πŸ“ Now that you've completed this, you can help someone else take their first step! Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. πŸ™Œ

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! πŸ˜•

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! πŸ˜„ πŸŽ‰

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors :inbox_tray: