Closed IvyJeptoo closed 2 years ago
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8827993737/artifacts/402138128
Merging #11508 (a503ab5) into main (a5d2483) will not change coverage. The diff coverage is
100.00%
.
Code Climate has analyzed commit a503ab58 and detected 0 issues on this pull request.
View more on Code Climate.
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8831323277/artifacts/402359245
@IvyJeptoo the changes are looking good but it seems you created the pull request from your
main
branch: please create a new branch and create a pull request from there -- this can be a good reference if you not familiar with branching -- it may be easier to refork the repo ?-- feel free ping me if you need any help. Also please exclude the changes from issue #11490 . thanks
Thannk you for the feedback @cesswairimu working on the changes.
Fixes #11492 Fixes #11490
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below