publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Update batch_controller.rb #11508

Closed IvyJeptoo closed 2 years ago

IvyJeptoo commented 2 years ago

Fixes #11492 Fixes #11490

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

gitpod-io[bot] commented 2 years ago

github-actions[bot] commented 2 years ago

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8827993737/artifacts/402138128

codecov[bot] commented 2 years ago

Codecov Report

Merging #11508 (a503ab5) into main (a5d2483) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/publiclab/plots2/pull/11508/graphs/tree.svg?width=650&height=150&src=pr&token=FahMFdiDeF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab)](https://codecov.io/gh/publiclab/plots2/pull/11508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) ```diff @@ Coverage Diff @@ ## main #11508 +/- ## ======================================= Coverage 83.33% 83.33% ======================================= Files 93 93 Lines 5772 5772 ======================================= Hits 4810 4810 Misses 962 962 ``` | [Impacted Files](https://codecov.io/gh/publiclab/plots2/pull/11508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) | Coverage Ξ” | | |---|---|---| | [app/controllers/batch\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL2JhdGNoX2NvbnRyb2xsZXIucmI=) | `90.19% <100.00%> (ΓΈ)` | | | [app/controllers/subscription\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL3N1YnNjcmlwdGlvbl9jb250cm9sbGVyLnJi) | `76.00% <100.00%> (ΓΈ)` | |
codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit a503ab58 and detected 0 issues on this pull request.

View more on Code Climate.

github-actions[bot] commented 2 years ago

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8831323277/artifacts/402359245

IvyJeptoo commented 2 years ago

@IvyJeptoo the changes are looking good but it seems you created the pull request from your main branch: please create a new branch and create a pull request from there -- this can be a good reference if you not familiar with branching -- it may be easier to refork the repo ?-- feel free ping me if you need any help. Also please exclude the changes from issue #11490 . thanks

Thannk you for the feedback @cesswairimu working on the changes.