publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Make changes to #11499 issue #11510

Closed Dorcas-BD closed 2 years ago

Dorcas-BD commented 2 years ago

Fixes #11499 #11503

gitpod-io[bot] commented 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #11510 (7b9e2a2) into main (a5d2483) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/publiclab/plots2/pull/11510/graphs/tree.svg?width=650&height=150&src=pr&token=FahMFdiDeF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab)](https://codecov.io/gh/publiclab/plots2/pull/11510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) ```diff @@ Coverage Diff @@ ## main #11510 +/- ## ========================================== - Coverage 83.33% 83.33% -0.01% ========================================== Files 93 93 Lines 5772 5771 -1 ========================================== - Hits 4810 4809 -1 Misses 962 962 ``` | [Impacted Files](https://codecov.io/gh/publiclab/plots2/pull/11510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) | Coverage Δ | | |---|---|---| | [app/controllers/home\_controller.rb](https://codecov.io/gh/publiclab/plots2/pull/11510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2NvbnRyb2xsZXJzL2hvbWVfY29udHJvbGxlci5yYg==) | `95.58% <100.00%> (-0.07%)` | :arrow_down: |
github-actions[bot] commented 2 years ago

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8835310920/artifacts/402622526

Dorcas-BD commented 2 years ago

Hello @cesswairimu, I have made the necessary changes. Please kindly review it.

welcome[bot] commented 2 years ago

Congrats on merging your first pull request! 🙌🎉⚡️ Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well! Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝 Now that you've completed this, you can help someone else take their first step! Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors :inbox_tray: