Closed JulianaSau closed 2 years ago
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot
will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help πΏ
There may be some errors, but don't worry! We'll work through them with you! πππ
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000
(for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! π
Then, you can say hello in our chatroom & share a link to this PR to get a review! π β
Code Climate has analyzed commit 47261388 and detected 0 issues on this pull request.
View more on Code Climate.
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8836943984/artifacts/402733778
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8836943984/artifacts/403818199
Congrats on merging your first pull request! ππβ‘οΈ Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well! Do join our weekly check-in to share your this week goal and the awesome work you did π. Please find the link to our latest check-in here π Now that you've completed this, you can help someone else take their first step! Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!
Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. π
Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! π
People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! π π
Read about how to help support another newcomer here, or find other ways to offer mutual support here.
You can also join our Gitter channel to connect with other contributors :inbox_tray:
Congratulations on merging your PR @JulianaSau π
Congratulations on merging your PR @JulianaSau π
Thank you. I'm happy to be a contributor to this projectπ
Replaced the var keyword with let/const depending on the context
Fixes #11481
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below