publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Fix "`IgnoredMethods` has been renamed to `AllowedMethods` and/or `AllowedPatterns`" rubocop warning #11527

Closed first-timers[bot] closed 2 years ago

first-timers[bot] commented 2 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barrier for new contributors. This issue is for you πŸ’

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -64,7 +64,7 @@ Style/BlockDelimiters:
   - let!
   - subject
   - watch
-  IgnoredMethods:
+  AllowedMethods:
   - lambda
   - proc
   - it
@@ -415,7 +415,7 @@ Layout/SpaceInsideStringInterpolation:
   - no_space

 Style/SymbolProc:
-  IgnoredMethods:
+  AllowedMethods:
   - respond_to
   - define_method
  1. If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.

  2. If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.

  3. You can also edit files directly in your browser and open a pull request from there.

Please keep us updated

πŸ’¬β° - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

πŸ”—- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

πŸ‘₯- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

πŸ€”β“ Questions?

Leave a comment below, and reach out in our chatroom!

cesswairimu commented 2 years ago

Reserved for Nadifa Hersi

NadifaHersi commented 2 years ago

Hi @TildaDares @cesswairimu I would like to try this issue. Thank you so much.

cesswairimu commented 2 years ago

go ahead @NadifaHersi

NadifaHersi commented 2 years ago

Hi @TildaDares @cesswairimu @jywarren I have fixed issue #11527 and created pull request #11533 .

NadifaHersi commented 2 years ago

HI Cess I have fixed issue #11527 https://github.com/publiclab/plots2/issues/11527 and created pull request

11533 https://github.com/publiclab/plots2/pull/11533 .

Please if I can get any feedback. Thank you so mucho

On Sat, Oct 22, 2022 at 2:24 PM Cess @.***> wrote:

go ahead @NadifaHersi https://github.com/NadifaHersi

β€” Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/11527#issuecomment-1287764957, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3U4N3FXPUJLQSHKBUSQ3EDWEPFGRANCNFSM6AAAAAARLE6ZAE . You are receiving this because you were mentioned.Message ID: @.***>

cesswairimu commented 2 years ago

Resolved in https://github.com/publiclab/plots2/pull/11533. thanks @NadifaHersi

NadifaHersi commented 2 years ago

HI @TildaDares, @jywarren , @cesswairimu , What is the next activity?

NadifaHersi commented 2 years ago

Hi @TildaDares , @jywarren , @cesswairimu I would like to get some clarifications on this comment during submission of the application:

NadifaHersi commented 2 years ago

Hi @TildaDares , @jywarren , @cesswairimu I would like to get some clarifications on this comment during submission of the application: Please work with your mentor to provide a timeline of the work you plan to accomplish on the project and what tasks you will finish at each step