search

publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Bump rubocop from 1.33.0 to 1.45.1 #11610

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps rubocop from 1.33.0 to 1.45.1.

Release notes

Sourced from rubocop's releases.

RuboCop 1.45.1

Bug fixes

  • #11552: Fix a false positive for Lint/Debugger when methods containing different method chains. (@​ydah)
  • #11548: Fix an error for Style/AccessModifierDeclarations when if a non method definition was included. (@​ydah)
  • #11554: Fix an error for Style/RedundantCondition when the branches contains empty hash literal argument. (@​koic)
  • #11549: Fix an error for third party cops when inheriting RuboCop::Cop::Cop. (@​koic)

RuboCop 1.45

New features

  • #10839: Add API for 3rd party template support. (@​r7kamura)
  • #11528: Add new Style/RedundantHeredocDelimiterQuotes cop. (@​koic)
  • #11188: Add a --no-detach option for --start-server. This will start the server process in the foreground, which can be helpful when running within Docker where detaching the process terminates the container. (@​f1sherman)
  • #11546: Make Lint/UselessAccessModifier aware of Ruby 3.2's Data.define. (@​koic)
  • #11396: Add ability to profile rubocop execution via --profile and --memory options. ([@​fatkodima][])

Bug fixes

  • #11491: Fix a crash on Lint/UselessAssignment. ([@​gsamokovarov][])
  • #11515: Fix a false negative for Naming/HeredocDelimiterNaming when using lowercase. (@​koic)
  • #11511: Fix a false negative for Style/YodaCondition when using constant. (@​koic)
  • #11520: Fix a false negative for Style/YodaExpression when using constant. (@​koic)
  • #11521: Fix a false positive for Lint/FormatParameterMismatch when using Kernel.format with the interpolated number of decimal places fields match. (@​koic)
  • #11545: Fix the following false positive for Lint/NestedMethodDefinition when using numbered parameter. (@​koic)
  • #11535: Fix a false positive for Style/NumberedParametersLimit when only _2 or higher numbered parameter is used. (@​koic)
  • #11508: Fix a false positive for Style/OperatorMethodCall when using multiple arguments for operator method. (@​koic)
  • #11503: Fix a false positive for Style/RedundantCondition when using method argument with operator. (@​koic)
  • #11529: Fix an incorrect autocorrect for Layout/ClassStructure when definitions that need to be sorted are defined alternately. (@​ydah)
  • #11530: Fix an incorrect autocorrect for Style/AccessModifierDeclarations when multiple groupable access modifiers are defined. (@​ydah)
  • #10910: Fix an incorrect autocorrect for Style/MultilineTernaryOperator when contains a comment. (@​ydah)
  • #11522: Don't flag default keyword arguments in Style/ArgumentsForwarding. ([@​splattael][])
  • #11547: Fix a false positive for Lint/NestedMethodDefinition when using Ruby 3.2's Data.define. (@​koic)
  • #11537: Fix an infinite loop error for Layout/ArrayAlignment when using assigning unbracketed array elements. (@​koic)
  • #11516: Fix missing parentheses in shorthand hash syntax as argument calls. ([@​gsamokovarov][])

Changes

  • #11504: Allow initialize method in Style/DocumentationMethod. (@​koic)
  • #11541: Enable autocorrection for Layout/LineContinuationLeadingSpace. ([@​eugeneius][])
  • #11542: Mark Layout/AssignmentIndentation as safe and Lint/AssignmentInCondition as unsafe for autocorrection. ([@​eugeneius][])
  • #11517: Make Lint/Debugger aware of p, PP.pp, and pp methods. (@​koic)
  • #11539: Remove bundler from default AllowedGems of Gemspec/DevelopmentDependencies. (@​koic)

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.45.1 (2023-02-08)

Bug fixes

  • #11552: Fix a false positive for Lint/Debugger when methods containing different method chains. ([@​ydah][])
  • #11548: Fix an error for Style/AccessModifierDeclarations when if a non method definition was included. ([@​ydah][])
  • #11554: Fix an error for Style/RedundantCondition when the branches contains empty hash literal argument. ([@​koic][])
  • #11549: Fix an error for third party cops when inheriting RuboCop::Cop::Cop. ([@​koic][])

1.45.0 (2023-02-08)

New features

  • #10839: Add API for 3rd party template support. ([@​r7kamura][])
  • #11528: Add new Style/RedundantHeredocDelimiterQuotes cop. ([@​koic][])
  • #11188: Add a --no-detach option for --start-server. This will start the server process in the foreground, which can be helpful when running within Docker where detaching the process terminates the container. ([@​f1sherman][])
  • #11546: Make Lint/UselessAccessModifier aware of Ruby 3.2's Data.define. ([@​koic][])
  • #11396: Add ability to profile rubocop execution via --profile and --memory options. ([@​fatkodima][])

Bug fixes

  • #11491: Fix a crash on Lint/UselessAssignment. ([@​gsamokovarov][])
  • #11515: Fix a false negative for Naming/HeredocDelimiterNaming when using lowercase. ([@​koic][])
  • #11511: Fix a false negative for Style/YodaCondition when using constant. ([@​koic][])
  • #11520: Fix a false negative for Style/YodaExpression when using constant. ([@​koic][])
  • #11521: Fix a false positive for Lint/FormatParameterMismatch when using Kernel.format with the interpolated number of decimal places fields match. ([@​koic][])
  • #11545: Fix the following false positive for Lint/NestedMethodDefinition when using numbered parameter. ([@​koic][])
  • #11535: Fix a false positive for Style/NumberedParametersLimit when only _2 or higher numbered parameter is used. ([@​koic][])
  • #11508: Fix a false positive for Style/OperatorMethodCall when using multiple arguments for operator method. ([@​koic][])
  • #11503: Fix a false positive for Style/RedundantCondition when using method argument with operator. ([@​koic][])
  • #11529: Fix an incorrect autocorrect for Layout/ClassStructure when definitions that need to be sorted are defined alternately. ([@​ydah][])
  • #11530: Fix an incorrect autocorrect for Style/AccessModifierDeclarations when multiple groupable access modifiers are defined. ([@​ydah][])
  • #10910: Fix an incorrect autocorrect for Style/MultilineTernaryOperator when contains a comment. ([@​ydah][])
  • #11522: Don't flag default keyword arguments in Style/ArgumentsForwarding. ([@​splattael][])
  • #11547: Fix a false positive for Lint/NestedMethodDefinition when using Ruby 3.2's Data.define. ([@​koic][])
  • #11537: Fix an infinite loop error for Layout/ArrayAlignment when using assigning unbracketed array elements. ([@​koic][])
  • #11516: Fix missing parentheses in shorthand hash syntax as argument calls. ([@​gsamokovarov][])

Changes

  • #11504: Allow initialize method in Style/DocumentationMethod. ([@​koic][])
  • #11541: Enable autocorrection for Layout/LineContinuationLeadingSpace. ([@​eugeneius][])
  • #11542: Mark Layout/AssignmentIndentation as safe and Lint/AssignmentInCondition as unsafe for autocorrection. ([@​eugeneius][])
  • #11517: Make Lint/Debugger aware of p, PP.pp, and pp methods. ([@​koic][])
  • #11539: Remove bundler from default AllowedGems of Gemspec/DevelopmentDependencies. ([@​koic][])

1.44.1 (2023-01-25)

Bug fixes

... (truncated)

Commits
  • b0f8575 Cut 1.45.1
  • c3f9516 Update Changelog
  • c4ee09c Fix an error for Style/AccessModifierDeclarations when if a non method defi...
  • 2404946 CI against JRuby 9.4 instead of JRuby 9.3
  • 2989584 Fix a false positive for Lint/Debugger when methods containing different me...
  • cdfc397 Restore a pending test for processing a regex with regopt
  • dca9221 [Fix #11554] Fix an error for Style/RedundantCondition
  • 4ec3822 [Fix #11549] Fix an error for third party cops
  • b1b393a Switch back the docs version
  • 170d244 Cut 1.45
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit aca51450 and detected 0 issues on this pull request.

View more on Code Climate.

github-actions[bot] commented 1 year ago

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/10885721321/artifacts/549442571

codecov[bot] commented 1 year ago

Codecov Report

Merging #11610 (aca5145) into main (5e1d8c2) will decrease coverage by 0.13%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/publiclab/plots2/pull/11610/graphs/tree.svg?width=650&height=150&src=pr&token=FahMFdiDeF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab)](https://codecov.io/gh/publiclab/plots2/pull/11610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) ```diff @@ Coverage Diff @@ ## main #11610 +/- ## ========================================== - Coverage 83.33% 83.21% -0.13% ========================================== Files 93 93 Lines 5772 5772 ========================================== - Hits 4810 4803 -7 - Misses 962 969 +7 ``` | [Impacted Files](https://codecov.io/gh/publiclab/plots2/pull/11610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab) | Coverage Δ | | |---|---|---| | [app/services/execute\_search.rb](https://codecov.io/gh/publiclab/plots2/pull/11610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL3NlcnZpY2VzL2V4ZWN1dGVfc2VhcmNoLnJi) | `88.88% <0.00%> (-5.56%)` | :arrow_down: | | [app/api/srch/search.rb](https://codecov.io/gh/publiclab/plots2/pull/11610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=publiclab#diff-YXBwL2FwaS9zcmNoL3NlYXJjaC5yYg==) | `66.66% <0.00%> (-3.85%)` | :arrow_down: |
dependabot[bot] commented 1 year ago

Superseded by #11615.