Improve results of users search

first-timers[bot] commented 6 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

This issue will help address #1823, as submitted by @shanlter. Thanks!!!

📋 Step by Step

[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] 📝 Update the file app/services/search_service.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below. See this page for some help in taking your first steps!

@@ -32,10 +32,11 @@ def comments
     @comments ||= find_comments(params)
   end

-  def find_users(input, limit = 5)
-    DrupalUser.limit(limit)
-               .order('uid DESC')
-               .where('name LIKE ? AND access != 0', '%' + input + '%')
+  def find_users(input, limit = 10)
+    User.limit(limit)
+        .order('id DESC')
+        .where(status: 1)
+        .where('username LIKE ?', '%' + input + '%')
   end

   def find_tags(input, limit = 5)

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

kkavita92 commented 6 years ago

I can jump in 👍

jywarren commented 6 years ago

That'd be great!!! Thanks and we're here to help!

On Dec 7, 2017 11:36 AM, "Kavita Kalaichelvan" notifications@github.com wrote:

I can jump in 👍

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1829#issuecomment-350022533, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ3gPcOehaDLyRLDuNOSinP3GwloCks5s-BPcgaJpZM4Q5tk4 .

jywarren commented 6 years ago

Oops, i found a mistake and corrected it above! uid DESC should've been changed to id DESC for the User model. This is because of kind of silly old conventions which we're trying to get rid of in favor of a more standardized approach -- so, apologies! Out with uid and in with id!

Good luck and please reach out if you need pointers. Opening a pull request with your new code also lets us quickly chime in on any issues -- and we have a bot that offers some feedback on PRs as well!

Thanks again!

kkavita92 commented 6 years ago

Great. I'll work on it over the weekend and have a PR for you.

GulfOfAlaska commented 6 years ago

Hi, I'm new here. Pulled the project but I'm running into a error when i try rake db:setup. Getting an error message:

rake aborted! SystemStackError: stack level too deep plots2/config/environment.rb:5:in '<top (required)>'

.rbenv/versions/2.4.1/bin/bundle:22:in 'load' .rbenv/versions/2.4.1/bin/bundle:22:in 'main'

Am I doing something wrong here?

jywarren commented 6 years ago

Oh hmm, that is odd, but we just did a big set of upgrades and I think there's something funny going on. Thanks for catching this! Can you share the output of "gem list"? And note what version of Ruby you're using (ruby -v)?

To share a big file output you can use gist.github.com

Tnx!

On Dec 9, 2017 3:14 AM, "Sng Ping Chiang" notifications@github.com wrote:

Hi, I'm new here. Pulled the project but I'm running into a error when i try rake db:setup. Getting an error message:

rake aborted! SystemStackError: stack level too deep ... plots2/config/environment.rb:5:in <top (required)>' ... /.rbenv/versions/2.4.1/bin/bundle:22:inload' ... /.rbenv/versions/2.4.1/bin/bundle:22:in ` '

Am I doing something wrong here?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1829#issuecomment-350431884, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ1af7jt8C59Oc29_VRLa0ECIvy_Zks5s-kEsgaJpZM4Q5tk4 .

GulfOfAlaska commented 6 years ago

Ruby version is ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin16] gem list gives me this:

https://gist.github.com/spclight/236881d91ebe2fe579d6677c5fd952de

Sorry about this!

jywarren commented 6 years ago

Hmm, are you using RVM, and is it possible to switch to Ruby 2.3.3 to see if the error goes away?

Thanks so much for helping with this!

On Sat, Dec 9, 2017 at 1:28 PM, Sng Ping Chiang notifications@github.com wrote:

ruby version is ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin16] gem list gives me this:

actioncable (5.1.4, 5.0.6, 5.0.4) actionmailer (5.1.4, 5.0.6, 5.0.4, 4.1.16) actionpack (5.1.4, 5.0.6, 5.0.4, 4.1.16) actionview (5.1.4, 5.0.6, 5.0.4, 4.1.16) active_link_to (1.0.4) active_model_serializers (0.10.6) activeadmin (1.1.0) activejob (5.1.4, 5.0.6, 5.0.4) activemodel (5.1.4, 5.0.6, 5.0.4, 4.1.16) activerecord (5.1.4, 5.0.6, 5.0.4, 4.1.16) activerecord-session_store (1.1.0) activesupport (5.1.4, 5.0.6, 5.0.4, 4.1.16) addressable (2.5.2, 2.5.1) ansi (1.5.0) arbre (1.1.1) archive-zip (0.7.0) arel (8.0.0, 7.1.4, 5.0.1.20140414130214) ast (2.3.0) authlogic (3.5.0) authlogic-oid (1.0.4) aws-sdk (2.10.17) aws-sdk-core (2.10.17) aws-sdk-resources (2.10.17) aws-sigv4 (1.0.1) axiom-types (0.1.1) bcrypt (3.1.11) better_errors (2.1.1) bigdecimal (default: 1.3.0) bindex (0.5.0) binding_of_caller (0.7.2) buftok (0.2.0) builder (3.2.3) bundler (1.16.0) byebug (9.1.0, 9.0.6) capybara (2.15.1) case_transform (0.2) chartkick (2.2.4) childprocess (0.7.1) chromedriver-helper (1.1.0) ci_reporter (2.0.0) ci_reporter_test_unit (1.0.1) climate_control (0.2.0) cocaine (0.5.8) cocoon (1.2.10) coderay (1.1.1) coercible (1.0.0) coffee-rails (4.2.2, 4.0.1) coffee-script (2.4.1) coffee-script-source (1.12.2) commonjs (0.2.7) composite_primary_keys (7.0.16) concurrent-ruby (1.0.5) connection_pool (2.2.1) countries (2.0.8) country_select (3.1.0) coveralls (0.8.21) crass (1.0.3) date_validator (0.9.0) debug_inspector (0.0.3) declarative (0.0.9) declarative-option (0.1.0) descendants_tracker (0.0.4) devise (4.3.0) devise_invitable (1.7.2) did_you_mean (1.1.0) diff-lcs (1.3) docile (1.1.5) domain_name (0.5.20170404) down (4.0.1) equalizer (0.0.11) erubi (1.7.0) erubis (2.7.0) et-orbi (1.0.5) exception_notification (4.2.1) excon (0.57.1) execjs (2.7.0) factory_girl (4.8.0) factory_girl_rails (4.8.0) faraday (0.13.1, 0.11.0) ffi (1.9.18) ffi-compiler (1.0.1) figaro (1.1.1) filterrific (2.1.2) formtastic (3.1.5) formtastic_i18n (0.6.0) friendly_id (5.2.3) geocoder (1.4.5, 1.4.4) geokit (1.11.0) geokit-rails (2.3.0) georuby (2.0.0) globalid (0.4.1, 0.4.0) google-api-client (0.13.1) google-cloud-core (1.0.0) google-cloud-env (1.0.1) google-cloud-language (0.27.0) google-cloud-vision (0.25.0) google-gax (0.8.5) google-protobuf (3.3.0 universal-darwin) googleapis-common-protos (1.3.5) googleauth (0.5.1) grape (0.19.1) grape-entity (0.6.0) grape-swagger (0.25.3) grape-swagger-entity (0.1.5) grape-swagger-rails (0.3.0) grape-swagger-ui (2.2.8) groupdate (3.2.0) grpc (1.4.1 universal-darwin) has_scope (0.7.1) hashie (3.5.6) headless (2.3.1) highline (1.7.10) hike (1.2.3) hiredis (0.6.1) http (2.2.2) http-cookie (1.0.3) http-form_data (1.0.3) http_accept_language (2.1.1) http_parser.rb (0.6.0) httpclient (2.8.3) i18n (0.9.1, 0.8.6) i18n-js (3.0.2) i18n_data (0.7.0) ice_nine (0.11.2) image_processing (0.4.4) impressionist (1.6.0) inherited_resources (1.7.2) io-console (default: 0.4.6) io-like (0.3.0) jasmine-core (2.8.0) jasmine-jquery-rails (2.0.3) jasmine-rails (0.14.7) jbuilder (2.7.0, 2.6.4) jmespath (1.3.1) jquery-rails (4.3.1, 3.1.4) json (default: 2.0.2, 1.8.6) json_expressions (0.9.0) jsonapi-renderer (0.1.3) jwt (1.5.6) kaminari (1.0.1) kaminari-actionview (1.0.1) kaminari-activerecord (1.0.1) kaminari-core (1.0.1) koala (3.0.0) launchy (2.4.3) less (2.6.0) less-rails (2.8.0) letter_opener (1.4.1) libv8 (3.16.14.19 x86_64-darwin-16) listen (3.1.5, 3.0.8) little-plugger (1.1.4) logging (2.2.2) loofah (2.1.1, 2.0.3) mail (2.7.0, 2.6.6) mandrill-api (1.0.53) materialize-sass (0.98.2, 0.97.8) memoist (0.16.0) memoizable (0.4.2) metaclass (0.0.4) method_source (0.9.0, 0.8.2) mime-types (3.1) mime-types-data (3.2016.0521) mini_magick (4.8.0) mini_mime (1.0.0, 0.1.4) mini_portile2 (2.3.0, 2.1.0) minitest (5.10.3, 5.10.1) minitest-reporters (1.1.19) mocha (1.3.0) monetize (1.6.0) money (6.8.4) money-rails (1.8.0) multi_json (1.12.2, 1.12.1) multi_xml (0.6.0) multipart-post (2.0.0) mustermann (0.4.0) mustermann-grape (0.4.0) mysql2 (0.3.21) naught (1.1.0) net-telnet (0.1.1) netrc (0.11.0) nifty-generators (0.4.6) nio4r (2.1.0) nokogiri (1.8.1, 1.7.2) oauth (0.5.3) oauth2 (1.4.0) omniauth (1.6.1) omniauth-facebook (4.0.0) omniauth-oauth2 (1.4.0) openssl (default: 2.0.3) options (2.3.2) orm_adapter (0.5.0) os (0.9.6) paperclip (4.1.1) parallel (1.12.0) parser (2.4.0.2) passenger (5.1.12) pg (0.21.0) phantomjs (2.1.1.0) php-serialize (1.2.0) polyamorous (1.3.1) power_assert (1.1.1, 0.4.1) powerpack (0.1.1) pr_geohash (1.0.0) progress_bar (1.1.0) protected_attributes (1.1.4) psych (default: 2.2.2) public_suffix (3.0.1, 2.0.5) puma (3.11.0, 3.9.1) pundit (1.1.0) rack (2.0.3, 1.5.5) rack-accept (0.4.5) rack-cors (1.0.2) rack-openid (1.4.2) rack-protection (2.0.0) rack-test (0.8.2, 0.6.3) rails (5.1.4, 5.0.6, 5.0.4, 4.1.16) rails-dom-testing (2.0.3) rails-html-sanitizer (1.0.3) rails-i18n (4.0.9) rails-perftest (0.0.7) rails_autolink (1.1.6) railties (5.1.4, 5.0.6, 5.0.4, 4.1.16) rainbow (2.2.2) rake (12.3.0, 12.0.0, 10.5.0) ransack (1.8.3) rb-fsevent (0.10.2) rb-inotify (0.9.10) rb-readline (0.5.5) rdiscount (2.2.0.1) rdoc (default: 5.0.0) recaptcha (4.6.2) redis (3.3.3) redis-actionpack (5.0.1) redis-activesupport (5.0.3) redis-namespace (1.5.3) redis-rack (2.0.2) redis-rails (5.0.2) redis-store (1.3.0) ref (2.0.0) representable (3.0.4) request_store (1.3.2) responders (2.4.0) rest-client (2.0.2) retriable (3.0.2) rly (0.2.3) roda (2.28.0) rsolr (2.1.0) rspec (3.7.0) rspec-core (3.7.0, 3.6.0) rspec-expectations (3.7.0, 3.6.0) rspec-mocks (3.7.0, 3.6.0) rspec-rails (3.6.0) rspec-support (3.7.0, 3.6.0) rubocop (0.51.0) ruby-openid (2.7.0) ruby-progressbar (1.9.0) ruby_dep (1.5.0) rubyzip (1.2.1) rufus-scheduler (3.4.2) sass (3.5.3, 3.5.1, 3.2.19) sass-listen (4.0.0) sass-rails (5.0.7, 5.0.6, 4.0.5) scrypt (3.0.5) selenium-webdriver (3.5.1) shrine (2.6.1) shrine-memory (0.3.0) sidekiq (5.0.4) sidekiq-cron (0.4.5) sidekiq-limit_fetch (3.4.0) signet (0.7.3) simple_form (3.5.0) simple_oauth (0.3.1) simplecov (0.14.1) simplecov-html (0.10.2) sixarm_ruby_unaccent (1.1.2) slack-notifier (2.2.2) sort_alphabetical (1.1.0) spring (2.0.2) spring-commands-rspec (1.0.4) spring-watcher-listen (2.0.1) sprockets (3.7.1, 2.12.4) sprockets-rails (3.2.1, 3.2.0, 2.3.3) sqlite3 (1.3.13) sunspot (2.2.7) sunspot_rails (2.2.7) term-ansicolor (1.6.0) test-unit (3.2.6, 3.2.3) therubyracer (0.12.3) thor (0.20.0, 0.19.4) thread_safe (0.3.6) tilt (2.0.8, 1.4.1) timecop (0.9.1) tins (1.16.3, 1.15.1) tool (0.2.3) turbolinks (5.0.1) turbolinks-source (5.0.3) twitter (6.1.0) twitter-text (1.14.7) tzinfo (1.2.4, 1.2.3) uber (0.1.0) uglifier (4.0.1, 3.2.0) unf (0.1.4) unf_ext (0.0.7.4) unicode-display_width (1.3.0) unicode_utils (1.4.0) upsert (2.2.1) virtus (1.0.5) warden (1.2.7) web-console (3.5.1) websocket-driver (0.6.5) websocket-extensions (0.1.3, 0.1.2) whiny_validation (0.1.1) will_paginate (3.1.6) will_paginate-bootstrap (1.0.1) xmlrpc (0.2.1) xpath (2.1.0)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1829#issuecomment-350496189, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJyvjPDU3GUXm9lnph-s5G1LUqq7Rks5s-tFPgaJpZM4Q5tk4 .

ryzokuken commented 6 years ago

No, I think they're using Rbenv. I think it works differently.

On Sun 10 Dec, 2017, 12:46 AM Jeffrey Warren, notifications@github.com wrote:

Hmm, are you using RVM, and is it possible to switch to Ruby 2.3.3 to see if the error goes away?

Thanks so much for helping with this!

On Sat, Dec 9, 2017 at 1:28 PM, Sng Ping Chiang notifications@github.com wrote:

ruby version is ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin16] gem list gives me this:

actioncable (5.1.4, 5.0.6, 5.0.4) actionmailer (5.1.4, 5.0.6, 5.0.4, 4.1.16) actionpack (5.1.4, 5.0.6, 5.0.4, 4.1.16) actionview (5.1.4, 5.0.6, 5.0.4, 4.1.16) active_link_to (1.0.4) active_model_serializers (0.10.6) activeadmin (1.1.0) activejob (5.1.4, 5.0.6, 5.0.4) activemodel (5.1.4, 5.0.6, 5.0.4, 4.1.16) activerecord (5.1.4, 5.0.6, 5.0.4, 4.1.16) activerecord-session_store (1.1.0) activesupport (5.1.4, 5.0.6, 5.0.4, 4.1.16) addressable (2.5.2, 2.5.1) ansi (1.5.0) arbre (1.1.1) archive-zip (0.7.0) arel (8.0.0, 7.1.4, 5.0.1.20140414130214) ast (2.3.0) authlogic (3.5.0) authlogic-oid (1.0.4) aws-sdk (2.10.17) aws-sdk-core (2.10.17) aws-sdk-resources (2.10.17) aws-sigv4 (1.0.1) axiom-types (0.1.1) bcrypt (3.1.11) better_errors (2.1.1) bigdecimal (default: 1.3.0) bindex (0.5.0) binding_of_caller (0.7.2) buftok (0.2.0) builder (3.2.3) bundler (1.16.0) byebug (9.1.0, 9.0.6) capybara (2.15.1) case_transform (0.2) chartkick (2.2.4) childprocess (0.7.1) chromedriver-helper (1.1.0) ci_reporter (2.0.0) ci_reporter_test_unit (1.0.1) climate_control (0.2.0) cocaine (0.5.8) cocoon (1.2.10) coderay (1.1.1) coercible (1.0.0) coffee-rails (4.2.2, 4.0.1) coffee-script (2.4.1) coffee-script-source (1.12.2) commonjs (0.2.7) composite_primary_keys (7.0.16) concurrent-ruby (1.0.5) connection_pool (2.2.1) countries (2.0.8) country_select (3.1.0) coveralls (0.8.21) crass (1.0.3) date_validator (0.9.0) debug_inspector (0.0.3) declarative (0.0.9) declarative-option (0.1.0) descendants_tracker (0.0.4) devise (4.3.0) devise_invitable (1.7.2) did_you_mean (1.1.0) diff-lcs (1.3) docile (1.1.5) domain_name (0.5.20170404) down (4.0.1) equalizer (0.0.11) erubi (1.7.0) erubis (2.7.0) et-orbi (1.0.5) exception_notification (4.2.1) excon (0.57.1) execjs (2.7.0) factory_girl (4.8.0) factory_girl_rails (4.8.0) faraday (0.13.1, 0.11.0) ffi (1.9.18) ffi-compiler (1.0.1) figaro (1.1.1) filterrific (2.1.2) formtastic (3.1.5) formtastic_i18n (0.6.0) friendly_id (5.2.3) geocoder (1.4.5, 1.4.4) geokit (1.11.0) geokit-rails (2.3.0) georuby (2.0.0) globalid (0.4.1, 0.4.0) google-api-client (0.13.1) google-cloud-core (1.0.0) google-cloud-env (1.0.1) google-cloud-language (0.27.0) google-cloud-vision (0.25.0) google-gax (0.8.5) google-protobuf (3.3.0 universal-darwin) googleapis-common-protos (1.3.5) googleauth (0.5.1) grape (0.19.1) grape-entity (0.6.0) grape-swagger (0.25.3) grape-swagger-entity (0.1.5) grape-swagger-rails (0.3.0) grape-swagger-ui (2.2.8) groupdate (3.2.0) grpc (1.4.1 universal-darwin) has_scope (0.7.1) hashie (3.5.6) headless (2.3.1) highline (1.7.10) hike (1.2.3) hiredis (0.6.1) http (2.2.2) http-cookie (1.0.3) http-form_data (1.0.3) http_accept_language (2.1.1) http_parser.rb (0.6.0) httpclient (2.8.3) i18n (0.9.1, 0.8.6) i18n-js (3.0.2) i18n_data (0.7.0) ice_nine (0.11.2) image_processing (0.4.4) impressionist (1.6.0) inherited_resources (1.7.2) io-console (default: 0.4.6) io-like (0.3.0) jasmine-core (2.8.0) jasmine-jquery-rails (2.0.3) jasmine-rails (0.14.7) jbuilder (2.7.0, 2.6.4) jmespath (1.3.1) jquery-rails (4.3.1, 3.1.4) json (default: 2.0.2, 1.8.6) json_expressions (0.9.0) jsonapi-renderer (0.1.3) jwt (1.5.6) kaminari (1.0.1) kaminari-actionview (1.0.1) kaminari-activerecord (1.0.1) kaminari-core (1.0.1) koala (3.0.0) launchy (2.4.3) less (2.6.0) less-rails (2.8.0) letter_opener (1.4.1) libv8 (3.16.14.19 x86_64-darwin-16) listen (3.1.5, 3.0.8) little-plugger (1.1.4) logging (2.2.2) loofah (2.1.1, 2.0.3) mail (2.7.0, 2.6.6) mandrill-api (1.0.53) materialize-sass (0.98.2, 0.97.8) memoist (0.16.0) memoizable (0.4.2) metaclass (0.0.4) method_source (0.9.0, 0.8.2) mime-types (3.1) mime-types-data (3.2016.0521) mini_magick (4.8.0) mini_mime (1.0.0, 0.1.4) mini_portile2 (2.3.0, 2.1.0) minitest (5.10.3, 5.10.1) minitest-reporters (1.1.19) mocha (1.3.0) monetize (1.6.0) money (6.8.4) money-rails (1.8.0) multi_json (1.12.2, 1.12.1) multi_xml (0.6.0) multipart-post (2.0.0) mustermann (0.4.0) mustermann-grape (0.4.0) mysql2 (0.3.21) naught (1.1.0) net-telnet (0.1.1) netrc (0.11.0) nifty-generators (0.4.6) nio4r (2.1.0) nokogiri (1.8.1, 1.7.2) oauth (0.5.3) oauth2 (1.4.0) omniauth (1.6.1) omniauth-facebook (4.0.0) omniauth-oauth2 (1.4.0) openssl (default: 2.0.3) options (2.3.2) orm_adapter (0.5.0) os (0.9.6) paperclip (4.1.1) parallel (1.12.0) parser (2.4.0.2) passenger (5.1.12) pg (0.21.0) phantomjs (2.1.1.0) php-serialize (1.2.0) polyamorous (1.3.1) power_assert (1.1.1, 0.4.1) powerpack (0.1.1) pr_geohash (1.0.0) progress_bar (1.1.0) protected_attributes (1.1.4) psych (default: 2.2.2) public_suffix (3.0.1, 2.0.5) puma (3.11.0, 3.9.1) pundit (1.1.0) rack (2.0.3, 1.5.5) rack-accept (0.4.5) rack-cors (1.0.2) rack-openid (1.4.2) rack-protection (2.0.0) rack-test (0.8.2, 0.6.3) rails (5.1.4, 5.0.6, 5.0.4, 4.1.16) rails-dom-testing (2.0.3) rails-html-sanitizer (1.0.3) rails-i18n (4.0.9) rails-perftest (0.0.7) rails_autolink (1.1.6) railties (5.1.4, 5.0.6, 5.0.4, 4.1.16) rainbow (2.2.2) rake (12.3.0, 12.0.0, 10.5.0) ransack (1.8.3) rb-fsevent (0.10.2) rb-inotify (0.9.10) rb-readline (0.5.5) rdiscount (2.2.0.1) rdoc (default: 5.0.0) recaptcha (4.6.2) redis (3.3.3) redis-actionpack (5.0.1) redis-activesupport (5.0.3) redis-namespace (1.5.3) redis-rack (2.0.2) redis-rails (5.0.2) redis-store (1.3.0) ref (2.0.0) representable (3.0.4) request_store (1.3.2) responders (2.4.0) rest-client (2.0.2) retriable (3.0.2) rly (0.2.3) roda (2.28.0) rsolr (2.1.0) rspec (3.7.0) rspec-core (3.7.0, 3.6.0) rspec-expectations (3.7.0, 3.6.0) rspec-mocks (3.7.0, 3.6.0) rspec-rails (3.6.0) rspec-support (3.7.0, 3.6.0) rubocop (0.51.0) ruby-openid (2.7.0) ruby-progressbar (1.9.0) ruby_dep (1.5.0) rubyzip (1.2.1) rufus-scheduler (3.4.2) sass (3.5.3, 3.5.1, 3.2.19) sass-listen (4.0.0) sass-rails (5.0.7, 5.0.6, 4.0.5) scrypt (3.0.5) selenium-webdriver (3.5.1) shrine (2.6.1) shrine-memory (0.3.0) sidekiq (5.0.4) sidekiq-cron (0.4.5) sidekiq-limit_fetch (3.4.0) signet (0.7.3) simple_form (3.5.0) simple_oauth (0.3.1) simplecov (0.14.1) simplecov-html (0.10.2) sixarm_ruby_unaccent (1.1.2) slack-notifier (2.2.2) sort_alphabetical (1.1.0) spring (2.0.2) spring-commands-rspec (1.0.4) spring-watcher-listen (2.0.1) sprockets (3.7.1, 2.12.4) sprockets-rails (3.2.1, 3.2.0, 2.3.3) sqlite3 (1.3.13) sunspot (2.2.7) sunspot_rails (2.2.7) term-ansicolor (1.6.0) test-unit (3.2.6, 3.2.3) therubyracer (0.12.3) thor (0.20.0, 0.19.4) thread_safe (0.3.6) tilt (2.0.8, 1.4.1) timecop (0.9.1) tins (1.16.3, 1.15.1) tool (0.2.3) turbolinks (5.0.1) turbolinks-source (5.0.3) twitter (6.1.0) twitter-text (1.14.7) tzinfo (1.2.4, 1.2.3) uber (0.1.0) uglifier (4.0.1, 3.2.0) unf (0.1.4) unf_ext (0.0.7.4) unicode-display_width (1.3.0) unicode_utils (1.4.0) upsert (2.2.1) virtus (1.0.5) warden (1.2.7) web-console (3.5.1) websocket-driver (0.6.5) websocket-extensions (0.1.3, 0.1.2) whiny_validation (0.1.1) will_paginate (3.1.6) will_paginate-bootstrap (1.0.1) xmlrpc (0.2.1) xpath (2.1.0)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/publiclab/plots2/issues/1829#issuecomment-350496189 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AABfJyvjPDU3GUXm9lnph-s5G1LUqq7Rks5s-tFPgaJpZM4Q5tk4

.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1829#issuecomment-350499115, or mute the thread https://github.com/notifications/unsubscribe-auth/AMg3MhRaIPEoYA_yxwUosc6hadp58rSNks5s-tyZgaJpZM4Q5tk4 .

GulfOfAlaska commented 6 years ago

Ah, switching to ruby 2.3.3 works!

jywarren commented 6 years ago

Oh, good to know! Thanks!

On Dec 10, 2017 2:51 AM, "Sng Ping Chiang" notifications@github.com wrote:

Ah, switching to ruby 2.3.3 works!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1829#issuecomment-350531276, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ9cOEpU5HL-pY5V6gu-rnlGQKb6wks5s-41ugaJpZM4Q5tk4 .

jywarren commented 6 years ago

Hi @kkavita92 how's it going? Can we be of any help or would you like to share what you've got?

jywarren commented 6 years ago

Or @spclight !!

membrq commented 6 years ago

Is this issue still up for grabs?

jywarren commented 6 years ago

Hi, @membrq - I haven't heard from @kkavita92 but willing to accept a pull request -- or to offer assistance -- to anyone here. There are also some new issues up in the candidates section here:

https://publiclab.github.io/community-toolbox/#r=all

These aren't quite as well documented but many are pretty close. Plenty of work to go around, and thank you!

membrq commented 6 years ago

Thanks, I appreciate that! I'll have a look at the candidates section as well.

membrq commented 6 years ago

Almost done setting up the environment. I followed steps 1-7 and 13, then tried to run passenger start. I got the following NoMethod error in localhost:3000.

app/models/comment.rb:66:in `parent'
app/views/dashboard/_node_comment.html.erb:7:in `_app_views_dashboard__node_comment_html_erb__3065054791743071505_70235479782800'
app/views/dashboard/_activity.html.erb:69:in `block in _app_views_dashboard__activity_html_erb___1944948765768292739_70235480958020'
app/views/dashboard/_activity.html.erb:65:in `each'
app/views/dashboard/_activity.html.erb:65:in `each_with_index'
app/views/dashboard/_activity.html.erb:65:in `_app_views_dashboard__activity_html_erb___1944948765768292739_70235480958020'
app/views/home/home.html.erb:124:in `block in _app_views_home_home_html_erb___245894073803635780_70235481472980'
app/views/home/home.html.erb:123:in `_app_views_home_home_html_erb___245894073803635780_70235481472980'
app/controllers/home_controller.rb:20:in `home'

Is there something else I need to do before starting the server?

membrq commented 6 years ago

Wanted to let you know that I'm no longer getting the above error. Haven't changed a thing since I last tried running the server, but now it's working. I guess the gremlins have forgiven me! :)

jywarren commented 6 years ago

Glad to hear it! :-)

On Jan 10, 2018 9:12 PM, "Marie-Élise" notifications@github.com wrote:

Wanted to let you know that I'm no longer getting the above error. Haven't changed a thing since I last tried running the server, but now it's working. I guess the gremlins have forgiven me! :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1829#issuecomment-356802075, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJyaoQmZzB1mnbHzunqPHDZxHOe9qks5tJW3cgaJpZM4Q5tk4 .

jywarren commented 6 years ago

Solved in #1955-- thanks!!!

publiclab / plots2