publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
957 stars 1.83k forks source link

Unwanted arrow symbol on getting started page #1858

Open SidharthBansal opened 6 years ago

SidharthBansal commented 6 years ago

When one hovers over https://publiclab.org/wiki/getting-started like button, a down arrow appears overlapping on the "Like" text image

There is no such drop down menu or any background issues as also in localhost:3000 same thing happens image

jywarren commented 6 years ago

Hmm, I think this is a css issue with Bootstrap, maybe... @ryzokuken may be upgrading to bootstrap 4 soon so I'm not sure if it's worth fixing just yet? Or we may be able to update bootstrap to the latest 3.x in our bower.json file.

On Dec 10, 2017 9:20 AM, "Sidharth Bansal" notifications@github.com wrote:

When one hovers over https://publiclab.org/wiki/getting-started like button, a down arrow appears overlapping on the "Like" text [image: image] https://user-images.githubusercontent.com/20972099/33805693-0665fb16-dde3-11e7-96b3-a241a726810f.png

There is no such drop down menu or any background issues as also in localhost:3000 same thing happens [image: image] https://user-images.githubusercontent.com/20972099/33805706-44a6bb68-dde3-11e7-8cb8-a89cdd5bb7c6.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1858, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ3JPnhMO7fChdbeOclB9poEp6hBeks5s--iFgaJpZM4Q8ge6 .

SidharthBansal commented 6 years ago

Also one thing to note, bootstrap is not responsive in urls displaying research notes tagged with a given tagname Eg publiclab.org/tag/balloon image I tried to change the list view to grid but I was not able to. I think the above issue will also be rectified once @ryzokuken upgrade the bootstrap Or shall I create separate issue for this

ryzokuken commented 6 years ago

Also one thing to note, bootstrap is not responsive in urls displaying research notes tagged with a given tagname

@SidharthBansal I don't think I understand what you meant by this, could you please elaborate?

As of the like text, I'll look into it and submit a patch soon.

ryzokuken commented 6 years ago

At first look, it's clear that this is a case of mispositioning of the tooltip arrow by bootstrap (it's supposed to be below the tooltip here). That said, things are a little complicated as we know this does not happen all the time. It never shows up at localhost for me, and it isn't even consistent across wiki pages on the publiclab website.

Example:

Let me inspect this a little more.

jywarren commented 6 years ago

I remember there being some kind of css positioning thing that fixed the display of popover menus in Bootstrap before. I wonder if this is similar or if we could search the commit log for "positioning"?

On Dec 11, 2017 4:23 AM, "Ujjwal Sharma" notifications@github.com wrote:

At first look, it's clear that this is a case of mispositioning of the tooltip arrow by bootstrap (it's supposed to be below the tooltip here). That said, things are a little complicated as we know this does not happen all the time. It never shows up at localhost for me, and it isn't even consistent across wiki pages on the publiclab website.

Example:

  • Getting started has this issue.

[image: screen shot 2017-12-11 at 2 48 37 pm] https://user-images.githubusercontent.com/13121330/33823963-da24a7aa-de82-11e7-8af5-b5dc9b99e8bd.png

  • Others like Basic Microscope Kit don't.

[image: screen shot 2017-12-11 at 2 47 29 pm] https://user-images.githubusercontent.com/13121330/33823999-ef63c330-de82-11e7-817c-b6296606d443.png

Let me inspect this a little more.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1858#issuecomment-350667039, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ4cj8Dh9AhhtkOFu2E0-Q1lU-cB0ks5s_PR-gaJpZM4Q8ge6 .

ryzokuken commented 6 years ago

@jywarren I'll look that up.

oorjitchowdhary commented 5 years ago

publiclab_spectralworkbe

This issue still persists. But this is the current flow. It minimizes the tab