Cancel button required for ease

grvsachdeva commented 6 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The problem

Addition of cancel button in edit mode of wiki page so that user need not visit header for going back and he can cancel editing easily.

What actually does happen (screenshot if helpful!):

Solution

Addition of hyperlink a tag named as "Cancel" here can1

Where to find the relevant lines of code: https://github.com/publiclab/plots2/blob/master/app/views/wiki/edit.html.erb#L22

You just need to figure out href link,try finding that out yourself first.You can always ask for help.

Steps to Fix

[x] claim this issue with a comment here, below, and ask any clarifying questions you need
[x] set up a repository locally following the README instructions, and make sure that all tests pass
[ ] try to fix the issue following the steps above, but even before you're done, you can:
[ ] commit your changes and start a pull request (see contributing to Public Lab software) but mark it as "in progress" if you have questions or if you haven't finished
[ ] alert someone via the developers list (see below) to have your pull request merged. This may take a few extra steps depending on when you do it, but we'll help you out!

Please email the developers list (see https://publiclab.org/wiki/developers) or go to the chatroom if you have questions, and take a look at our first-timers landing page for more information!

cesswairimu commented 6 years ago

I would like to contribute to this issue if that is okay

grvsachdeva commented 6 years ago

Hi @cesswairimu I am waiting to get input on this issue from @jywarren , once it gets approved its all yours

jywarren commented 6 years ago

Hi! Would the cancel button go back to the wiki page? If so, that sounds great.

On Jan 13, 2018 9:43 AM, "Gaurav Sachdeva" notifications@github.com wrote:

Hi @cesswairimu https://github.com/cesswairimu I am waiting to get input on this issue from @jywarren https://github.com/jywarren , once it gets approved its all yours

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1983#issuecomment-357440276, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ0J_bWLdz_QEWRoD6j36KM04Sd1Aks5tKMDggaJpZM4Rc94F .

grvsachdeva commented 6 years ago

Yes, Cancel button would redirect to the previous page.

grvsachdeva commented 6 years ago

So @cesswairimu you can take this issue.If you got stuck anywhere we are here to help.

jywarren commented 6 years ago

Great!

On Jan 13, 2018 10:21 AM, "Gaurav Sachdeva" notifications@github.com wrote:

Yes, Cancel button would redirect to the previous page.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1983#issuecomment-357442991, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ_dtT5f0VCVz7ZtNgwTlrNC4pTGbks5tKMnjgaJpZM4Rc94F .

jywarren commented 6 years ago

Hi, i'm just going to hold back on the first-timers-only label for now, do you think you could look over the guide at https://publiclab.github.io/community-toolbox/#r=all and https://publiclab.org/notes/warren/10-31-2016/create-a-welcoming-first-timers-only-issue-to-invite-new-software-contributors for a bit more on how to format these? Thank you so much!

grvsachdeva commented 6 years ago

Will definitely take care of format of FTO issues from now on.Thanks

jywarren commented 6 years ago

Thanks. Once done we can relabel and delete these comments to keep it simple.

grvsachdeva commented 6 years ago

Hi, @cesswairimu have you started working on this issue? If you want I can highlight the relevant files which need to be modified for solving this issue.

cesswairimu commented 6 years ago

@Gauravano yeah that would be great please. I am still having issues installing the project i shared in gitter my errors

grvsachdeva commented 6 years ago

Hey, @cesswairimu I have updated the issue, you can follow up with the link. And, we are working on fixing those errors in #1997.It would be corrected soon.

grvsachdeva commented 6 years ago

Hi @cesswairimu ,the issue about migration is resolved now , you can start working on it again and if you face any error , you can post it here too.

cesswairimu commented 6 years ago

@Gauravano Thanks a lot it works. I am working on the issue now

publiclab / plots2