search

publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
958 stars 1.83k forks source link

Profile page UI/UX inconsistencies #2173

Closed SidharthBansal closed 5 years ago

SidharthBansal commented 6 years ago

Please describe the problem (or idea)

The tabs on /profile/author have different treatment in terms of

What happened just before the problem occurred? Or what problem could this idea solve? 1)Either all should have count or none should 2)Same as 1 3)All should have text 4)Like should render the liked pages there also 5)One horizontal line 6)Pagination should be separately involved with each of the tabs 7)Only the creater should get the js prompt

SidharthBansal commented 6 years ago

@ViditChitkara thanks for solving 3rd issue in this via #2166

ViditChitkara commented 6 years ago

:+1:

SidharthBansal commented 6 years ago

@ebarry, @jywarren what do you suggest?

SidharthBansal commented 6 years ago

@ViditChitkara thanks for opening #2262 and doing #2263. @ViditChitkara Please notify me if you are working on some part of the issue. I was done with the counts on profile page but you pushed the changes so that others will not work on it.

SidharthBansal commented 6 years ago

@jywarren is anyone else working on remaining parts of these sub issues?

ViditChitkara commented 6 years ago

@SidharthBansal I didn't really had an idea that you were working on it. I just saw an untidy navbar while browsing on the mobile site and sent a patch for the same. Had I known someone was working on it, I would have been more than happy. Will take care about this in the future

SidharthBansal commented 6 years ago

No problem, btw great catch.

SidharthBansal commented 6 years ago

2294 is also a part of profile pages

jywarren commented 6 years ago

Is this one perhaps complete? Or anything remaining could be broken out as a narrower issue? Thanks!!!

SidharthBansal commented 6 years ago

One issue is left. Broken ajax.

jywarren commented 6 years ago

ah, ok - can you elaborate a bit on that? sorry, i didn't quite follow what was going wrong?

On Fri, Aug 3, 2018 at 12:08 PM Sidharth Bansal notifications@github.com wrote:

One issue is left. Broken ajax.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/2173#issuecomment-410300871, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ772qNrSykWEfNN-20SAmB8l2TjZks5uNHVqgaJpZM4Ry2hN .

SidharthBansal commented 6 years ago

Follow the following sequence

  1. Go to profile page
  2. Click the Like nav bar
  3. Click on 19 page from paginations given at the bottom
  4. You will be redirected to the Research nav bar and 19th page. Also, on the main welcome page also. When you switch over events from all events, etc. Refer #2258. Does this makes sense? I tried to debug this error. But the solution did not work. Solution is https://gist.github.com/jeroenr/3142686 or similar post. I remember very well that I tried almost 9-10 solutions similar to this post. But they did not work out. So this subissue was not resolved. Sorry for lingering for this error. One more issue has arisen on profile page --> Once you will go to comments nav bar. Then go to the second page of comments. You will notice a new page to be opened instead of Ajax. I have added this into the checklist.
jywarren commented 6 years ago

No problem, and thanks for carefully documenting this!

On Sun, Aug 5, 2018 at 12:37 AM Sidharth Bansal notifications@github.com wrote:

Follow the following sequence

  1. Go to profile page
  2. Click the Like nav bar
  3. Click on 19 page from paginations given at bottom
  4. You will be redirected to the Research nav bar and 19th page. This error is in whole website. At all the nav bars. On the main welcome page also. When you switch over events from all events, etc. Does this makes sense? I tried to debug this error. But the solution did not work. Solution is https://coderwall.com/p/viyn-w/will_paginate-and-ajax or similar post. I remember very well that I tried almost 9-10 solutions similar to this post. But they did not work out. So this subissue was not resolved. Sorry for lingering for this error. One more issue has arisen on profile page --> Once you will go on comments. Then go on second page of comments. You will notice a new page to be opened instead of ajax. I have added this into the checklist.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/2173#issuecomment-410495255, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ7D9OunGmfXJ-D1YEb5F7-19sCE8ks5uNnZXgaJpZM4Ry2hN .

digitaldina commented 5 years ago

Hey! I was going to open and issues about this, and this issue showed up as related. So I thought I might talk about it here. I went to go edit my profile, when I noticed that the prompt to add an image is below editing your bio and all that, which isn't very intuitive for users. Also, the header "bio" should be above the box where you edit your bio. I'm using the latest version of Firefox if that helps. We might even be able to make this a first-timers-only issue! (if the issue ends up being a quick fix) screenshot from 2018-12-20 21-23-13 screenshot from 2018-12-20 21-21-25

SidharthBansal commented 5 years ago

Are you willing to send a quick fix to it? On chrome on my laptop everything is working fine.

On Fri, Dec 21, 2018, 7:54 AM d1g1t4ld1n4 <notifications@github.com wrote:

Hey! I was going to open and issues about this, and this issue showed up as related. So I thought I might talk about it here. I went to go edit my profile, when I noticed that the prompt to add an image is below editing your bio and all that, which isn't very intuitive for users. Also, the header "bio" should be above the box where you edit your bio. I'm using the latest version of Firefox if that helps. [image: screenshot from 2018-12-20 21-23-13] https://user-images.githubusercontent.com/19677511/50321172-905e8180-049d-11e9-9eb5-db35e9c747f3.png [image: screenshot from 2018-12-20 21-21-25] https://user-images.githubusercontent.com/19677511/50321173-905e8180-049d-11e9-9fd2-9e174b5ff0e4.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/2173#issuecomment-449218848, or mute the thread https://github.com/notifications/unsubscribe-auth/AUACQwMoxr5M2F6khob6VTwfFFYDdI20ks5u7EZNgaJpZM4Ry2hN .

jywarren commented 5 years ago

Profile pages are fully rebooted!!! Thanks all!