search

publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Use RSpec for testing #2219

Open namangupta01 opened 6 years ago

namangupta01 commented 6 years ago

We are currently using old way of testing. I think we can replace this with newer way of testing and there is one of the gem called RSpec Gem which is very famous for rails testing. It makes writing of tests easier and more defined. It is very easy to find which test is failed and where because we use things like describe and context which makes the tests lot easier to read and write.

jywarren commented 6 years ago

I'm open to this, but it sounded like it could take some significant work to refactor our tests for RSpec -- do you know how much work it would be?

On Sat, Feb 3, 2018 at 2:46 PM, Naman Gupta notifications@github.com wrote:

We are currently using old way of testing. I think we can replace this with newer way of testing and there is one of the gem called RSpec Gem which is very famous for rails testing. It makes writing of tests easier and more defined. It is very easy to find which test is failed and where because we use things like describe and context which makes the tests lot easier to read and write.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/2219, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ0CXx9cUWCPYHACyIMslX5m0awXQks5tRLemgaJpZM4R4TJx .

namangupta01 commented 6 years ago

Hey @jywarren Yes, it would require a significant amount (a lot ) of work. But we can can implement it slowly on different branch so that our current branch don't get break until it gets complete.

jywarren commented 6 years ago

is it an all-or-nothing kind of change? Like, we couldn't gradually port things into RSpec?

On Tue, Feb 6, 2018 at 7:19 AM, Naman Gupta notifications@github.com wrote:

Hey @jywarren https://github.com/jywarren Yes, it would require a significant amount (a lot ) of work. But we can can implement it slowly on different branch so that our current branch don't get break until it gets complete.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/2219#issuecomment-363405781, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJxVZQ2WZ06trjoorNzpCUZssXbVoks5tSENqgaJpZM4R4TJx .

namangupta01 commented 6 years ago

No, we can do it in parts!

StlMaris123 commented 6 years ago

@namangupta01 @jywarren, just thinking about this feature. Well minitest is the testing framework for rails right? Why should we move to gem rspec yet they basically doing the same thing?