Typeahead inconsistencies

publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:

https://publiclab.org

GNU General Public License v3.0

957 stars 1.83k forks source link

Typeahead inconsistencies #3517

Closed stefannibrasil closed 5 years ago

stefannibrasil commented 5 years ago

We use this dependency to for our navbar and search typeahead results. But we have some problems that we need to investigate:

[ ] Depending on the query, the results are not grouped by category (Notes, Profiles, Questions, etc.). That leads to some duplicated categories being returned. When we get the JSON from the call, we see that the results are grouped by their doc_type, but the typeahead library breaks that somehow.

screenshot from 2018-09-27 12-03-30

[ ] Sometimes it does not show the button 'View all' that redirects to search/ page:

Not showing the button:

screenshot

Showing the button:

screenshot from 2018-09-27 12-11-58

sunilsj99 commented 5 years ago

Can you please describe the issue in more detail. I am interested in working on this @stefannibrasil

stefannibrasil commented 5 years ago

sure, @sunilsj99. The typeahead script is here. It gest data from the API. The API has the info about the item category, i.e., Note, Profile, Tag, etc. But somehow, the categories aren't grouped, sometimes Notes is returned twice, for example. When we get the JSON on the console, we see that the items are grouped by category, so we don't know exactly how the typeahead organize them.

stefannibrasil commented 5 years ago

The other thing is that the 'View all' button doesn't appear always, only for certain queries. We would appreciate any help/insights on those bugs, we don't have much JavaScript experience, so an extra help would be great!

roshniRam commented 5 years ago

@stefannibrasil can I work on this issue?

stefannibrasil commented 5 years ago

hi, @roshniRam yes, please! Sorry for the delay, I was on vacations. If you have any questions, feel free to ask.

jywarren commented 5 years ago

Hi @roshniRam are you by chance still interested in working on this at all? We'd love to have your help!

jywarren commented 5 years ago

We are now narrowing this to display only tags, and resolving it in https://github.com/publiclab/plots2/pull/5824!