Open jywarren opened 6 years ago
Great!!!
On Fri, Oct 12, 2018, 4:09 PM faithngetich notifications@github.com wrote:
Hey @jywarren https://github.com/jywarren I'd like to work on this issue.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/3681#issuecomment-429242151, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ3Ay-SbpNAmTQm_xtrKzxO3DTqewks5ukE4EgaJpZM4XY17j .
Cool. I'm on it.
Checklist
- [x] https://github.com/publiclab/community-toolbox/
- [x] https://github.com/publiclab/PublicLab.Editor/
- [x] https://github.com/publiclab/leaflet-environmental-layers/
- [x] https://github.com/publiclab/inline-markdown-editor/
- [x] https://github.com/publiclab/leaflet-blurred-location/
- [x] https://github.com/publiclab/leaflet-blurred-location-display/
- [x] https://github.com/publiclab/Leaflet.DistortableImage/
- [x] https://github.com/publiclab/image-sequencer/
- [x] https://github.com/publiclab/spectral-workbench/
- [x] https://github.com/publiclab/spectral-workbench.js/
- [x] https://github.com/publiclab/mapknitter/
- [x] https://github.com/publiclab/webjack/
- [x] https://github.com/publiclab/infragram/
- [x] https://github.com/publiclab/image-builder-rpi/
@jywarren I have raised the relevant PR's I have some questions though. This project's PR templates requires one to check a box with the instructions to add the issue it's fixing. So I am supposed to create a separate issue on that repo or should I manually add this issue's link in the description box?
@jywarren you forgot adding this text
We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.
@faithngetich have done all the work. So,... what do you think?
I really appreciate the work from Faith! Perhaps we can merge just one of Faith's PRs so others have a chance too? Thanks!!!
On Sat, Oct 13, 2018, 8:53 PM Gaurav Sachdeva notifications@github.com wrote:
@jywarren https://github.com/jywarren you forgot adding this text
We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.
@faithngetich https://github.com/faithngetich have done all the work. So,... what do you think?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/3681#issuecomment-429539548, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ-3IABwDt3To5vZR4ZeKWNtKmiirks5ukeIXgaJpZM4XY17j .
Hi, @faithngetich -- this is such a huge project, great work!
Would you mind going into the remaining PRs you've created and adapting them for the project they pertain to?
These all end up on publiclab.org:
https://github.com/publiclab/inline-markdown-editor/ https://github.com/publiclab/leaflet-blurred-location/ https://github.com/publiclab/leaflet-blurred-location-display/
This one ends up on Mapknitter.org:
https://github.com/publiclab/Leaflet.DistortableImage/
These on SpectralWorkbench.org:
https://github.com/publiclab/spectral-workbench/ https://github.com/publiclab/spectral-workbench.js/
This on https://webjack.io/examples/ :
https://github.com/publiclab/webjack/
This on infragram.org:
https://github.com/publiclab/infragram/
Thank you!!!
Hey, @jywarren I have made the changes. Thanks!!
@jywarren @SidharthBansal I was discussing with @gauravano in a PR to update a code of conduct the possibility of just using one organization wide .github
folder for these types of files: https://help.github.com/en/articles/creating-a-default-community-health-file-for-your-organization.
It would require creating a repository for storing default files, and then deleting it from every repo. I think it would be great to make this repo now, and then make a [multiple-use] GCI issue to delete files. It would also teach participants about good habits with keeping organized over multiple repos.
what are your thoughts?
Sounds good! Can you please explain the advantages and disadvantages of this approach in detail? Also please explain the directory structure. I mean whether there will be a single PL repo with plots2, MK, SWB etc. OR what? Sorry, I can't understand it completely. But +1 for decreasing redundancy.
On Sun, Sep 15, 2019 at 11:56 PM Sasha Boginsky notifications@github.com wrote:
@jywarren https://github.com/jywarren @SidharthBansal https://github.com/SidharthBansal I was discussing with @gauravano https://github.com/gauravano in a PR to update a code of conduct the possibility of just using one organization wide .github folder for these types of files: https://help.github.com/en/articles/creating-a-default-community-health-file-for-your-organization .
It would require creating a repository for storing default files, and then deleting it from every repo. I think it would be great to make this repo now, and then make a [multiple-use] GCI issue to delete files. It would also teach participants about good habits with keeping organized over multiple repos.
what are your thoughts?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/3681?email_source=notifications&email_token=AFAAEQYRX367DUHG43MB4P3QJZ44NA5CNFSM4F3DL3R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XWIOQ#issuecomment-531588154, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAAEQ2JTVPL4YKWOTKKLELQJZ44NANCNFSM4F3DL3RQ .
Oh interesting... that would be nice to not have to update for each project..!
On Mon, Sep 16, 2019 at 12:25 PM Sidharth Bansal notifications@github.com wrote:
Sounds good! Can you please explain the advantages and disadvantages of this approach in detail? Also please explain the directory structure. I mean whether there will be a single PL repo with plots2, MK, SWB etc. OR what? Sorry, I can't understand it completely. But +1 for decreasing redundancy.
On Sun, Sep 15, 2019 at 11:56 PM Sasha Boginsky notifications@github.com wrote:
@jywarren https://github.com/jywarren @SidharthBansal https://github.com/SidharthBansal I was discussing with @gauravano https://github.com/gauravano in a PR to update a code of conduct the possibility of just using one organization wide .github folder for these types of files:
https://help.github.com/en/articles/creating-a-default-community-health-file-for-your-organization .
It would require creating a repository for storing default files, and then deleting it from every repo. I think it would be great to make this repo now, and then make a [multiple-use] GCI issue to delete files. It would also teach participants about good habits with keeping organized over multiple repos.
what are your thoughts?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/publiclab/plots2/issues/3681?email_source=notifications&email_token=AFAAEQYRX367DUHG43MB4P3QJZ44NA5CNFSM4F3DL3R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XWIOQ#issuecomment-531588154 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AFAAEQ2JTVPL4YKWOTKKLELQJZ44NANCNFSM4F3DL3RQ
.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/3681?email_source=notifications&email_token=AAAF6J7ST6TCSQ574LYQ5TLQJ6XMXA5CNFSM4F3DL3R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6ZWY4Y#issuecomment-531852403, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J3BXMA7KTAZCZOAWJ3QJ6XMXANCNFSM4F3DL3RQ .
Hey @jywarren Id like to take on this issue, Im a first timer so Ill need additional links and information on how to tackle this
Projects pending first-timer issue templates:
For the first-timer-only templates we could only implement for with projects that have had first-timer-only
issues? One can check that by filtering the issues with the label e.g for image-sequencer - https://github.com/publiclab/image-sequencer/issues?q=is%3Aopen+is%3Aissue+label%3Afirst-timers-only (remember to check the closed list too). Also maybe beneficial to explore https://github.com/publiclab/plots2/issues/3681#issuecomment-531588154 further, maybe try with fto template as there are more of those pending?
Hi @cesswairimu @TildaDares I have added a welcomebot file to the pi-builder project and also sent a pull request. Kindly approve and merge.
This issue can be used multiple times since there are a lot of Public Lab projects that need it! Please solve it for only one repository so that others can have a chance as well.
We have a very nice
welcomebot
message that appears for new issues and pull requests, with helpful information. We also have really nice templates forfirst-timers-bot
to automatically create [first-timers-only issues](). Welcomebot messages on issues, for example, look like this:We've refined the messages shown in the
plots2
project (this one!) a lot, and the customized message would be great to copy over into other Public Lab repositories.Copy the files
The files live in the following locations:
You can see a pull request where @VaaibhaviSingh did this (for the welcomebot config):
https://github.com/publiclab/community-toolbox/pull/45/files
Find a place to copy to
There are several Public Lab projects that either don't have these templates (in which case you will need to make a new
.github
folder and place the files inside!) or have them, but they don't have the latest texts. See these projects:Once you've done one, help us remember to check it off the list. But be aware - even it it's checked off, if the files have changed, we may need to copy over the updates!
Make tweaks to the text
Some lines are specific to the project, and will have to be modified slightly to work in the other projects. For example, this line says
published to PublicLab.org
but for the Community Toolbox project, it should sayhttps://code.publiclab.org
. Each project has a URL on its main repository page, which could be linked to.https://github.com/publiclab/plots2/blob/ca114039f8551eeded2cbeec145211cc37708e2d/.github/config.yml#L22