search

publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
957 stars 1.83k forks source link

Integrate new autocompletion code from PublicLab.Editor #4798

Open jywarren opened 5 years ago

jywarren commented 5 years ago

This code is now out of date:

https://github.com/publiclab/plots2/blob/fe50428f4c56f12fcea92ae76343346d0421da70/app/views/editor/rich.html.erb#L326-L327

We have a great new autocompletion system in the Editor project, and are working on documenting/refining it here: https://github.com/publiclab/PublicLab.Editor/issues/55

This should allow autocompletion of @usernames, #tags, and :emoji: using the At.js library. A few more steps to complete the integration but this will be great! Any help appreciated both completing https://github.com/publiclab/PublicLab.Editor/issues/55 and here once that is complete.

jywarren commented 5 years ago

@rexagod just so you see this here too!

vlad-at-work commented 5 years ago

Hey @jywarren , is somebody working on this issue ? I would like to help with this one. How could I start ?

jywarren commented 5 years ago

This would be great and I think there may be some work to be done on the editor project first to standardize how it's connected up. Maybe @rexagod can offer some input?

On Wed, Feb 20, 2019, 6:33 AM Vlad <notifications@github.com wrote:

Hey @jywarren https://github.com/jywarren , is somebody working on this issue ? I would like to help with this one. How could I start ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/4798#issuecomment-465600497, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJwJRayGJ1I4d1l53f-giIUajQK2Iks5vPVyogaJpZM4a6Vha .

rexagod commented 5 years ago

Hey @vladdypwnz! You can start by commenting out both of the lines mentioned above. Then we can continue this here.

@jywarren After documenting atwho in the README, I'll focus on implementing https://github.com/publiclab/PublicLab.Editor/issues/55#issuecomment-463383624.

jywarren commented 5 years ago

Awesome, thanks both of you!!

On Wed, Feb 20, 2019, 1:09 PM Pranshu Srivastava <notifications@github.com wrote:

Hey @vladdypwnz https://github.com/vladdypwnz! You can start by commenting out https://github.com/publiclab/PublicLab.Editor/issues/55#issuecomment-463379041 both of the lines mentioned above. Then we can continue on this here https://github.com/publiclab/PublicLab.Editor/issues/55#issuecomment-463383624 .

@jywarren https://github.com/jywarren After documenting atwho in the README, I'll focus on implementing publiclab/PublicLab.Editor#55 (comment) https://github.com/publiclab/PublicLab.Editor/issues/55#issuecomment-463383624 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/4798#issuecomment-465754783, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJw2pzv2kLqDI-JKg6JxwdxPzcDfCks5vPblggaJpZM4a6Vha .

PritiShaw commented 5 years ago

Hi @jywarren I am an outreachy aspirant and new to open source. I would like to work on this issue. Kindly assign it to me if no one else is working on it.