search

publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Inconcistency in the number of comments at research notes #4905

Open SidharthBansal opened 5 years ago

SidharthBansal commented 5 years ago

image 1comment at the top vs 0 comments at the bottom.

SidharthBansal commented 5 years ago

Refer https://publiclab.org/notes/er_jkshah/02-28-2019/global-warming-and-greenhouse-effect#comments

jywarren commented 5 years ago

oh hmm, do you think it's counting spam comments?

On Sun, Mar 3, 2019 at 2:51 PM Sidharth Bansal notifications@github.com wrote:

Refer https://publiclab.org/notes/er_jkshah/02-28-2019/global-warming-and-greenhouse-effect#comments

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/4905#issuecomment-469057224, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ_RXVfdw2FL86H6VXAsJ6TMsQXdyks5vTCeQgaJpZM4bbMiP .

Anjalizi commented 5 years ago

@SidharthBansal you must close this issue for it has been resolved.

SidharthBansal commented 5 years ago

There is some problem with the role. I guess the banned user comments are also counted. So please change the model code to have role of normal user only. Thanks

On Tue, Mar 12, 2019, 1:39 PM Anjali Jain notifications@github.com wrote:

i would like to work on this issue, please help me get started.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/4905#issuecomment-471897597, or mute the thread https://github.com/notifications/unsubscribe-auth/AUACQ5tWzAlhNyiyx1bUeXZ5zOc1Xc4Oks5vV2DWgaJpZM4bbMiP .

Anjalizi commented 5 years ago

Now it shows 0 comments on the top and bottom both comments

grvsachdeva commented 5 years ago

moderators may have deleted those comments, that's why count looks normal now. I checked the code and yes, comments other than status = 1 are also counted. Let's use fetch_comments function which gives comments as per user status. I created that some time ago, and it can be used here.

@Anjalizi you want to solve this issue or can I create FTOs from here?

Thanks!

Anjalizi commented 5 years ago

I want to solve this issue.

grvsachdeva commented 5 years ago

Great, go ahead!

Cadreia commented 4 years ago

Hello, is this issue still open? Because I checked, and the number of comments at the top which were inconsistent with that at the bottom have been removed. I'm an Outreachy internship applicant and would like to work on this, but I don't really understand what is expected to be done here