Change tooltip data placement parameter

ananyaarun commented 5 years ago

Refer to issue #5027 Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] 📝 Update the file _header.html.erb in the plots Repository to change the data placement parameter of tooltip from top to bottom. Changes need to be done in the following lines L60,L67,L73,L81,L91,L98.

See this page for some help in taking your first steps!

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

ananyaarun commented 5 years ago

@gauravano , this is one part of issue #5027 . Fixing this would ensure pop up msg is always downwards.

grvsachdeva commented 5 years ago

Hey @ananyaarun, let's put this on halt for now and wait to see how - https://github.com/publiclab/plots2/issues/5045 goes? As I can see edit the edit buttons on wiki and so don't the tooltip view disrupted but yes a newcomer may experience this.

I think adding the CSS may be sufficient?

ananyaarun commented 5 years ago

@gauravano Sure :) Lets see how the fix goes regarding issue #5045 . So maybe that can be used as a FTO issue now ? I can add more details regarding overriding bootstrap and setting the width of the tooltip in a CSS file if required.

grvsachdeva commented 5 years ago

yes, I labeled #5045 as FTO just some minutes ago

publiclab / plots2