Closed gautamig54 closed 4 years ago
Sure. I'll check it out first then.
Just https://github.com/publiclab/plots2/pull/5902 now? 🎉
I updated some of the checklist but probably not all -- thanks!
This is now up at https://stable.publiclab.org/tag/balloon-mapping
Hi @jywarren This looks cool
But for notes, Are these images not loaded ?
Hi jeff!! Should I work on notes card ? :thinking:
For the images, I think on stable, the images may not be pointed properly but they should work on production. Can you look at the URL of the image and change "stable.publiclab.org" to "publiclab.org" to see if it really exists on production? Thanks!
On Fri, Jul 5, 2019 at 12:23 PM Lekhika Dugtal notifications@github.com wrote:
Hi jeff!! Should I work on notes card ? 🤔
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/5890?email_source=notifications&email_token=AAAF6J7VGIHNZ22GT4HF233P55YPHA5CNFSM4HXV2FR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZJ42CA#issuecomment-508808456, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6JYQ4ZGIYSO3KGE2UMTP55YPHANCNFSM4HXV2FRQ .
Should I decrease the height of note title ?
This isn't pushed to production yet I guess.
It's being pushed right now :smiley:
Hi @jywarren. I am seeing this option for "how to edit this card" in the ellipsis of the main card. I don't think I added this. Is this deliberately done?
Yes, I added that! I made a page on PublicLab.org to help explain this feature :-)
On Mon, Jul 8, 2019 at 2:37 PM Gautami Gupta notifications@github.com wrote:
Hi @jywarren https://github.com/jywarren. I am seeing this option for "how to edit this card" in the ellipsis of the main card. I don't think I added this. Is this deliberately done?
[image: Screen Shot 2019-07-09 at 12 05 10 AM] https://user-images.githubusercontent.com/35326753/60834075-738d5f80-a1dd-11e9-87ce-a64539a2750a.png
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/5890?email_source=notifications&email_token=AAAF6J4JXRAEL6TR4MVEHALP6OCNZA5CNFSM4HXV2FR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZN7HUY#issuecomment-509342675, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J2WUMF2J2TPCSEPIWTP6OCNZANCNFSM4HXV2FRQ .
I closed #5902 PR, due to many design conflicts as it got delayed. I will open a new PR for the same and other required changes.
Do we need the format toggle options in the new design or we can remove it?
I think we can remove it, thanks!
On Mon, Jul 8, 2019 at 3:27 PM Gautami Gupta notifications@github.com wrote:
Do we need the format toggle options in the new design or we can remove it?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/5890?email_source=notifications&email_token=AAAF6JZYHA3NTQZDVY4E2Z3P6OIIFA5CNFSM4HXV2FR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZODHUA#issuecomment-509359056, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J2NXSRUTCY46FO7UYTP6OIIFANCNFSM4HXV2FRQ .
@jywarren here in the design there are a few drop-downs whose purpose I am not able to understand. Like in "Post a question", what will be there in the drop down? The ellipsis beside the types dropdown and in the sidebar beside the "see people near"?
In Post a question
I thought it might go to different types of posts. But if we implement the popup template menu shown here:
Then the dropdown there wouldn't be necessary, and we could just say Post
. What do you think?
The other two, I think we can skip, since we have one in the top card. They were just other suggested places to "tuck away" or hide extra functionality!
@jywarren , So do you want a modal kind of pop up to select the template from? We can even have it as options in drop down. And yes, if we are going with giving user options to select their purpose, we have to change to "Post".
Hey @gautamig54, we can use dropdown but this design https://github.com/publiclab/plots2/issues/5890#issuecomment-509830813 looks really great, so can you try to implement it?
Hi @gautamig54 Are you working on the post button
? and using modal and all ?
Hi @CleverFool77! I have been a bit busy lately. I am working on the remaining tasks on the tags page. I will push the changes very soon. Sorry for the delay!
Hi @gautamig54 If you want, I can do the task of Posting a Question ? What do you say ? As I can see you still have some tasks left in other pages.
What is suppose to be in the dropdown of posting a question?
Cool. You work on this, I'll start with dashboard then. In post question dropdown, There should be a modal which would let us choose template. @jywarren had added one draft design for it on style guide. Thanks !!!
On Sun, Aug 4, 2019 at 10:17 PM Gautami Gupta notifications@github.com wrote:
What is suppose to be in the dropdown of posting a question?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/5890?email_source=notifications&email_token=AGLS6ST3JAKPXSV3ZMN2T4TQC4BY3A5CNFSM4HXV2FR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3QFLZY#issuecomment-518018535, or mute the thread https://github.com/notifications/unsubscribe-auth/AGLS6STF2LBT3RV2FA7QFI3QC4BY3ANCNFSM4HXV2FRQ .
@gauravano @aSquare14 I have a few doubts regarding the options available for the post.
Hi @gautamig54 First of all , I don't seem to completely understand your question though, But I'll try to explain whatever I understood.
We need to have the options like we have in our dashboard for Share your Work
, In this dashboard we have options such as Notes
, Wikis
and Questions
. etc -
In here, what we are suppossed to have is the modal for choosing between notes, qikis and questions I guess.
cc: @gauravano @aSquare14
And what you wrote about Issue/story/project and stuff - Instead doing it for Wikis
Note
and Questions
like we have in dashboard would be good.
And Here one of the main thing to notice is that we won't have be directly posting but rather we should have tag attached for that particular tag as This is posting either Note
or Question
on that tag. SO You need to make sure that tag is attached.
Like this which we currently have for posting question for particular tag -
I implemented what I understood @CleverFool77. I have attached the tags and they working correctly. Except in issues I added the tag, issue-brief-tagname. I think this is how it works. For others I did the same as you suggested.
Also, @CleverFool77 I was thinking, if we can have a separate issue for correcting the view for the mobile view or tab view. What do you think?
Hi @gautamig54 Is there need to create more issue ? we can just add this in checklist of follow up fixes and bugs. As If we'll keep on creating issues, we will have lots of issue for every bug. So its better to just checklist them in one existing issue. Cool.
Sorry to reply slowly here, but i hope it helps clarify - the original dashboard with the dropdown of options to post is intended to be replaced by the modal (showing /before/ redirecting to the editor, because which editor depends on the selection made) because the modal gives us more space to explain what the different types are for. As it is now, newcomers seeing the dropdown may not understand easily what each "type" of post is for, so the modal gives us some space to explain this. Could this work? The modal could be its own partial template. We'll just want to be sure it renders nicely in mobile.
On Thu, Aug 8, 2019 at 2:01 PM Lekhika Dugtal notifications@github.com wrote:
Hi @gautamig54 https://github.com/gautamig54 Is there need to create more issue ? we can just add this in checklist of follow up fixes and bugs. As If we'll keep on creating issues, we will have lots of issue for every bug. So its better to just checklist the in one existing issue. Cool.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/5890?email_source=notifications&email_token=AAAF6J4ELSFTANVA3S6L3ITQDPHBZA5CNFSM4HXV2FR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD32ZXDQ#issuecomment-519412622, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J535HT4GKGYXOQZLQDQDPHBZANCNFSM4HXV2FRQ .
Cool. @gautamig54 has updated this modal feature in her pr. cc: @jywarren
I think we're almost done here too, just need to ensure sorting works! I crossed out a couple we're not doing.
@CleverFool77 were you interested in wrapping up the sorting issue, or at least breaking it out into a new issue under the same milestone that is a bit more thoroughly documented? Then we can close this out!
I believe this is almost complete, except for this issue which I'm going to link to! https://github.com/publiclab/plots2/issues/6307
Thanks all!
Next we start with the implementation of individual tags page.
Checklist
cc : @CleverFool77