search

publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Follow up bugs in new designs of All sections including Profile,Tags, People etc #6097

Closed CleverFool77 closed 5 years ago

CleverFool77 commented 5 years ago
gautamig54 commented 5 years ago

That content is limited to 2 lines as you can see in air-quality tag.

On Fri, Aug 30, 2019, 12:35 Lekhika Dugtal notifications@github.com wrote:

Hi @gautamig54 https://github.com/gautamig54 The bug is not in subscribe button rather its the distortion because of huge content for that particular tag. If you would have noticed than you must have seen that we are able to subscribe other tags.

And I've recently updated the subscribed button work. As earlier, we are just able to subscribe to related-tags but not that actual tag. So It will be updated soon when it get pushed to production.

To fix this bug, we can limit the content of a particular tag to be shown in the main card of that individual tag page.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AINQWIOHGFLNWVQP57QIIYTQHDBCFA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QYO7I#issuecomment-526485373, or mute the thread https://github.com/notifications/unsubscribe-auth/AINQWIOK2JZI62WCFNXYJ7LQHDBCFANCNFSM4II6ZY4A .

CleverFool77 commented 5 years ago

ohk Cool. So bug is somewhere else. But not in button I guess. Is there any other pages which you have seen with same bug ? of not able to subscribe ?

jywarren commented 5 years ago

Hm, is it limited by # of newlines, or # of characters? Could this just be a really really long paragraph?

On Fri, Aug 30, 2019 at 3:12 AM Lekhika Dugtal notifications@github.com wrote:

ohk Cool. So bug is somewhere else. But not in button I guess. Is there any other pages which you have seen with same bug ? of not able to subscribe ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AAAF6J63NPN7VC2CEIEPVFLQHDB45A5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QY6CY#issuecomment-526487307, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6JZKBAMDVPTBTSPNF7TQHDB45ANCNFSM4II6ZY4A .

CleverFool77 commented 5 years ago

Hi @gautamig54 As jeff asked, did you add limit by newline ?

On Fri, Aug 30, 2019 at 10:26 PM Jeffrey Warren notifications@github.com wrote:

Hm, is it limited by # of newlines, or # of characters? Could this just be a really really long paragraph?

On Fri, Aug 30, 2019 at 3:12 AM Lekhika Dugtal notifications@github.com wrote:

ohk Cool. So bug is somewhere else. But not in button I guess. Is there any other pages which you have seen with same bug ? of not able to subscribe ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AAAF6J63NPN7VC2CEIEPVFLQHDB45A5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QY6CY#issuecomment-526487307 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAAF6JZKBAMDVPTBTSPNF7TQHDB45ANCNFSM4II6ZY4A

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AGLS6SRVSEFAQFWDB7KGXCDQHFGLBA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5SGOPQ#issuecomment-526673726, or mute the thread https://github.com/notifications/unsubscribe-auth/AGLS6SQWUF7HPBLSUQVASO3QHFGLBANCNFSM4II6ZY4A .

gautamig54 commented 5 years ago

Yes. I have limited the content by the number of lines.

SidharthBansal commented 5 years ago

This is really amazing piece of work folks. Super thanks

jywarren commented 5 years ago

Oops, re-opening! Also, we found this one, could be related to #6027 perhaps...

image

The URL is https://publiclab.org/tag/activity:*/author/mimiss

Thanks!!!

jywarren commented 5 years ago

I noticed the edit button in the new sidebar is not visible in mobile-width devices. Could there be a relatively quick fix for this?

CleverFool77 commented 5 years ago

HI @gautamig54 @jywarren Upcoming week would be my exams , So I won't be able to contribute much. I would be regular from next week onward.

Thanks !!

CleverFool77 commented 5 years ago

I noticed the edit button in the new sidebar is not visible in mobile-width devices. Could there be a relatively quick fix for this?

I'll Fix it. Thanks !!

SidharthBansal commented 5 years ago

Great Lekhika!

On Fri, Sep 13, 2019 at 8:10 AM Lekhika Dugtal notifications@github.com wrote:

I noticed the edit button in the new sidebar is not visible in mobile-width devices. Could there be a relatively quick fix for this?

I'll Fix it. Thanks !!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AFAAEQ5V4C7RFXGR3VKVXK3QJL4SHA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6TZRUA#issuecomment-531077328, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAAEQ2I4R4ZEGIDDEJAJDTQJL4SHANCNFSM4II6ZY4A .

jywarren commented 5 years ago

I think i've got the edit button fix in my big new PR here: #6322 -- lots of fixes there!

CleverFool77 commented 5 years ago

Thanks for the fix @jywarren . My exams has ended finally. I'll look for other fixes in the design. Thanks !!

jywarren commented 5 years ago

awesome. I'm working on a lot of smaller items in #6326! I'd love help with the weird ones with the wildcard tags, where the tag card is going a bit out of control. And the one where there's a big space below the tag card on /tag/____ on mobile devices!

On Tue, Sep 24, 2019 at 6:40 AM Lekhika Dugtal notifications@github.com wrote:

Thanks for the fix @jywarren https://github.com/jywarren . My exams has ended finally. I'll look for other fixes in the design. Thanks !!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AAAF6J3F76SW6N77EY24WRTQLHU6RA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7N5FJY#issuecomment-534500007, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J5BXSOXU7BOKLKOT7LQLHU6RANCNFSM4II6ZY4A .

jywarren commented 5 years ago

Aha - ok, now the tag page header cards are really in bad shape, and I think I found the issue. These lines set percentage-based positioning, and the use of row/col is a little odd within the card:

https://github.com/publiclab/plots2/blob/02b44b9daafc1ec0e8bc4f4dbb1f575ed7587336/app/views/tag/show.html.erb#L73-L126

If you are able to do some reworking of this, please do, and we'll try to rush it into production late tonight or early tomorrow.

image image

I think we should set top: 70px and redo the row/col code there. That should address a lot of the other issues with that card as well!

jywarren commented 5 years ago

That is, the wiki-sub and tag-buttons should be in their own <div class="row">, i think!

jywarren commented 5 years ago

Quick attempt here: https://github.com/publiclab/plots2/pull/6328

jywarren commented 5 years ago

Continued work here: https://github.com/publiclab/plots2/pull/6330

I am still not getting the background to show up on mobile screens:

image

But everything else is relatively better organized and with fewer custom styles. There are still some custom .card styles however, in /app/views/notes/_notes.html.erb -- I'd prefer to go with strict Bootstrap styles as much as possible, as it helps avoid the kinds of unexpected layout issues we're seeing here! https://getbootstrap.com/docs/4.3/components/card/

jywarren commented 5 years ago

Oof, made it even worse in some scenarios. It's very strange that there are differences between stable, local, and production!

image

jywarren commented 5 years ago

OK, did some more work on this, and the latest changes are publishing to the live site now!

jywarren commented 5 years ago

Lots of pages look much better now!!!

jywarren commented 5 years ago

I believe this is complete now. Any last follow-ups?

CleverFool77 commented 5 years ago

I guess this is ready. Thanks @jywarren !!!