Closed jywarren closed 5 years ago
Here's the issue, by the way - duplicate appearance of nodes on my profile page demonstrates it!
Ohh Yes, It would be better. Besides we are using tag cards everywhere. This would decrease our load somehow.
Yes, This seems like a good solution. And with the shifting of website structure to being it topic oriented, this will prove to be a great and help reduce redundancy. And not only on the tags page, this will be helpful in profile page, dashboard etc.
Awesome!
On Sat, Aug 24, 2019 at 8:03 AM Lekhika Dugtal notifications@github.com wrote:
Ohh Yes, It would be better. Besides we are using tag cards everywhere. This would decrease our load somehow.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/6199?email_source=notifications&email_token=AAAF6J5VE7E5M6XUPJFKO7DQGEPNNA5CNFSM4IPC5CG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5B6XBA#issuecomment-524544900, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J5XEWD4EGEDT4PY7KTQGEPNNANCNFSM4IPC5CGQ .
Ah, the fix didn't work in profile pages but it did on /tags!
The tag cards on https://publiclab.org/tags can often show the same post multiple times per page. Let's do this:
createTagCard()
createTagCard(exclude)
array ofnids
that we should excludenids
that it will be displaying, which can be added to a list ofnids
that should be excluded from subsequent tag cards.So the flow would look like:
@CleverFool77 @gautamig54 what do you think of this?